Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/3915
@tzulitai I have fixed `setStartFromSpecificDate` problem, and updated
`FlinkKafkaConsumer08` so that it supports to set start offsets of Kafka by date
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015307#comment-16015307
]
ASF GitHub Bot commented on FLINK-6352:
---
Github user zjureel commented on the issue:
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3937
[FLINK-6482] [core] Add nested serializers to config snapshots of composite
serializers
This commit adds also the nested serializers themselves to the
configuration snapshots of composite serializ
[
https://issues.apache.org/jira/browse/FLINK-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015315#comment-16015315
]
ASF GitHub Bot commented on FLINK-6482:
---
GitHub user tzulitai opened a pull request:
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r117175199
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java
---
@@ -187,31 +19
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r117175607
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java
---
@@ -171,6 +170
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r117175760
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -311,12
[
https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015323#comment-16015323
]
ASF GitHub Bot commented on FLINK-6352:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015322#comment-16015322
]
ASF GitHub Bot commented on FLINK-6352:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015324#comment-16015324
]
ASF GitHub Bot commented on FLINK-6352:
---
Github user tzulitai commented on a diff in
Github user WangTaoTheTonic closed the pull request at:
https://github.com/apache/flink/pull/3525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user WangTaoTheTonic commented on the issue:
https://github.com/apache/flink/pull/3525
@tillrohrmann I've tried with your commit and the issue is resolved,
thanks. Closing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hongyuhong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r117176330
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamJoinRule.scala
---
@@ -0,0 +1,69 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015328#comment-16015328
]
ASF GitHub Bot commented on FLINK-6020:
---
Github user WangTaoTheTonic closed the pull
[
https://issues.apache.org/jira/browse/FLINK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015327#comment-16015327
]
ASF GitHub Bot commented on FLINK-6020:
---
Github user WangTaoTheTonic commented on th
[
https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015329#comment-16015329
]
ASF GitHub Bot commented on FLINK-6232:
---
Github user hongyuhong commented on a diff
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3525
Great to hear @WangTaoTheTonic. Thanks a lot for testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015364#comment-16015364
]
ASF GitHub Bot commented on FLINK-6020:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3926#discussion_r117180703
--- Diff: docs/dev/stream/queryable_state.md ---
@@ -208,10 +208,16 @@ Once used in a job, you can retrieve the job ID and
then query any key's current
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3926
Thanks for your contribution @gosubpl. Changes look good to me. Merging
this and addressing my comment while doing so.
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/FLINK-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015372#comment-16015372
]
ASF GitHub Bot commented on FLINK-6570:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015373#comment-16015373
]
ASF GitHub Bot commented on FLINK-6570:
---
Github user tillrohrmann commented on the i
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3926
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-6570.
--
Resolution: Fixed
Fix Version/s: 1.4.0
1.3.0
1.4.0: 85e281be3835fe8bb0
[
https://issues.apache.org/jira/browse/FLINK-6570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015380#comment-16015380
]
ASF GitHub Bot commented on FLINK-6570:
---
Github user asfgit closed the pull request
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3889#discussion_r117182703
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowTimeSortProcessFunction.scala
---
@@ -0,0 +1,169 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015385#comment-16015385
]
ASF GitHub Bot commented on FLINK-6075:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3919#discussion_r117183206
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
---
@@ -245,6 +264,7
[
https://issues.apache.org/jira/browse/FLINK-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015387#comment-16015387
]
ASF GitHub Bot commented on FLINK-6583:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3919#discussion_r117183489
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
---
@@ -131,6 +135,19
[
https://issues.apache.org/jira/browse/FLINK-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015389#comment-16015389
]
ASF GitHub Bot commented on FLINK-6583:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng updated FLINK-6619:
---
Description:
In this JIRA. I will do the following tasks for Flink 1.3.0 RC01 Release.
* Check that th
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3901
This looks good! I'll do some final tweaks to the styling of the code and
then merge this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
[
https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015411#comment-16015411
]
ASF GitHub Bot commented on FLINK-6288:
---
Github user tzulitai commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sunjincheng updated FLINK-6618:
---
Description:
I find 2 bugs as follows:
1. {{GroupWindowStringExpressionTest}} testcase bug:
{{Assert
constantine stanley created FLINK-6622:
--
Summary: flink master code not compiling
Key: FLINK-6622
URL: https://issues.apache.org/jira/browse/FLINK-6622
Project: Flink
Issue Type: Bug
constantine stanley created FLINK-6623:
--
Summary: unable to build flink master
Key: FLINK-6623
URL: https://issues.apache.org/jira/browse/FLINK-6623
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-6622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-6622.
---
Resolution: Duplicate
This is not a compilation issue; the problem is that one of the tests ca
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3746
Hi @haohui, I revisited this, but I think there is no easy workaround for
this, unfortunately.
This can only be properly merged in 1.4 after some additional requirements
are added to Flink.
[
https://issues.apache.org/jira/browse/FLINK-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015457#comment-16015457
]
ASF GitHub Bot commented on FLINK-4022:
---
Github user tzulitai commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai updated FLINK-6482:
---
Priority: Blocker (was: Critical)
> Add nested serializers into configuration snapsho
[
https://issues.apache.org/jira/browse/FLINK-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015459#comment-16015459
]
Chesnay Schepler commented on FLINK-6623:
-
It would be great if you could provide
[
https://issues.apache.org/jira/browse/FLINK-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-6623:
Summary: Several tests fail on Windows (was: unable to build flink master)
> Several tests
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3905
LGTM
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
[
https://issues.apache.org/jira/browse/FLINK-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015463#comment-16015463
]
ASF GitHub Bot commented on FLINK-6585:
---
Github user fhueske commented on the issue:
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3936#discussion_r117196683
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/stringexpr/GroupWindowStringExpressionTest.scala
---
@@ -
Ted Yu created FLINK-6624:
-
Summary: SharedBuffer#hashCode() uses multiplier in wrong way
Key: FLINK-6624
URL: https://issues.apache.org/jira/browse/FLINK-6624
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015464#comment-16015464
]
ASF GitHub Bot commented on FLINK-6618:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaowei Jiang closed FLINK-6621.
Resolution: Fixed
no need to open jira for checks
> Legal check for 1.3.0 RC01 Release
> --
Github user 397090770 commented on the issue:
https://github.com/apache/flink/pull/3869
@tzulitai Thank you for your review very much. The current structuring of
the ES output format as follow:
 uses multiplier in wrong way
> ---
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3854#discussion_r117198127
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointFrom11MigrationITCase.java
---
@@ -129,7 +129,7 @@ public
[
https://issues.apache.org/jira/browse/FLINK-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015473#comment-16015473
]
Kostas Kloudas commented on FLINK-6624:
---
Thanks for reporting this [~tedyu], I will
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3854
Looks good to me, minus one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-6612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-6612:
-
Priority: Blocker (was: Critical)
> ZooKeeperStateHandleStore does not guard against concurrent d
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r117200048
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
---
@@ -0,0 +1,323 @@
+/*
+ * Licen
[
https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015475#comment-16015475
]
ASF GitHub Bot commented on FLINK-6232:
---
Github user fhueske commented on a diff in
Till Rohrmann created FLINK-6625:
Summary: Flink removes HA job data when reaching JobStatus.FAILED
Key: FLINK-6625
URL: https://issues.apache.org/jira/browse/FLINK-6625
Project: Flink
Issue
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/3938
[FLINK-6624] [cep] Fix SharedBuffer#hashCode().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink cep-hash
Alternatively you can review a
[
https://issues.apache.org/jira/browse/FLINK-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015487#comment-16015487
]
ASF GitHub Bot commented on FLINK-6624:
---
GitHub user kl0u opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015488#comment-16015488
]
ASF GitHub Bot commented on FLINK-6574:
---
Github user KurtYoung commented on a diff i
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r117201965
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -37,25 +36,10 @@ import org.apache.f
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r117202009
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala
---
@@ -0,0 +1,488 @@
+/*
+ * Licensed to th
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117199375
--- Diff: docs/setup/yarn_setup.md ---
@@ -245,6 +245,18 @@ Note: You can use a different configuration directory
per job by setting the env
Note
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3938
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015492#comment-16015492
]
ASF GitHub Bot commented on FLINK-6031:
---
Github user rmetzger commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015490#comment-16015490
]
ASF GitHub Bot commented on FLINK-6031:
---
Github user rmetzger commented on a diff in
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117199176
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -665,58 +685,52 @@ public ApplicationReport startAppMast
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117198446
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -200,6 +214,17 @@ public void setTaskManagerMemory(int m
[
https://issues.apache.org/jira/browse/FLINK-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015491#comment-16015491
]
ASF GitHub Bot commented on FLINK-6031:
---
Github user rmetzger commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015493#comment-16015493
]
ASF GitHub Bot commented on FLINK-6618:
---
Github user sunjincheng121 commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015489#comment-16015489
]
ASF GitHub Bot commented on FLINK-6232:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015494#comment-16015494
]
ASF GitHub Bot commented on FLINK-6624:
---
Github user asfgit closed the pull request
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3936#discussion_r117202137
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/stringexpr/GroupWindowStringExpressionTest.scala
---
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/3938
Lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/FLINK-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015495#comment-16015495
]
ASF GitHub Bot commented on FLINK-6624:
---
Github user tedyu commented on the issue:
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3938
Merging this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3901
@zjureel I'll be merging this only for 1.4-SNAPSHOT. The main reason is
that there is a lot of deprecation / API change with this, and I'll like to
ship it along with other API changes we had in min
[
https://issues.apache.org/jira/browse/FLINK-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas closed FLINK-6624.
-
Resolution: Fixed
> SharedBuffer#hashCode() uses multiplier in wrong way
> ---
[
https://issues.apache.org/jira/browse/FLINK-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015498#comment-16015498
]
ASF GitHub Bot commented on FLINK-6624:
---
Github user kl0u commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015499#comment-16015499
]
ASF GitHub Bot commented on FLINK-6288:
---
Github user tzulitai commented on the issue
Till Rohrmann created FLINK-6626:
Summary: Unifying lifecycle management of SubmittedJobGraph- and
CompletedCheckpointStore
Key: FLINK-6626
URL: https://issues.apache.org/jira/browse/FLINK-6626
Projec
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3936
Thanks for the update. +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
[
https://issues.apache.org/jira/browse/FLINK-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015503#comment-16015503
]
ASF GitHub Bot commented on FLINK-6618:
---
Github user fhueske commented on the issue:
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117204403
--- Diff: docs/setup/yarn_setup.md ---
@@ -245,6 +245,18 @@ Note: You can use a different configuration directory
per job by setting the env
Note
[
https://issues.apache.org/jira/browse/FLINK-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015505#comment-16015505
]
ASF GitHub Bot commented on FLINK-6031:
---
Github user rmetzger commented on a diff in
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3931#discussion_r117204729
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -665,58 +685,52 @@ public ApplicationReport startAppMaster
[
https://issues.apache.org/jira/browse/FLINK-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015509#comment-16015509
]
ASF GitHub Bot commented on FLINK-6031:
---
Github user zentol commented on a diff in t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r117205051
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamJoinRule.scala
---
@@ -0,0 +1,69 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015510#comment-16015510
]
ASF GitHub Bot commented on FLINK-6232:
---
Github user fhueske commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3928#discussion_r117205738
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityUtils.java
---
@@ -230,10 +230,15 @@ private void validate() {
Github user gyfora commented on the issue:
https://github.com/apache/flink/pull/3901
Well, I can understand it but will mean that we have to keep running with a
custom build because there is no way to work around this nicely.
---
If your project is set up for it, you can reply to thi
[
https://issues.apache.org/jira/browse/FLINK-6608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015513#comment-16015513
]
ASF GitHub Bot commented on FLINK-6608:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015515#comment-16015515
]
ASF GitHub Bot commented on FLINK-6288:
---
Github user gyfora commented on the issue:
Github user gyfora commented on the issue:
https://github.com/apache/flink/pull/3901
On the other hand this is potentially causing major data skew or errors for
any people who are using the dynamic topics (they might not even be aware of
it).
---
If your project is set up for it, yo
[
https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015517#comment-16015517
]
ASF GitHub Bot commented on FLINK-6288:
---
Github user gyfora commented on the issue:
Github user zjureel commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r117206216
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer08.java
---
@@ -187,31 +191
[
https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015518#comment-16015518
]
ASF GitHub Bot commented on FLINK-6352:
---
Github user zjureel commented on a diff in
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3928
Thanks for the reviews @sunjincheng121 @EronWright.
I personally prefer to stick with the regex approach. But really either way
is fine :)
Don't really expect any test errors on this, bu
1 - 100 of 296 matches
Mail list logo
