[jira] [Commented] (FLINK-6031) Add parameter for per job yarn clusters to control whether the user code jar is included into the system classloader.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-6031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015490#comment-16015490
 ] 

ASF GitHub Bot commented on FLINK-6031:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3931#discussion_r117199176
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ---
    @@ -665,58 +685,52 @@ public ApplicationReport startAppMaster(JobGraph 
jobGraph, YarnClient yarnClient
                                        1));
                }
     
    +           String configuredUserJarInclusion = 
flinkConfiguration.getString(YarnConfigOptions.CLASSPATH_INCLUDE_USER_JAR);
    +           YarnConfigOptions.UserJarInclusion userJarInclusion;
    +           try {
    +                   userJarInclusion = 
YarnConfigOptions.UserJarInclusion.valueOf(configuredUserJarInclusion.toUpperCase());
    +           } catch (IllegalArgumentException e) {
    +                   LOG.warn("Configuration parameter {} was configured 
with an invalid value {}. Falling back to default ({}).",
    +                           
YarnConfigOptions.CLASSPATH_INCLUDE_USER_JAR.key(),
    +                           configuredUserJarInclusion,
    +                           
YarnConfigOptions.CLASSPATH_INCLUDE_USER_JAR.defaultValue());
    +                   userJarInclusion = 
YarnConfigOptions.UserJarInclusion.valueOf(YarnConfigOptions.CLASSPATH_INCLUDE_USER_JAR.defaultValue());
    --- End diff --
    
    This also seems very similar to the other duplicates.


> Add parameter for per job yarn clusters to control whether the user code jar 
> is included into the system classloader.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6031
>                 URL: https://issues.apache.org/jira/browse/FLINK-6031
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>            Priority: Critical
>
> FLINK-4913 added the user jar into the system classloader, when starting a 
> Flink per job YARN cluster.
> Some users were experiencing issues with the changed behavior.
> I suggest to introduce a new yarn specific configuration parameter (for the 
> flink-conf.yaml file) to control if the user jar is added into system 
> classloader.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)