[GitHub] flink issue #3732: [FLINK-6250] Distinct procTime with Rows boundaries

2017-04-25 Thread rtudoran
Github user rtudoran commented on the issue: https://github.com/apache/flink/pull/3732 @fhueske @stefanobortoli I suggest we merge this temporary solution into flink (with using a special marker for distinct) until the flink module will be upgraded to the next calcite release. I have

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982492#comment-15982492 ] ASF GitHub Bot commented on FLINK-6250: --- Github user rtudoran commented on the issue

[GitHub] flink pull request #3768: [FLINK-6368][table] Grouping keys in stream aggreg...

2017-04-25 Thread xccui
GitHub user xccui opened a pull request: https://github.com/apache/flink/pull/3768 [FLINK-6368][table] Grouping keys in stream aggregations have wrong order ​FLINK-5768 removed the `AggregateUtil.createPrepareMapFunction` stage, who maps all grouping keys to the first n fields of

[jira] [Commented] (FLINK-6368) Grouping keys in stream aggregations have wrong order

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982497#comment-15982497 ] ASF GitHub Bot commented on FLINK-6368: --- GitHub user xccui opened a pull request:

[GitHub] flink pull request #3758: [FLINK-5855][Streaming Connectors] Unprotected acc...

2017-04-25 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/3758 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...

2017-04-25 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3758 @kl0u Yep. I reopened this PR again for waiting you message me. Haha ~ Okay, Now, I will close it and then create another jira and cc you. --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982521#comment-15982521 ] ASF GitHub Bot commented on FLINK-5855: --- Github user zhangminglei commented on the i

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982522#comment-15982522 ] ASF GitHub Bot commented on FLINK-5855: --- Github user zhangminglei closed the pull re

[GitHub] flink issue #3768: [FLINK-6368][table] Grouping keys in stream aggregations ...

2017-04-25 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3768 Thanks for the fix @xccui! +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[jira] [Commented] (FLINK-6368) Grouping keys in stream aggregations have wrong order

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982523#comment-15982523 ] ASF GitHub Bot commented on FLINK-6368: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...

2017-04-25 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3758 @zhangminglei Perfect! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982527#comment-15982527 ] ASF GitHub Bot commented on FLINK-5855: --- Github user kl0u commented on the issue:

[jira] [Reopened] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reopened FLINK-5855: - > Unprotected access to pendingFilesPerCheckpoint in BucketingSink > -

[jira] [Closed] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang closed FLINK-5855. --- Resolution: Fixed > Unprotected access to pendingFilesPerCheckpoint in BucketingSink > ---

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-04-25 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3766 Thanks for the PR @fanyon. I'll try to look at the changes soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982531#comment-15982531 ] ASF GitHub Bot commented on FLINK-6288: --- Github user tzulitai commented on the issue

[GitHub] flink issue #3765: [FLINK-6373] Add runtime support for distinct aggregation...

2017-04-25 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3765 Hi @haohui, thanks for the PR! I like the approach of the wrapping distinct aggregator. Unfortunately, this approach won't work with the upcoming changes for the the UDAGG interface. The `A

[jira] [Commented] (FLINK-6373) Add runtime support for distinct aggregation over grouped windows

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982533#comment-15982533 ] ASF GitHub Bot commented on FLINK-6373: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-6337) Remove the buffer provider from PartitionRequestServerHandler

2017-04-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982534#comment-15982534 ] zhijiang commented on FLINK-6337: - [~uce], do you think it makes sense to remove the buffe

[jira] [Commented] (FLINK-6337) Remove the buffer provider from PartitionRequestServerHandler

2017-04-25 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982545#comment-15982545 ] Ufuk Celebi commented on FLINK-6337: Hey [~zjwang]! I think the buffer pool is require

[GitHub] flink issue #3768: [FLINK-6368][table] Grouping keys in stream aggregations ...

2017-04-25 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3768 Thanks for fixing this so quickly @xccui! I will test this fix with my branch and merge this later today. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-6368) Grouping keys in stream aggregations have wrong order

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982555#comment-15982555 ] ASF GitHub Bot commented on FLINK-6368: --- Github user twalthr commented on the issue:

[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113133585 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~> 0.1.0) -jekyll-

[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113133944 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~> 0.1.0) -jekyll-

[jira] [Commented] (FLINK-6302) Documentation build error on ruby 2.4

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982558#comment-15982558 ] ASF GitHub Bot commented on FLINK-6302: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6302) Documentation build error on ruby 2.4

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982557#comment-15982557 ] ASF GitHub Bot commented on FLINK-6302: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6337) Remove the buffer provider from PartitionRequestServerHandler

2017-04-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982574#comment-15982574 ] zhijiang commented on FLINK-6337: - Thank you for so quick response! Currently the buffer

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982583#comment-15982583 ] ASF GitHub Bot commented on FLINK-6008: --- Github user NicoK commented on the issue:

[GitHub] flink issue #3512: [FLINK-6008] collection of BlobServer improvements

2017-04-25 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3512 After investigating a bit further, I noticed that this problem is actually a bit bigger: Even in `FileSystemBlobStore`, there is no guarantee that a directory will not be deleted concurrently (from

[jira] [Closed] (FLINK-6319) Add timeout when shutting SystemProcessingTimeService down

2017-04-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-6319. Resolution: Not A Problem The user reported that the exceptions occurred when cancelling a job. This

[GitHub] flink issue #3762: [FLINK-6361] [table] Refactoring the AggregateFunction in...

2017-04-25 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3762 Hi @shaoxuan-wang, I made another pass over the PR and think it looks good. I can address the changes I suggested and also add a `SingleElementIterable` instead of using `ArrayList` and finally me

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982592#comment-15982592 ] ASF GitHub Bot commented on FLINK-6361: --- Github user fhueske commented on the issue:

[jira] [Updated] (FLINK-5711) Deserialization schema that gives has full kafka log information

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-5711: -- Fix Version/s: (was: 1.2.1) 1.2.2 > Deserialization schema that gives has

[jira] [Updated] (FLINK-6102) Update protobuf to latest version

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6102: -- Fix Version/s: (was: 1.2.1) 1.2.2 > Update protobuf to latest version > -

[jira] [Updated] (FLINK-6142) RemoteStreamExecutionEnvironment throw class cast exception

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6142: -- Fix Version/s: (was: 1.2.1) 1.2.2 > RemoteStreamExecutionEnvironment thro

[jira] [Updated] (FLINK-5808) Missing verification for setParallelism and setMaxParallelism

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-5808: -- Fix Version/s: (was: 1.2.1) 1.2.2 > Missing verification for setParalleli

[jira] [Updated] (FLINK-5030) Support hostname verification

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-5030: -- Fix Version/s: (was: 1.2.1) 1.2.2 > Support hostname verification > -

[jira] [Updated] (FLINK-5908) Blob Cache can (rarely) get corrupted on failed blob downloads

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-5908: -- Fix Version/s: (was: 1.2.1) 1.2.2 > Blob Cache can (rarely) get corrupted

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-25 Thread tonycox
Github user tonycox commented on the issue: https://github.com/apache/flink/pull/3760 @ramkrish86 Hi, Thank you for the PR. Could you repush commit? ``` git commit --amend gut push origin FLINK-5752 -f ``` --- If your project is set up for it, you can reply to this ema

[jira] [Created] (FLINK-6380) BlobService concurrency issues between delete and put/get methods

2017-04-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-6380: -- Summary: BlobService concurrency issues between delete and put/get methods Key: FLINK-6380 URL: https://issues.apache.org/jira/browse/FLINK-6380 Project: Flink

[jira] [Commented] (FLINK-5752) Support push down projections for HBaseTableSource

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982597#comment-15982597 ] ASF GitHub Bot commented on FLINK-5752: --- Github user tonycox commented on the issue:

[jira] [Assigned] (FLINK-6208) Implement skip till next match strategy

2017-04-25 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas reassigned FLINK-6208: - Assignee: Dawid Wysakowicz > Implement skip till next match strategy > --

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982606#comment-15982606 ] ASF GitHub Bot commented on FLINK-6075: --- Github user rtudoran commented on a diff in

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-25 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r113143239 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* +

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-25 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3760 @tonycox Thanks for the comment? Just curious. Any reason for the repush - is it for checking the test failures again? --- If your project is set up for it, you can reply to this email and h

[jira] [Commented] (FLINK-5752) Support push down projections for HBaseTableSource

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982607#comment-15982607 ] ASF GitHub Bot commented on FLINK-5752: --- Github user ramkrish86 commented on the iss

[jira] [Comment Edited] (FLINK-6337) Remove the buffer provider from PartitionRequestServerHandler

2017-04-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982574#comment-15982574 ] zhijiang edited comment on FLINK-6337 at 4/25/17 9:20 AM: -- Hey [~

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-04-25 Thread gyfora
Github user gyfora commented on the issue: https://github.com/apache/flink/pull/3766 Hi, Thanks for the PR! The first problem I noticed with this approach is that it will not work if users want to partition dynamically created topics (my use case actually). We sh

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982630#comment-15982630 ] ASF GitHub Bot commented on FLINK-6288: --- Github user gyfora commented on the issue:

[jira] [Updated] (FLINK-6374) In yarn cluster model, the -ys parameter is not take effect.

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6374: -- Component/s: YARN > In yarn cluster model, the -ys parameter is not take effect. > -

[jira] [Updated] (FLINK-6376) when deploy flink cluster on the yarn, it is lack of hdfs delegation token.

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6376: -- Component/s: YARN Security > when deploy flink cluster on the yarn, it is lack

[jira] [Updated] (FLINK-6377) Support map types in the Table / SQL API

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6377: -- Component/s: Table API & SQL > Support map types in the Table / SQL API > --

[jira] [Updated] (FLINK-6373) Add runtime support for distinct aggregation over grouped windows

2017-04-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6373: -- Component/s: Table API & SQL > Add runtime support for distinct aggregation over grouped windows

[GitHub] flink issue #3762: [FLINK-6361] [table] Refactoring the AggregateFunction in...

2017-04-25 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3762 Hi @fhueske , it is good to have a dedicated Iterable for pair-merge. Please go ahead. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982650#comment-15982650 ] ASF GitHub Bot commented on FLINK-6361: --- Github user shaoxuan-wang commented on the

[GitHub] flink issue #3762: [FLINK-6361] [table] Refactoring the AggregateFunction in...

2017-04-25 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3762 Thanks, will merge then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982655#comment-15982655 ] ASF GitHub Bot commented on FLINK-6361: --- Github user fhueske commented on the issue:

[jira] [Created] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
mingleizhang created FLINK-6381: --- Summary: Unnecessary synchronizing object in BucketingSink Key: FLINK-6381 URL: https://issues.apache.org/jira/browse/FLINK-6381 Project: Flink Issue Type: Bug

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113167440 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -95,5 +95,12 @@ flink-metrics-statsd-${project.version}.jar

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982722#comment-15982722 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-6367) support custom header settings of allow origin

2017-04-25 Thread shijinkui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982764#comment-15982764 ] shijinkui commented on FLINK-6367: -- [~greghogan] We need configure some special allow_ori

[jira] [Commented] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982763#comment-15982763 ] mingleizhang commented on FLINK-6381: - It seems that currently there are two places sh

[jira] [Comment Edited] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982763#comment-15982763 ] mingleizhang edited comment on FLINK-6381 at 4/25/17 11:58 AM: -

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3720 I can confirm that you can build the docs on W10 with the Linux Subsystem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Comment Edited] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982763#comment-15982763 ] mingleizhang edited comment on FLINK-6381 at 4/25/17 11:59 AM: -

[jira] [Commented] (FLINK-6302) Documentation build error on ruby 2.4

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982766#comment-15982766 ] ASF GitHub Bot commented on FLINK-6302: --- Github user zentol commented on the issue:

[jira] [Updated] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-6381: Description: It seems that currently there are two places should not employ the {{synchronized}} to

[jira] [Issue Comment Deleted] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-6381: Comment: was deleted (was: It seems that currently there are two places should not employ the {{syn

[jira] [Assigned] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reassigned FLINK-6381: --- Assignee: mingleizhang > Unnecessary synchronizing object in BucketingSink >

[GitHub] flink issue #3567: [FLINK-6107] Add custom checkstyle for flink-streaming-ja...

2017-04-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3567 @aljoscha i believe enough earth rotations have passed :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-6107) Add custom checkstyle for flink-streaming-java

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982781#comment-15982781 ] ASF GitHub Bot commented on FLINK-6107: --- Github user zentol commented on the issue:

[GitHub] flink pull request #3769: [FLINK-6367] support custom header settings of all...

2017-04-25 Thread shijinkui
GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3769 [FLINK-6367] support custom header settings of allow origin `jobmanager.web.access-control-allow-origin`: Enable custom access control parameter for allow origin header, default is `*`. -

[jira] [Commented] (FLINK-6367) support custom header settings of allow origin

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982783#comment-15982783 ] ASF GitHub Bot commented on FLINK-6367: --- GitHub user shijinkui opened a pull request

[jira] [Assigned] (FLINK-6367) support custom header settings of allow origin

2017-04-25 Thread shijinkui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shijinkui reassigned FLINK-6367: Assignee: shijinkui > support custom header settings of allow origin >

[GitHub] flink pull request #3769: [FLINK-6367] support custom header settings of all...

2017-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3769#discussion_r113178604 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -701,6 +701,9 @@ @Deprecated public static final

[jira] [Commented] (FLINK-6367) support custom header settings of allow origin

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982787#comment-15982787 ] ASF GitHub Bot commented on FLINK-6367: --- Github user zentol commented on a diff in t

[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints

2017-04-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 Thanks for the review @StephanEwen. You're right that it should not be necessary to assign a name to the `TaskExecutor` and the `ResourceManager`. Will change it so that these components assign

[jira] [Commented] (FLINK-6155) Allow to specify endpoint names

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982835#comment-15982835 ] ASF GitHub Bot commented on FLINK-6155: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-25 Thread mtunique
Github user mtunique commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113186880 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~> 0.1.0) -jekyl

[jira] [Commented] (FLINK-6302) Documentation build error on ruby 2.4

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982838#comment-15982838 ] ASF GitHub Bot commented on FLINK-6302: --- Github user mtunique commented on a diff in

[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-25 Thread mtunique
Github user mtunique commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113186869 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~> 0.1.0) -jekyl

[jira] [Commented] (FLINK-6302) Documentation build error on ruby 2.4

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982839#comment-15982839 ] ASF GitHub Bot commented on FLINK-6302: --- Github user mtunique commented on a diff in

[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints

2017-04-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 I think I have to correct myself. In the general case, there might be the need to connect from the dispatcher component to `ResourceManager`. If the `ResourceManager` runs in a different process

[jira] [Commented] (FLINK-6155) Allow to specify endpoint names

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982887#comment-15982887 ] ASF GitHub Bot commented on FLINK-6155: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982893#comment-15982893 ] ASF GitHub Bot commented on FLINK-6361: --- Github user asfgit closed the pull request

[GitHub] flink pull request #3762: [FLINK-6361] [table] Refactoring the AggregateFunc...

2017-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3762 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Closed] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-25 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-6361. Resolution: Implemented Fix Version/s: 1.3.0 Implemented with 589e45c5c50c328783f71d219c6606e

[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113198925 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~> 0.1.0) -jekyll-

[jira] [Commented] (FLINK-6302) Documentation build error on ruby 2.4

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982899#comment-15982899 ] ASF GitHub Bot commented on FLINK-6302: --- Github user zentol commented on a diff in t

[GitHub] flink issue #3752: [FLINK-6306] [filesystem-connectors] Sink for eventually ...

2017-04-25 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/3752 @tzulitai you took interest in the jira ticket, would you be willing to review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[jira] [Commented] (FLINK-6306) Sink for eventually consistent file systems

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982904#comment-15982904 ] ASF GitHub Bot commented on FLINK-6306: --- Github user sjwiesman commented on the issu

[GitHub] flink pull request #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-04-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3720#discussion_r113201398 --- Diff: docs/Gemfile.lock --- @@ -30,18 +30,19 @@ GEM redcarpet (~> 3.1) safe_yaml (~> 1.0) toml (~> 0.1.0) -jekyll-

[jira] [Commented] (FLINK-6302) Documentation build error on ruby 2.4

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982907#comment-15982907 ] ASF GitHub Bot commented on FLINK-6302: --- Github user zentol commented on a diff in t

[GitHub] flink issue #2696: [FLINK-3347] [akka] Add QuarantineMonitor which shuts a q...

2017-04-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2696 I propose to merge this PR into the master such that it is disabled per default. This entails that we don't require our own heartbeats from the TMs to the `JobManager`. This will make

[jira] [Commented] (FLINK-3347) TaskManager (or its ActorSystem) need to restart in case they notice quarantine

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982915#comment-15982915 ] ASF GitHub Bot commented on FLINK-3347: --- Github user tillrohrmann commented on the i

[jira] [Updated] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-6381: Description: It seems that currently there are two places should not employ the {{synchronized}} to

[jira] [Updated] (FLINK-6381) Unnecessary synchronizing object in BucketingSink

2017-04-25 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-6381: Description: It seems that currently there are two places should not employ the {{synchronized}} to

[GitHub] flink issue #3622: [FLINK-6136] Separate EmbeddedHaServices and StandaloneHa...

2017-04-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3622 Rebased onto the latest `master`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[jira] [Commented] (FLINK-6136) Separate EmbeddedNonHaServices and NonHaServices

2017-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982921#comment-15982921 ] ASF GitHub Bot commented on FLINK-6136: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-6337) Remove the buffer provider from PartitionRequestServerHandler

2017-04-25 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982936#comment-15982936 ] Ufuk Celebi commented on FLINK-6337: Just double checked this and I think you are righ

  1   2   3   >