[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982722#comment-15982722 ]
ASF GitHub Bot commented on FLINK-6013: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113167440 --- Diff: flink-dist/src/main/assemblies/opt.xml --- @@ -95,5 +95,12 @@ <destName>flink-metrics-statsd-${project.version}.jar</destName> <fileMode>0644</fileMode> </file> + + <file> + <source>../flink-metrics/flink-metrics-datadog/target/flink-metrics-datadog-${project.version}.jar</source> --- End diff -- The `maven-jar-plugin` creates 2 jars. For the datadog reporter these are, right now, 1. `flink-metrics-datadog-1.3-SNAPSHOT.jar` 2. `flink-metrics-datadog-1.3-SNAPSHOT-jav-with-dependencies.jar` The first jar doesn't contain any dependencies, whereas the second one contains all dependencies declared in the pom.xml, as long as the aren't set to `provided`. We want the latter to be placed in `/opt`, as such the `<source>` tag must point to that jar. Basically replace the existing `<source>` configuration with `<source>../flink-metrics/flink-metrics-datadog/target/flink-metrics-datadog-${project.version}-jar-with-dependencies.jar</source>` > Add Datadog HTTP metrics reporter > --------------------------------- > > Key: FLINK-6013 > URL: https://issues.apache.org/jira/browse/FLINK-6013 > Project: Flink > Issue Type: Improvement > Components: Metrics > Affects Versions: 1.3.0 > Reporter: Bowen Li > Assignee: Bowen Li > Priority: Critical > Fix For: 1.3.0 > > > We at OfferUp use Datadog a lot for metrics and dashboards, and I believe a > lot other companies also do. > Flink right now only has a StatsD metrics reporter, and users have to set up > Datadog Agent in order to receive metrics from StatsD and transport them to > Datadog. We don't like this approach. > We prefer to have a Datadog metrics reporter directly contacting Datadog http > endpoint. > I'll take this ticket myself. -- This message was sent by Atlassian JIRA (v6.3.15#6346)