Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2265
No, there is no FLIP about it. I think a discussion in JIRA or in this PR
should be enough. That's why I haven't documented it yet. I was inspired by
your
[document](https://docs.google.com/documen
[
https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383717#comment-15383717
]
ASF GitHub Bot commented on FLINK-3097:
---
Github user twalthr commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383738#comment-15383738
]
ASF GitHub Bot commented on FLINK-4183:
---
Github user twalthr commented on the issue:
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2221
I will merge this later today if there are no objections...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
David Moravek created FLINK-4232:
Summary: Flink executable does not return correct pid
Key: FLINK-4232
URL: https://issues.apache.org/jira/browse/FLINK-4232
Project: Flink
Issue Type: Bug
GitHub user dmvk opened a pull request:
https://github.com/apache/flink/pull/2268
[FLINK-4232] Make sure ./bin/flink returns correct pid
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dmvk/flink FLINK-4232
Alternatively you can
[
https://issues.apache.org/jira/browse/FLINK-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383770#comment-15383770
]
ASF GitHub Bot commented on FLINK-4232:
---
GitHub user dmvk opened a pull request:
Github user fpompermaier commented on the issue:
https://github.com/apache/flink/pull/1989
Hi @twalthr, any news about this? Are you going to merge this PR in the
upcoming 1.1 release?
If you were waiting for a feedback you have my +1 about your strategy..go
ahead and convert the
[
https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383819#comment-15383819
]
ASF GitHub Bot commented on FLINK-3901:
---
Github user fpompermaier commented on the i
[
https://issues.apache.org/jira/browse/FLINK-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383846#comment-15383846
]
Maximilian Michels commented on FLINK-4223:
---
Seems like a duplicate of FLINK-371
[
https://issues.apache.org/jira/browse/FLINK-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels closed FLINK-4223.
-
Resolution: Duplicate
> Rearrange scaladoc and javadoc for Scala API
> ---
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2265
Yes, you are right. I'm just a little concerned about the class name of
`ScalarFunction`, haha..
In addition, Java Table API should be `table.select("hashCode(text)");`
which is better I t
[
https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383858#comment-15383858
]
ASF GitHub Bot commented on FLINK-3097:
---
Github user wuchong commented on the issue:
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2109
I'll try to review this as soon as possible. Maybe @kl0u or @zentol also
want to have another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383863#comment-15383863
]
ASF GitHub Bot commented on FLINK-3677:
---
Github user mxm commented on the issue:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2265
Yes, @wuchong's suggestion for the Java Table API seems more extensible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
[
https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383869#comment-15383869
]
ASF GitHub Bot commented on FLINK-3097:
---
Github user aljoscha commented on the issue
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2249
Thanks for the update. Could you rebase to the latest master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383888#comment-15383888
]
ASF GitHub Bot commented on FLINK-4166:
---
Github user mxm commented on the issue:
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2249#discussion_r71309594
--- Diff: docs/setup/config.md ---
@@ -272,7 +272,9 @@ For example when running Flink on YARN on an
environment with a restrictive fire
- `r
[
https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383892#comment-15383892
]
ASF GitHub Bot commented on FLINK-4166:
---
Github user StefanRRichter commented on a d
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2249#discussion_r71311352
--- Diff: docs/setup/config.md ---
@@ -272,7 +272,9 @@ For example when running Flink on YARN on an
environment with a restrictive fire
- `recovery.zoo
[
https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383903#comment-15383903
]
ASF GitHub Bot commented on FLINK-4166:
---
Github user mxm commented on a diff in the
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek resolved FLINK-4232.
-
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed in
https://github.com/apache/flink/co
[
https://issues.apache.org/jira/browse/FLINK-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383908#comment-15383908
]
ASF GitHub Bot commented on FLINK-4232:
---
Github user asfgit closed the pull request
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2249
Thanks for the review, Max! I changed the default namespace string and
rebased the the latest master.
---
If your project is set up for it, you can reply to this email and have your
reply app
[
https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384002#comment-15384002
]
ASF GitHub Bot commented on FLINK-4166:
---
Github user StefanRRichter commented on the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71322624
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
@@ -78,6 +79,9 @@
/** The containers where a TaskManag
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384005#comment-15384005
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71323898
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +374,13 @@ class JobManager(
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384014#comment-15384014
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on a dif
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71325133
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +374,13 @@ class JobManager(
currentR
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384026#comment-15384026
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384029#comment-15384029
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384030#comment-15384030
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user mxm commented on a diff in the
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2265
I was also thinking a lot about the names, because we have currently many
`Function`s in Flink. I chose `UserDefinedFunction` as the top-level function
for all user-defined functions such as `ScalarF
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71325247
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
@@ -78,6 +79,9 @@
/** The containers where a TaskManager is sta
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71325200
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +374,13 @@ class JobManager(
[
https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384031#comment-15384031
]
ASF GitHub Bot commented on FLINK-3097:
---
Github user twalthr commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384035#comment-15384035
]
ASF GitHub Bot commented on FLINK-4166:
---
Github user mxm commented on the issue:
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2249
Thank you! Merging after tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2078
Thanks for the contribution @gallenvara. I will merge it now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
[
https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384040#comment-15384040
]
ASF GitHub Bot commented on FLINK-2985:
---
Github user twalthr commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2078
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384046#comment-15384046
]
ASF GitHub Bot commented on FLINK-2985:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther resolved FLINK-2985.
-
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed in 5758c91999efcf45457e4c25d4a75b13ce13e486.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2257
I think by imposing this contract we actually introduced problems we didn't
have before. Thus, in order to remedy these problems for the upcoming release
and go back a bit in the direction of th
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384069#comment-15384069
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71327721
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -405,36 +374,13 @@ class JobManager(
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384077#comment-15384077
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384081#comment-15384081
]
Valentin Denisenkov commented on FLINK-2491:
Can you please give an ETA for th
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2257
I don't feel particularly great about breaking the contract between
JobManager and ResourceManager but it is a path we can go until we expand the
ResourceManager capabilities. The figures here would have
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384094#comment-15384094
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user mxm commented on the issue:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71331665
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
@@ -78,6 +79,9 @@
/** The containers where a TaskManag
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71331743
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
@@ -78,6 +79,9 @@
/** The containers where a TaskManag
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384104#comment-15384104
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384103#comment-15384103
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on a dif
Stephan Ewen created FLINK-4233:
---
Summary: Simplify leader election / leader session ID assignment
Key: FLINK-4233
URL: https://issues.apache.org/jira/browse/FLINK-4233
Project: Flink
Issue Typ
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2249
Travis cache seems to be corrupted. Have you run `mvn verify` from the
command-line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
[
https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384105#comment-15384105
]
ASF GitHub Bot commented on FLINK-4166:
---
Github user mxm commented on the issue:
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2182
Thanks for the contribution @unsleepy22.
I changed the code a little bit, so that we can prevent an `if(false)`
branch.
Will merge...
---
If your project is set up for it, you can reply
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71332501
--- Diff: docs/apis/cli.md ---
@@ -187,6 +187,8 @@ Action "run" compiles and runs a program.
java.net.URLClassLoader
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384109#comment-15384109
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2265
Ah ok, thats perfect! (about infix and postfix)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
[
https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384111#comment-15384111
]
ASF GitHub Bot commented on FLINK-3097:
---
Github user aljoscha commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384113#comment-15384113
]
Aljoscha Krettek commented on FLINK-2491:
-
I think we want to tackle this for the
[
https://issues.apache.org/jira/browse/FLINK-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther resolved FLINK-4130.
-
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed in dd53831aa00e8160e8db14d6de186ce8f1f82b92.
[
https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384115#comment-15384115
]
ASF GitHub Bot commented on FLINK-3097:
---
Github user wuchong commented on the issue:
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2265
Yes, I see. That's great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2257
My main concern is actually that the JM-RM interaction is not well tested.
Thus, I fear the more complex the code is the more possibility for mistakes
there are. For example, I couldn't find a t
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384133#comment-15384133
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on the i
GitHub user joshfg opened a pull request:
https://github.com/apache/flink/pull/2269
[FLINK-4190] Generalise RollingSink to work with arbitrary buckets
I've created a new bucketing package with a BucketingSink, which improves
on the existing RollingSink by enabling arbitrary bucketin
[
https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384206#comment-15384206
]
Josh Forman-Gornall commented on FLINK-4190:
Ok cool, thanks! I've just submit
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2257#discussion_r71350758
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java ---
@@ -78,6 +79,9 @@
/** The containers where a TaskManager is sta
[
https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384242#comment-15384242
]
ASF GitHub Bot commented on FLINK-4230:
---
Github user aljoscha commented on the issue
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2263
Nice pice of code! I finally understood how it works... ð
Some remarks about the code: in some places there are method names that
seem to stem from an initial implementation but don't ma
[
https://issues.apache.org/jira/browse/FLINK-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther resolved FLINK-3792.
-
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed as part of FLINK-2985.
> RowTypeInfo equality
[
https://issues.apache.org/jira/browse/FLINK-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384245#comment-15384245
]
ASF GitHub Bot commented on FLINK-4183:
---
Github user twalthr commented on the issue:
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2221
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
[
https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384250#comment-15384250
]
Aljoscha Krettek commented on FLINK-4190:
-
Did you open the PR with the correct FL
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384251#comment-15384251
]
ASF GitHub Bot commented on FLINK-4183:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384234#comment-15384234
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther resolved FLINK-4183.
-
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed in e85f787b280b63960e7f3add5aa8613b4ee23795.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2263
Thanks a lot for the review. I agree on all your points and will address
them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384268#comment-15384268
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71353752
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -451,4 +479,25 @@ public static InfoOptions parseInfoCommand(Stri
[
https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384274#comment-15384274
]
ASF GitHub Bot commented on FLINK-4230:
---
Github user aljoscha commented on the issue
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2263
Oh, and I forgot: the checking for the correct number of elements can be
moved out of the window function and into the test itself, like this:
```
JobExecutionResult result = env.execute
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71354207
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -451,4 +479,25 @@ public static InfoOptions parseInfoCommand(Stri
[
https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384252#comment-15384252
]
ASF GitHub Bot commented on FLINK-4230:
---
Github user StefanRRichter commented on the
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384276#comment-15384276
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384278#comment-15384278
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384279#comment-15384279
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384283#comment-15384283
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r71354132
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -451,4 +479,25 @@ public static InfoOptions parseInfoCommand(Stri
[
https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384249#comment-15384249
]
Aljoscha Krettek commented on FLINK-4190:
-
Did you open the PR with the correct FL
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384275#comment-15384275
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
1 - 100 of 128 matches
Mail list logo