[GitHub] flink issue #2265: [FLINK-3097] [table] Add support for custom functions in ...

2016-07-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2265 No, there is no FLIP about it. I think a discussion in JIRA or in this PR should be enough. That's why I haven't documented it yet. I was inspired by your [document](https://docs.google.com/documen

[jira] [Commented] (FLINK-3097) Add support for custom functions in Table API

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383717#comment-15383717 ] ASF GitHub Bot commented on FLINK-3097: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-4183) Move checking for StreamTableEnvironment into validation layer

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383738#comment-15383738 ] ASF GitHub Bot commented on FLINK-4183: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2221: [FLINK-4183] [table] Move checking for StreamTableEnviron...

2016-07-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2221 I will merge this later today if there are no objections... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[jira] [Created] (FLINK-4232) Flink executable does not return correct pid

2016-07-19 Thread David Moravek (JIRA)
David Moravek created FLINK-4232: Summary: Flink executable does not return correct pid Key: FLINK-4232 URL: https://issues.apache.org/jira/browse/FLINK-4232 Project: Flink Issue Type: Bug

[GitHub] flink pull request #2268: [FLINK-4232] Make sure ./bin/flink returns correct...

2016-07-19 Thread dmvk
GitHub user dmvk opened a pull request: https://github.com/apache/flink/pull/2268 [FLINK-4232] Make sure ./bin/flink returns correct pid You can merge this pull request into a Git repository by running: $ git pull https://github.com/dmvk/flink FLINK-4232 Alternatively you can

[jira] [Commented] (FLINK-4232) Flink executable does not return correct pid

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383770#comment-15383770 ] ASF GitHub Bot commented on FLINK-4232: --- GitHub user dmvk opened a pull request:

[GitHub] flink issue #1989: FLINK-3901 - Added CsvRowInputFormat

2016-07-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/1989 Hi @twalthr, any news about this? Are you going to merge this PR in the upcoming 1.1 release? If you were waiting for a feedback you have my +1 about your strategy..go ahead and convert the

[jira] [Commented] (FLINK-3901) Create a RowCsvInputFormat to use as default CSV IF in Table API

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383819#comment-15383819 ] ASF GitHub Bot commented on FLINK-3901: --- Github user fpompermaier commented on the i

[jira] [Commented] (FLINK-4223) Rearrange scaladoc and javadoc for Scala API

2016-07-19 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383846#comment-15383846 ] Maximilian Michels commented on FLINK-4223: --- Seems like a duplicate of FLINK-371

[jira] [Closed] (FLINK-4223) Rearrange scaladoc and javadoc for Scala API

2016-07-19 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels closed FLINK-4223. - Resolution: Duplicate > Rearrange scaladoc and javadoc for Scala API > ---

[GitHub] flink issue #2265: [FLINK-3097] [table] Add support for custom functions in ...

2016-07-19 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2265 Yes, you are right. I'm just a little concerned about the class name of `ScalarFunction`, haha.. In addition, Java Table API should be `table.select("hashCode(text)");` which is better I t

[jira] [Commented] (FLINK-3097) Add support for custom functions in Table API

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383858#comment-15383858 ] ASF GitHub Bot commented on FLINK-3097: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...

2016-07-19 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2109 I'll try to review this as soon as possible. Maybe @kl0u or @zentol also want to have another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383863#comment-15383863 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mxm commented on the issue:

[GitHub] flink issue #2265: [FLINK-3097] [table] Add support for custom functions in ...

2016-07-19 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2265 Yes, @wuchong's suggestion for the Java Table API seems more extensible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[jira] [Commented] (FLINK-3097) Add support for custom functions in Table API

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383869#comment-15383869 ] ASF GitHub Bot commented on FLINK-3097: --- Github user aljoscha commented on the issue

[GitHub] flink issue #2249: [FLINK-4166] [CLI] Generate different namespaces for Zook...

2016-07-19 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2249 Thanks for the update. Could you rebase to the latest master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-4166) Generate automatic different namespaces in Zookeeper for Flink applications

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383888#comment-15383888 ] ASF GitHub Bot commented on FLINK-4166: --- Github user mxm commented on the issue:

[GitHub] flink pull request #2249: [FLINK-4166] [CLI] Generate different namespaces f...

2016-07-19 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r71309594 --- Diff: docs/setup/config.md --- @@ -272,7 +272,9 @@ For example when running Flink on YARN on an environment with a restrictive fire - `r

[jira] [Commented] (FLINK-4166) Generate automatic different namespaces in Zookeeper for Flink applications

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383892#comment-15383892 ] ASF GitHub Bot commented on FLINK-4166: --- Github user StefanRRichter commented on a d

[GitHub] flink pull request #2249: [FLINK-4166] [CLI] Generate different namespaces f...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2249#discussion_r71311352 --- Diff: docs/setup/config.md --- @@ -272,7 +272,9 @@ For example when running Flink on YARN on an environment with a restrictive fire - `recovery.zoo

[jira] [Commented] (FLINK-4166) Generate automatic different namespaces in Zookeeper for Flink applications

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383903#comment-15383903 ] ASF GitHub Bot commented on FLINK-4166: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2268: [FLINK-4232] Make sure ./bin/flink returns correct...

2016-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2268 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (FLINK-4232) Flink executable does not return correct pid

2016-07-19 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-4232. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in https://github.com/apache/flink/co

[jira] [Commented] (FLINK-4232) Flink executable does not return correct pid

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383908#comment-15383908 ] ASF GitHub Bot commented on FLINK-4232: --- Github user asfgit closed the pull request

[GitHub] flink issue #2249: [FLINK-4166] [CLI] Generate different namespaces for Zook...

2016-07-19 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2249 Thanks for the review, Max! I changed the default namespace string and rebased the the latest master. --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Commented] (FLINK-4166) Generate automatic different namespaces in Zookeeper for Flink applications

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384002#comment-15384002 ] ASF GitHub Bot commented on FLINK-4166: --- Github user StefanRRichter commented on the

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71322624 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java --- @@ -78,6 +79,9 @@ /** The containers where a TaskManag

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384005#comment-15384005 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71323898 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -405,36 +374,13 @@ class JobManager(

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384014#comment-15384014 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71325133 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -405,36 +374,13 @@ class JobManager( currentR

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384026#comment-15384026 ] ASF GitHub Bot commented on FLINK-4152: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384029#comment-15384029 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384030#comment-15384030 ] ASF GitHub Bot commented on FLINK-4152: --- Github user mxm commented on a diff in the

[GitHub] flink issue #2265: [FLINK-3097] [table] Add support for custom functions in ...

2016-07-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2265 I was also thinking a lot about the names, because we have currently many `Function`s in Flink. I chose `UserDefinedFunction` as the top-level function for all user-defined functions such as `ScalarF

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71325247 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java --- @@ -78,6 +79,9 @@ /** The containers where a TaskManager is sta

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71325200 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -405,36 +374,13 @@ class JobManager(

[jira] [Commented] (FLINK-3097) Add support for custom functions in Table API

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384031#comment-15384031 ] ASF GitHub Bot commented on FLINK-3097: --- Github user twalthr commented on the issue:

[jira] [Commented] (FLINK-4166) Generate automatic different namespaces in Zookeeper for Flink applications

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384035#comment-15384035 ] ASF GitHub Bot commented on FLINK-4166: --- Github user mxm commented on the issue:

[GitHub] flink issue #2249: [FLINK-4166] [CLI] Generate different namespaces for Zook...

2016-07-19 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2249 Thank you! Merging after tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #2078: [FLINK-2985] Allow different field names for unionAll() i...

2016-07-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2078 Thanks for the contribution @gallenvara. I will merge it now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[jira] [Commented] (FLINK-2985) Allow different field names for unionAll() in Table API

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384040#comment-15384040 ] ASF GitHub Bot commented on FLINK-2985: --- Github user twalthr commented on the issue:

[GitHub] flink pull request #2078: [FLINK-2985] Allow different field names for union...

2016-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2078 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-2985) Allow different field names for unionAll() in Table API

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384046#comment-15384046 ] ASF GitHub Bot commented on FLINK-2985: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-2985) Allow different field names for unionAll() in Table API

2016-07-19 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-2985. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in 5758c91999efcf45457e4c25d4a75b13ce13e486.

[GitHub] flink issue #2257: [FLINK-4152] Allow re-registration of TMs at resource man...

2016-07-19 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2257 I think by imposing this contract we actually introduced problems we didn't have before. Thus, in order to remedy these problems for the upcoming release and go back a bit in the direction of th

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384069#comment-15384069 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71327721 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -405,36 +374,13 @@ class JobManager(

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384077#comment-15384077 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-2491) Operators are not participating in state checkpointing in some cases

2016-07-19 Thread Valentin Denisenkov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384081#comment-15384081 ] Valentin Denisenkov commented on FLINK-2491: Can you please give an ETA for th

[GitHub] flink issue #2257: [FLINK-4152] Allow re-registration of TMs at resource man...

2016-07-19 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2257 I don't feel particularly great about breaking the contract between JobManager and ResourceManager but it is a path we can go until we expand the ResourceManager capabilities. The figures here would have

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384094#comment-15384094 ] ASF GitHub Bot commented on FLINK-4152: --- Github user mxm commented on the issue:

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71331665 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java --- @@ -78,6 +79,9 @@ /** The containers where a TaskManag

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-19 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71331743 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java --- @@ -78,6 +79,9 @@ /** The containers where a TaskManag

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384104#comment-15384104 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384103#comment-15384103 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on a dif

[jira] [Created] (FLINK-4233) Simplify leader election / leader session ID assignment

2016-07-19 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4233: --- Summary: Simplify leader election / leader session ID assignment Key: FLINK-4233 URL: https://issues.apache.org/jira/browse/FLINK-4233 Project: Flink Issue Typ

[GitHub] flink issue #2249: [FLINK-4166] [CLI] Generate different namespaces for Zook...

2016-07-19 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2249 Travis cache seems to be corrupted. Have you run `mvn verify` from the command-line? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[jira] [Commented] (FLINK-4166) Generate automatic different namespaces in Zookeeper for Flink applications

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384105#comment-15384105 ] ASF GitHub Bot commented on FLINK-4166: --- Github user mxm commented on the issue:

[GitHub] flink issue #2182: [Flink-4130] CallGenerator could generate illegal code wh...

2016-07-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2182 Thanks for the contribution @unsleepy22. I changed the code a little bit, so that we can prevent an `if(false)` branch. Will merge... --- If your project is set up for it, you can reply

[GitHub] flink pull request #2182: [Flink-4130] CallGenerator could generate illegal ...

2016-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71332501 --- Diff: docs/apis/cli.md --- @@ -187,6 +187,8 @@ Action "run" compiles and runs a program. java.net.URLClassLoader

[jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384109#comment-15384109 ] ASF GitHub Bot commented on FLINK-4084: --- Github user mxm commented on a diff in the

[GitHub] flink issue #2265: [FLINK-3097] [table] Add support for custom functions in ...

2016-07-19 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2265 Ah ok, thats perfect! (about infix and postfix) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (FLINK-3097) Add support for custom functions in Table API

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384111#comment-15384111 ] ASF GitHub Bot commented on FLINK-3097: --- Github user aljoscha commented on the issue

[jira] [Commented] (FLINK-2491) Operators are not participating in state checkpointing in some cases

2016-07-19 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384113#comment-15384113 ] Aljoscha Krettek commented on FLINK-2491: - I think we want to tackle this for the

[jira] [Resolved] (FLINK-4130) CallGenerator could generate illegal code when taking no operands

2016-07-19 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4130. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in dd53831aa00e8160e8db14d6de186ce8f1f82b92.

[jira] [Commented] (FLINK-3097) Add support for custom functions in Table API

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384115#comment-15384115 ] ASF GitHub Bot commented on FLINK-3097: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2265: [FLINK-3097] [table] Add support for custom functions in ...

2016-07-19 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2265 Yes, I see. That's great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] flink issue #2257: [FLINK-4152] Allow re-registration of TMs at resource man...

2016-07-19 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2257 My main concern is actually that the JM-RM interaction is not well tested. Thus, I fear the more complex the code is the more possibility for mistakes there are. For example, I couldn't find a t

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384133#comment-15384133 ] ASF GitHub Bot commented on FLINK-4152: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #2269: [FLINK-4190] Generalise RollingSink to work with a...

2016-07-19 Thread joshfg
GitHub user joshfg opened a pull request: https://github.com/apache/flink/pull/2269 [FLINK-4190] Generalise RollingSink to work with arbitrary buckets I've created a new bucketing package with a BucketingSink, which improves on the existing RollingSink by enabling arbitrary bucketin

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-19 Thread Josh Forman-Gornall (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384206#comment-15384206 ] Josh Forman-Gornall commented on FLINK-4190: Ok cool, thanks! I've just submit

[GitHub] flink pull request #2257: [FLINK-4152] Allow re-registration of TMs at resou...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2257#discussion_r71350758 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java --- @@ -78,6 +79,9 @@ /** The containers where a TaskManager is sta

[jira] [Commented] (FLINK-4230) Session Windowing IT Case

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384242#comment-15384242 ] ASF GitHub Bot commented on FLINK-4230: --- Github user aljoscha commented on the issue

[GitHub] flink issue #2263: [FLINK-4230] [DataStreamAPI] Add Session Windowing ITCase

2016-07-19 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2263 Nice pice of code! I finally understood how it works... 😃 Some remarks about the code: in some places there are method names that seem to stem from an initial implementation but don't ma

[jira] [Resolved] (FLINK-3792) RowTypeInfo equality should not depend on field names

2016-07-19 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-3792. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed as part of FLINK-2985. > RowTypeInfo equality

[jira] [Commented] (FLINK-4183) Move checking for StreamTableEnvironment into validation layer

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384245#comment-15384245 ] ASF GitHub Bot commented on FLINK-4183: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2221: [FLINK-4183] [table] Move checking for StreamTableEnviron...

2016-07-19 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2221 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-19 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384250#comment-15384250 ] Aljoscha Krettek commented on FLINK-4190: - Did you open the PR with the correct FL

[GitHub] flink pull request #2221: [FLINK-4183] [table] Move checking for StreamTable...

2016-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4183) Move checking for StreamTableEnvironment into validation layer

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384251#comment-15384251 ] ASF GitHub Bot commented on FLINK-4183: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-4152) TaskManager registration exponential backoff doesn't work

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384234#comment-15384234 ] ASF GitHub Bot commented on FLINK-4152: --- Github user mxm commented on a diff in the

[jira] [Resolved] (FLINK-4183) Move checking for StreamTableEnvironment into validation layer

2016-07-19 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4183. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in e85f787b280b63960e7f3add5aa8613b4ee23795.

[GitHub] flink issue #2263: [FLINK-4230] [DataStreamAPI] Add Session Windowing ITCase

2016-07-19 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2263 Thanks a lot for the review. I agree on all your points and will address them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384268#comment-15384268 ] ASF GitHub Bot commented on FLINK-4084: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71353752 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -451,4 +479,25 @@ public static InfoOptions parseInfoCommand(Stri

[jira] [Commented] (FLINK-4230) Session Windowing IT Case

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384274#comment-15384274 ] ASF GitHub Bot commented on FLINK-4230: --- Github user aljoscha commented on the issue

[GitHub] flink issue #2263: [FLINK-4230] [DataStreamAPI] Add Session Windowing ITCase

2016-07-19 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2263 Oh, and I forgot: the checking for the correct number of elements can be moved out of the window function and into the test itself, like this: ``` JobExecutionResult result = env.execute

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71354207 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -451,4 +479,25 @@ public static InfoOptions parseInfoCommand(Stri

[jira] [Commented] (FLINK-4230) Session Windowing IT Case

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384252#comment-15384252 ] ASF GitHub Bot commented on FLINK-4230: --- Github user StefanRRichter commented on the

[jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384276#comment-15384276 ] ASF GitHub Bot commented on FLINK-4084: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384278#comment-15384278 ] ASF GitHub Bot commented on FLINK-4084: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384279#comment-15384279 ] ASF GitHub Bot commented on FLINK-4084: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384283#comment-15384283 ] ASF GitHub Bot commented on FLINK-4084: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...

2016-07-19 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2149#discussion_r71354132 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -451,4 +479,25 @@ public static InfoOptions parseInfoCommand(Stri

[jira] [Commented] (FLINK-4190) Generalise RollingSink to work with arbitrary buckets

2016-07-19 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384249#comment-15384249 ] Aljoscha Krettek commented on FLINK-4190: - Did you open the PR with the correct FL

[jira] [Commented] (FLINK-4084) Add configDir parameter to CliFrontend and flink shell script

2016-07-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384275#comment-15384275 ] ASF GitHub Bot commented on FLINK-4084: --- Github user mxm commented on a diff in the

  1   2   >