[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-28 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2169#discussion_r68706865 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -236,6 +236,32 @@ case class Aggregate(

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352499#comment-15352499 ] ASF GitHub Bot commented on FLINK-3943: --- Github user wuchong commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-28 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68711841 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -155

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352540#comment-15352540 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2152: [FLINK-3920] Distributed Linear Algebra: block-bas...

2016-06-28 Thread chobeat
Github user chobeat commented on a diff in the pull request: https://github.com/apache/flink/pull/2152#discussion_r68713373 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala --- @@ -0,0 +1,287 @@ +/* + * Licensed to th

[jira] [Commented] (FLINK-3920) Distributed Linear Algebra: block-based matrix

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352549#comment-15352549 ] ASF GitHub Bot commented on FLINK-3920: --- Github user chobeat commented on a diff in

[GitHub] flink pull request #2152: [FLINK-3920] Distributed Linear Algebra: block-bas...

2016-06-28 Thread chobeat
Github user chobeat commented on a diff in the pull request: https://github.com/apache/flink/pull/2152#discussion_r68715364 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/BlockMatrix.scala --- @@ -0,0 +1,287 @@ +/* + * Licensed to th

[jira] [Commented] (FLINK-3920) Distributed Linear Algebra: block-based matrix

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352572#comment-15352572 ] ASF GitHub Bot commented on FLINK-3920: --- Github user chobeat commented on a diff in

[jira] [Commented] (FLINK-4113) Always copy first value in ChainedAllReduceDriver

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352593#comment-15352593 ] ASF GitHub Bot commented on FLINK-4113: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2156: [FLINK-4113] [runtime] Always copy first value in ...

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2156#discussion_r68718332 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/chaining/ChainedAllReduceDriver.java --- @@ -89,7 +89,7 @@ public void collect(

[GitHub] flink issue #2156: [FLINK-4113] [runtime] Always copy first value in Chained...

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2156 @greghogan the tests looks good. Thanks for your work :-) The failing test cases are unrelated. Will merge this PR. --- If your project is set up for it, you can reply to this email and have yo

[jira] [Commented] (FLINK-4113) Always copy first value in ChainedAllReduceDriver

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352598#comment-15352598 ] ASF GitHub Bot commented on FLINK-4113: --- Github user tillrohrmann commented on the i

[GitHub] flink pull request #2156: [FLINK-4113] [runtime] Always copy first value in ...

2016-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4113) Always copy first value in ChainedAllReduceDriver

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352606#comment-15352606 ] ASF GitHub Bot commented on FLINK-4113: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-4113) Always copy first value in ChainedAllReduceDriver

2016-06-28 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-4113. -- Resolution: Fixed Fixed via a6feea32a328f3f3216960298d6c8a5d3f30a234 > Always copy first value

[GitHub] flink pull request #2171: FLINK-3319 Added the or function to the CEP patter...

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2171#discussion_r68719946 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java --- @@ -424,87 +423,71 @@ public Integer select(Map pattern) throw

[jira] [Commented] (FLINK-3319) Add or operator to CEP's pattern API

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352616#comment-15352616 ] ASF GitHub Bot commented on FLINK-3319: --- Github user tillrohrmann commented on a dif

[GitHub] flink issue #2171: FLINK-3319 Added the or function to the CEP pattern

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2171 Thanks for cleaning up the PR @thormanrd. Could we also try to get rid of the merge commits? We actually always rebase in the Flink community and never merge branches. Furthermore, it s

[GitHub] flink pull request #2166: [FLINK-4099] Fix CliFrontendYarnAddressConfigurati...

2016-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (FLINK-4099) CliFrontendYarnAddressConfigurationTest fails

2016-06-28 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-4099. --- Resolution: Fixed Fix Version/s: 1.1.0 Resolved in http://git-wip-us.apache.org/repos/a

[jira] [Commented] (FLINK-3319) Add or operator to CEP's pattern API

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352621#comment-15352621 ] ASF GitHub Bot commented on FLINK-3319: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-4099) CliFrontendYarnAddressConfigurationTest fails

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352620#comment-15352620 ] ASF GitHub Bot commented on FLINK-4099: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-28 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68722233 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352638#comment-15352638 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-3710) ScalaDocs for org.apache.flink.streaming.scala are missing from the web site

2016-06-28 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352650#comment-15352650 ] Aljoscha Krettek commented on FLINK-3710: - It might be solvable by fiddling with t

[jira] [Assigned] (FLINK-4110) Provide testing skeleton in quickstarts

2016-06-28 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-4110: - Assignee: Robert Metzger > Provide testing skeleton in quickstarts >

[jira] [Updated] (FLINK-4114) Need a way to manage multiple named, long-lived jobs on a single YARN cluster in an automated manner

2016-06-28 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-4114: -- Component/s: YARN Client Issue Type: Improvement (was: Bug) > Need a way to manage multipl

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-28 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68726797 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java ---

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352676#comment-15352676 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68726906 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -149,6 +154,16 @@ class JobManager( var

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352678#comment-15352678 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352679#comment-15352679 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68726957 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -204,6 +219,12 @@ class JobManager( log.

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-28 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68727843 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -86,

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352692#comment-15352692 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68728510 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -2325,55 +2326,65 @@ object TaskManager {

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68728603 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1727,6 +1764,160 @@ class JobManager( // Sh

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352695#comment-15352695 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352697#comment-15352697 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68729084 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1082,6 +1110,13 @@ class JobManager(

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352704#comment-15352704 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-28 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68729145 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -155

[GitHub] flink issue #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2146 Good fixes @zentol. I had some minor comments which we should address before merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352705#comment-15352705 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352710#comment-15352710 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2131: [FLINK-3231][streaming-connectors] FlinkKinesisConsumer r...

2016-06-28 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2131 I'm done with my first full review. I'll test the code tomorrow. Let me know if you need help addressing my comments. --- If your project is set up for it, you can reply to this email and have y

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352712#comment-15352712 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on the issue

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68729523 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -30,6 +30,7 @@ import org.slf4j.Logger; import org.slf4j

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352715#comment-15352715 ] ASF GitHub Bot commented on FLINK-1550: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352714#comment-15352714 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68729588 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1727,6 +1764,160 @@ class JobManager( // Shutdown

[jira] [Assigned] (FLINK-4085) Set Kinesis Consumer Agent to Flink

2016-06-28 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-4085: - Assignee: Robert Metzger > Set Kinesis Consumer Agent to Flink >

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-28 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68730716 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[GitHub] flink pull request #2150: [FLINK-3580] [table] Reintroduce Date/Time and imp...

2016-06-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2150#discussion_r68730731 --- Diff: docs/apis/table.md --- @@ -775,6 +775,8 @@ column names and function names follow Java identifier syntax. Expressions speci If working w

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352733#comment-15352733 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-3580) Reintroduce Date/Time and implement scalar functions for it

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352734#comment-15352734 ] ASF GitHub Bot commented on FLINK-3580: --- Github user aljoscha commented on a diff in

[GitHub] flink issue #2168: [FLINK-3964] add hint to job submission timeout exception...

2016-06-28 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2168 Thanks for the feedback. Savepoint related errors should be forwarded to the client independently of timeouts (except maybe when the savepoint takes too long). So that should be fixed in a follow-up. -

[jira] [Commented] (FLINK-3964) Job submission times out with recursive.file.enumeration

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352735#comment-15352735 ] ASF GitHub Bot commented on FLINK-3964: --- Github user mxm commented on the issue:

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352737#comment-15352737 ] ASF GitHub Bot commented on FLINK-4062: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731283 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-28 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68731349 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -155

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352738#comment-15352738 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731488 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68731503 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1082,6 +1110,13 @@ class JobManager( lo

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352740#comment-15352740 ] ASF GitHub Bot commented on FLINK-1550: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352739#comment-15352739 ] ASF GitHub Bot commented on FLINK-4062: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731626 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352743#comment-15352743 ] ASF GitHub Bot commented on FLINK-4062: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731685 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352744#comment-15352744 ] ASF GitHub Bot commented on FLINK-4062: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68731943 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352750#comment-15352750 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352749#comment-15352749 ] ASF GitHub Bot commented on FLINK-4062: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68732049 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1727,6 +1764,160 @@ class JobManager( // Sh

[GitHub] flink issue #2131: [FLINK-3231][streaming-connectors] FlinkKinesisConsumer r...

2016-06-28 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2131 @rmetzger Thanks a lot for your helpful review :) I should be able to address your comments before tomorrow so we can start testing it. --- If your project is set up for it, you can reply to th

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352751#comment-15352751 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on the issue

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732224 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732293 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352755#comment-15352755 ] ASF GitHub Bot commented on FLINK-4062: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732268 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352754#comment-15352754 ] ASF GitHub Bot commented on FLINK-4062: --- Github user aljoscha commented on a diff in

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352756#comment-15352756 ] ASF GitHub Bot commented on FLINK-4062: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732425 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732411 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352757#comment-15352757 ] ASF GitHub Bot commented on FLINK-4062: --- Github user kl0u commented on a diff in the

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352758#comment-15352758 ] ASF GitHub Bot commented on FLINK-4062: --- Github user aljoscha commented on a diff in

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352763#comment-15352763 ] ASF GitHub Bot commented on FLINK-4062: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732802 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68732963 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1727,6 +1764,160 @@ class JobManager( // Shutdown

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352764#comment-15352764 ] ASF GitHub Bot commented on FLINK-4062: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68732942 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352765#comment-15352765 ] ASF GitHub Bot commented on FLINK-1550: --- Github user zentol commented on a diff in t

[GitHub] flink issue #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2146 I just tried the code out and run into the problem of a job metric group being null: ``` java.lang.NullPointerException at org.apache.flink.util.Preconditions.checkNotNull(P

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352767#comment-15352767 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352769#comment-15352769 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-28 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68733201 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java ---

[GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2146#discussion_r68733223 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -1082,6 +1110,13 @@ class JobManager(

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352770#comment-15352770 ] ASF GitHub Bot commented on FLINK-1550: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2154: [FLINK-4062] Update Windowing Documentation

2016-06-28 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2154#discussion_r68733572 --- Diff: docs/apis/streaming/windows.md --- @@ -24,1023 +24,593 @@ specific language governing permissions and limitations under the License. -->

[jira] [Commented] (FLINK-4062) Update Windowing Documentation

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352775#comment-15352775 ] ASF GitHub Bot commented on FLINK-4062: --- Github user kl0u commented on a diff in the

  1   2   3   >