[
https://issues.apache.org/jira/browse/FLINK-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352621#comment-15352621
]
ASF GitHub Bot commented on FLINK-3319:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2171
Thanks for cleaning up the PR @thormanrd.
Could we also try to get rid of the merge commits? We actually always
rebase in the Flink community and never merge branches. Furthermore, it seems
as if you've transformed the `testTimeoutHandling` into another test case. This
should be corrected.
What I meant with the `OrFilterFunctionTest` is an explicit test of the
`OrFilterFunction` and not an implicit test where it is embedded into a CEP
program.
> Add or operator to CEP's pattern API
> ------------------------------------
>
> Key: FLINK-3319
> URL: https://issues.apache.org/jira/browse/FLINK-3319
> Project: Flink
> Issue Type: Improvement
> Components: CEP
> Affects Versions: 1.0.0
> Reporter: Till Rohrmann
> Assignee: Robert Thorman
> Priority: Minor
>
> Adding an {{or}} operator to CEP's pattern API would be beneficial. This
> would considerably extend the set of supported patterns. The {{or}} operator
> lets you define multiple succeeding pattern states for the next stage.
> {code}
> Pattern.begin("start").next("middle1").where(...).or("middle2").where(...)
> {code}
> In order to implement the {{or}} operator, one has to extend the {{Pattern}}
> class. Furthermore, the {{NFACompiler}} has to be extended to generate two
> resulting pattern states in case of an {{or}} operator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
