[jira] [Commented] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-27 Thread Stefano Baghino (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350970#comment-15350970 ] Stefano Baghino commented on FLINK-3675: The `lib` folder includes important JARs,

[jira] [Comment Edited] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-27 Thread Stefano Baghino (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350970#comment-15350970 ] Stefano Baghino edited comment on FLINK-3675 at 6/27/16 1:17 PM: ---

[GitHub] flink issue #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics

2016-06-27 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2146 @tillrohrmann I've addressed your comments and rebased the PR. You should now be able to try it out locally. --- If your project is set up for it, you can reply to this email and have your reply appe

[jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350973#comment-15350973 ] ASF GitHub Bot commented on FLINK-1550: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-27 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350974#comment-15350974 ] Maximilian Michels commented on FLINK-3675: --- So that would be option 2 :) Actual

[jira] [Commented] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-27 Thread Stefano Baghino (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350992#comment-15350992 ] Stefano Baghino commented on FLINK-3675: I must have misread something, I thought

[GitHub] flink issue #2166: [FLINK-4099] Fix CliFrontendYarnAddressConfigurationTest ...

2016-06-27 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2166 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4099) CliFrontendYarnAddressConfigurationTest fails

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351001#comment-15351001 ] ASF GitHub Bot commented on FLINK-4099: --- Github user mxm commented on the issue:

[GitHub] flink pull request #2109: [FLINK-3677] FileInputFormat: Allow to specify inc...

2016-06-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2109#discussion_r68578183 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java --- @@ -314,41 +297,101 @@ public void testIgnoredUnderscoreFiles()

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351010#comment-15351010 ] ASF GitHub Bot commented on FLINK-3677: --- Github user zentol commented on a diff in t

[GitHub] flink issue #2166: [FLINK-4099] Fix CliFrontendYarnAddressConfigurationTest ...

2016-06-27 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2166 Thank you for the review. I'll wait until travis is passing and then merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-27 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351013#comment-15351013 ] Maximilian Michels commented on FLINK-3675: --- Woops. Not enough coffee today ;) Y

[jira] [Commented] (FLINK-4099) CliFrontendYarnAddressConfigurationTest fails

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351015#comment-15351015 ] ASF GitHub Bot commented on FLINK-4099: --- Github user rmetzger commented on the issue

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-27 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68578735 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java ---

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351030#comment-15351030 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2083: [FLINK-3713] [clients, runtime] Use user code clas...

2016-06-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2083#discussion_r68579929 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -790,39 +767,95 @@ else if (result instanceof TriggerSavepointFailu

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351027#comment-15351027 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351039#comment-15351039 ] ASF GitHub Bot commented on FLINK-3713: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2083: [FLINK-3713] [clients, runtime] Use user code clas...

2016-06-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2083#discussion_r68580226 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -790,39 +767,95 @@ else if (result instanceof TriggerSavepointFailu

[jira] [Comment Edited] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-27 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350953#comment-15350953 ] Maximilian Michels edited comment on FLINK-3675 at 6/27/16 1:41 PM:

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-27 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68579220 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351043#comment-15351043 ] ASF GitHub Bot commented on FLINK-3713: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2083: [FLINK-3713] [clients, runtime] Use user code clas...

2016-06-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2083#discussion_r68580451 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -790,39 +767,95 @@ else if (result instanceof TriggerSavepointFailu

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351046#comment-15351046 ] ASF GitHub Bot commented on FLINK-3713: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2134: [FLINK-4093] Expose metric interfaces

2016-06-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request #2112: [FLINK-3951] Add histogram metric type

2016-06-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4093) Expose metric interfaces

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351052#comment-15351052 ] ASF GitHub Bot commented on FLINK-4093: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-3951) Add Histogram Metric Type

2016-06-27 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-3951. --- Resolution: Fixed Implemented in ee3c7a88bb74232e4884899699aaa08ae2b6e038 > Add Histogram Met

[jira] [Commented] (FLINK-3675) YARN ship folder incosistent behavior

2016-06-27 Thread Stefano Baghino (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351055#comment-15351055 ] Stefano Baghino commented on FLINK-3675: Of course, thanks for clarifying this to

[jira] [Commented] (FLINK-3951) Add Histogram Metric Type

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351053#comment-15351053 ] ASF GitHub Bot commented on FLINK-3951: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-4093) Expose metric interfaces

2016-06-27 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-4093. --- Resolution: Fixed Implemented in d43bf8d9b3085d1341bfca61e05c2a77e5426226 > Expose metric int

[jira] [Commented] (FLINK-4053) Return value from Connection should be checked against null

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351056#comment-15351056 ] ASF GitHub Bot commented on FLINK-4053: --- Github user zentol commented on a diff in t

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351062#comment-15351062 ] ASF GitHub Bot commented on FLINK-3713: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2083: [FLINK-3713] [clients, runtime] Use user code clas...

2016-06-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2083#discussion_r68581644 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -790,39 +767,95 @@ else if (result instanceof TriggerSavepointFailu

[GitHub] flink pull request #2128: [FLINK-4053] Return value from Connection should b...

2016-06-27 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2128#discussion_r68580911 --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java --- @@ -76,6 +76,9 @@

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-27 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68582164 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351069#comment-15351069 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68582306 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java ---

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351071#comment-15351071 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-27 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68582684 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyInterface.java ---

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-27 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68582645 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardDiscoverer.java ---

[GitHub] flink issue #2083: [FLINK-3713] [clients, runtime] Use user code class loade...

2016-06-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2083 Good work @uce :-) I agree that it currently it is a bit clumsy to discard savepoints of jobs which are no longer running. From the user perspective it should be as easy as possible.

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351075#comment-15351075 ] ASF GitHub Bot commented on FLINK-3713: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351077#comment-15351077 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351076#comment-15351076 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68583275 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java ---

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351089#comment-15351089 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[GitHub] flink issue #2131: [FLINK-3231][streaming-connectors] FlinkKinesisConsumer r...

2016-06-27 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2131 @tzulitai: I'm still not done with the review. I hope I can get it done in the next two hours. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351093#comment-15351093 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on the issue

[GitHub] flink issue #2128: [FLINK-4053] Return value from Connection should be check...

2016-06-27 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2128 I tihnk this looks good. One remark for future contributions though: I think some of your tests are too specific. These include `openCallDeclaresQueue`, `throwExceptionIfChannelIsNull` a

[jira] [Commented] (FLINK-4053) Return value from Connection should be checked against null

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351104#comment-15351104 ] ASF GitHub Bot commented on FLINK-4053: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351101#comment-15351101 ] ASF GitHub Bot commented on FLINK-3231: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2155: [FLINK-3319] Added Or function for where clause in CEP Pa...

2016-06-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2155 Thank you very much for your contribution @thormanrd. The CEP changes look really good :-) The only thing which we could improve is to add a unit test for the `OrFilterFunction`.

[jira] [Commented] (FLINK-3319) Add or operator to CEP's pattern API

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351108#comment-15351108 ] ASF GitHub Bot commented on FLINK-3319: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2131: [FLINK-3231][streaming-connectors] FlinkKinesisConsumer r...

2016-06-27 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2131 @rmetzger No problem, thank you! I'll reply to your comments after you finish reviewing :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351157#comment-15351157 ] ASF GitHub Bot commented on FLINK-3713: --- Github user uce commented on a diff in the

[GitHub] flink pull request #2083: [FLINK-3713] [clients, runtime] Use user code clas...

2016-06-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2083#discussion_r68587921 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java --- @@ -305,6 +307,11 @@ public static void printHelpForSavepoint() {

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351158#comment-15351158 ] Greg Hogan commented on FLINK-1707: --- >From the "A Binary Variable Model for Affinity Pro

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351161#comment-15351161 ] ASF GitHub Bot commented on FLINK-3713: --- Github user uce commented on a diff in the

[GitHub] flink pull request #2083: [FLINK-3713] [clients, runtime] Use user code clas...

2016-06-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2083#discussion_r68588625 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -790,39 +767,95 @@ else if (result instanceof TriggerSavepointFailure) {

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351166#comment-15351166 ] ASF GitHub Bot commented on FLINK-3713: --- Github user uce commented on a diff in the

[GitHub] flink pull request #2083: [FLINK-3713] [clients, runtime] Use user code clas...

2016-06-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2083#discussion_r68588080 --- Diff: docs/apis/cli.md --- @@ -279,13 +289,27 @@ guarantees for a stop request. Action "savepoint" triggers savepoints for a running job or disposes

[GitHub] flink pull request #2083: [FLINK-3713] [clients, runtime] Use user code clas...

2016-06-27 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2083#discussion_r68590084 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -790,39 +767,95 @@ else if (result instanceof TriggerSavepointFailure) {

[GitHub] flink pull request #2158: [FLINK-4116] Metrics documentation

2016-06-27 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2158#discussion_r68590134 --- Diff: docs/apis/common/index.md --- @@ -1350,3 +1350,211 @@ You may specify program arguments before the job is executed. The plan visualiza the

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351180#comment-15351180 ] ASF GitHub Bot commented on FLINK-3713: --- Github user uce commented on a diff in the

[GitHub] flink issue #2083: [FLINK-3713] [clients, runtime] Use user code class loade...

2016-06-27 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2083 Thanks for review. I will propagate the errors, make the job ID/JAR arguments optional, and try to simplify parts of the CLI as you suggested. Regarding including the RocksDB jar in dist, I think

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351186#comment-15351186 ] ASF GitHub Bot commented on FLINK-3713: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-4116) Document metrics

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351181#comment-15351181 ] ASF GitHub Bot commented on FLINK-4116: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2110: [FLINK-3974] Fix object reuse with multi-chaining

2016-06-27 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/2110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[jira] [Commented] (FLINK-3974) enableObjectReuse fails when an operator chains to multiple downstream operators

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351196#comment-15351196 ] ASF GitHub Bot commented on FLINK-3974: --- Github user aljoscha closed the pull reques

[jira] [Resolved] (FLINK-3974) enableObjectReuse fails when an operator chains to multiple downstream operators

2016-06-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-3974. - Resolution: Fixed Fix Version/s: 1.1.0 Fixed in https://github.com/apache/flink/co

[jira] [Assigned] (FLINK-3974) enableObjectReuse fails when an operator chains to multiple downstream operators

2016-06-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-3974: --- Assignee: Aljoscha Krettek > enableObjectReuse fails when an operator chains to multi

[GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...

2016-06-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2131#discussion_r68594061 --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java --- @@ -86,

[jira] [Commented] (FLINK-3231) Handle Kinesis-side resharding in Kinesis streaming consumer

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351210#comment-15351210 ] ASF GitHub Bot commented on FLINK-3231: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-1707) Add an Affinity Propagation Library Method

2016-06-27 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351211#comment-15351211 ] Josep Rubió commented on FLINK-1707: Agree, I put this same statement in the design do

[GitHub] flink issue #2156: [FLINK-4113] [runtime] Always copy first value in Chained...

2016-06-27 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2156 @tillrohrmann just added a test for `ChainedAllReduceDriver`. I didn't see a way to build a lightweight test for chained drivers as we do with the unchained drivers. --- If your project is set up

[jira] [Commented] (FLINK-4113) Always copy first value in ChainedAllReduceDriver

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351395#comment-15351395 ] ASF GitHub Bot commented on FLINK-4113: --- Github user greghogan commented on the issu

[jira] [Updated] (FLINK-4096) Nested FileOutputStream is not closed in JarFileCreator

2016-06-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-4096: -- Description: {code} final JarOutputStream jos = new JarOutputStream(new FileOutputStream(this.outputFile),

[jira] [Commented] (FLINK-3297) Streaming connector for ZeroMQ

2016-06-27 Thread Omar Alvarez (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351474#comment-15351474 ] Omar Alvarez commented on FLINK-3297: - Done! > Streaming connector for ZeroMQ >

[jira] [Commented] (FLINK-3297) Streaming connector for ZeroMQ

2016-06-27 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351612#comment-15351612 ] Robert Metzger commented on FLINK-3297: --- Perfect, thanks a lot! > Streaming connect

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351651#comment-15351651 ] ASF GitHub Bot commented on FLINK-3477: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-06-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r68640552 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/typeutils/SameTypePairComparator.java --- @@ -0,0 +1,44 @@ +/* + * Licensed to the A

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351664#comment-15351664 ] ASF GitHub Bot commented on FLINK-3477: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-06-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r68641370 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/ReduceNode.java --- @@ -45,10 +46,28 @@ public ReduceNode(ReduceOperatorBase operator

[jira] [Commented] (FLINK-3319) Add or operator to CEP's pattern API

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351673#comment-15351673 ] ASF GitHub Bot commented on FLINK-3319: --- Github user thormanrd commented on the issu

[GitHub] flink issue #2155: [FLINK-3319] Added Or function for where clause in CEP Pa...

2016-06-27 Thread thormanrd
Github user thormanrd commented on the issue: https://github.com/apache/flink/pull/2155 Thanks tillrohrmann. I put the test case in PatternTest.java as I didn't think it warranted a separate class. See public void testPatternWithOrFilter() in that class file. I'll keep work

[jira] [Commented] (FLINK-4110) Provide testing skeleton in quickstarts

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351675#comment-15351675 ] ASF GitHub Bot commented on FLINK-4110: --- Github user jgrier commented on the issue:

[GitHub] flink issue #2153: [FLINK-4110] Add testing skeleton to quickstart

2016-06-27 Thread jgrier
Github user jgrier commented on the issue: https://github.com/apache/flink/pull/2153 What I would like to see here is that the tests in the quickstart actually test the code from the job in the quickstart. For example if the job in the quickstart is WordCount it would be nice to show

[GitHub] flink pull request #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-27 Thread mushketyk
GitHub user mushketyk opened a pull request: https://github.com/apache/flink/pull/2169 [FLINK-3943] Add support for EXCEPT operator Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your change

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351676#comment-15351676 ] ASF GitHub Bot commented on FLINK-3943: --- GitHub user mushketyk opened a pull request

[GitHub] flink issue #2169: [FLINK-3943] Add support for EXCEPT operator

2016-06-27 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2169 Renamed UnionITCase to SetOperationsITCase as suggested here: https://github.com/apache/flink/pull/2159 --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-3943) Add support for EXCEPT (set minus)

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351688#comment-15351688 ] ASF GitHub Bot commented on FLINK-3943: --- Github user mushketyk commented on the issu

[GitHub] flink pull request #2170: Merge pull request #1 from apache/master

2016-06-27 Thread thormanrd
GitHub user thormanrd opened a pull request: https://github.com/apache/flink/pull/2170 Merge pull request #1 from apache/master Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes ta

[GitHub] flink issue #1813: [FLINK-3034] Redis Sink Connector

2016-06-27 Thread mjsax
Github user mjsax commented on the issue: https://github.com/apache/flink/pull/1813 My two cents: 1) seems to got sorted out (thx @tzulitai for the input!) 2) I personally do not care too much about the name conflict. Reusing the same class for sink and source sounds reasonable

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351701#comment-15351701 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on the issue:

[GitHub] flink pull request #2170: Merge pull request #1 from apache/master

2016-06-27 Thread thormanrd
Github user thormanrd closed the pull request at: https://github.com/apache/flink/pull/2170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Commented] (FLINK-3477) Add hash-based combine strategy for ReduceFunction

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351713#comment-15351713 ] ASF GitHub Bot commented on FLINK-3477: --- Github user greghogan commented on a diff i

[GitHub] flink pull request #1517: [FLINK-3477] [runtime] Add hash-based combine stra...

2016-06-27 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/1517#discussion_r68646048 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java --- @@ -1480,28 +1480,17 @@ public static int getInitia

[jira] [Commented] (FLINK-4120) Lightweight fault tolerance through recomputing lost state

2016-06-27 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351739#comment-15351739 ] Dénes Vadász commented on FLINK-4120: - Whether the state is re-computed or restored fr

[jira] [Comment Edited] (FLINK-4120) Lightweight fault tolerance through recomputing lost state

2016-06-27 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351739#comment-15351739 ] Dénes Vadász edited comment on FLINK-4120 at 6/27/16 8:23 PM: --

<    1   2   3   4   >