[ 
https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351010#comment-15351010
 ] 

ASF GitHub Bot commented on FLINK-3677:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2109#discussion_r68578183
  
    --- Diff: 
flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java
 ---
    @@ -314,41 +297,101 @@ public void testIgnoredUnderscoreFiles() {
        }
     
        @Test
    +   public void testExcludeFiles() {
    +           try {
    +                   final String contents = "CONTENTS";
    +
    +                   // create some accepted, some ignored files
    +
    +                   File f = createTempDirectory();
    +
    +                   File child1 = new File(f, "dataFile1.txt");
    +                   File child2 = new File(f, "another_file.bin");
    +
    +                   File[] files = { child1, child2 };
    +
    +                   createTempFiles(contents.getBytes(), files);
    +
    +                   // test that only the valid files are accepted
    +
    +                   Configuration configuration = new Configuration();
    +                   configuration.setString("fs.input.include", "**");
    +                   configuration.setString("fs.input.exclude", 
"**/another_file.bin");
    --- End diff --
    
    these keys no longer have to be set


> FileInputFormat: Allow to specify include/exclude file name patterns
> --------------------------------------------------------------------
>
>                 Key: FLINK-3677
>                 URL: https://issues.apache.org/jira/browse/FLINK-3677
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Maximilian Michels
>            Assignee: Ivan Mushketyk
>            Priority: Minor
>              Labels: starter
>
> It would be nice to be able to specify a regular expression to filter files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to