[GitHub] flink pull request: [Discuss] Simplify SplittableIterator interfac...

2015-01-26 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/338 [Discuss] Simplify SplittableIterator interface While working on something, I found the SplittableIterator interface unnecessary complicated. Let me know if you agree to merge this simplificatio

[GitHub] flink pull request: [FLINK-1433] Add HADOOP_CLASSPATH to start scr...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/337#issuecomment-71429315 It depends on what the user does with the `HADOOP_CLASSPATH`. In my understanding, it is meant as a variable for adding 3rd party jar files to Hadoop. The jar files of

[jira] [Commented] (FLINK-1433) Add HADOOP_CLASSPATH to start scripts

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291582#comment-14291582 ] ASF GitHub Bot commented on FLINK-1433: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71432009 I've completely changed the mechanism of setting a custom file name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291603#comment-14291603 ] ASF GitHub Bot commented on FLINK-1389: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71433679 Hmmm, using the String pattern seems to be much more comfortable for users, no? If a user wants to have the data written out with some kind of filename pattern, s

[jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291612#comment-14291612 ] ASF GitHub Bot commented on FLINK-1389: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71434721 The user who requested this feature actually asked for a custom method to overwrite. There is one more important use-case for a custom method: If users want to h

[jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291617#comment-14291617 ] ASF GitHub Bot commented on FLINK-1389: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...

2015-01-26 Thread rmetzger
Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (FLINK-1295) Add option to Flink client to start a YARN session per job

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291620#comment-14291620 ] ASF GitHub Bot commented on FLINK-1295: --- Github user rmetzger closed the pull reques

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71435854 Well, you would have saved everybody's time of you had made this requirements clear from the beginning. Besides your first two versions didn't comply with these new requir

[jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291622#comment-14291622 ] ASF GitHub Bot commented on FLINK-1389: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-01-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-71436404 I will have to rework this now that the support for registering Types and Serializers at Kryo was merged. The POJO subclass with tagging is slower because we do a

[GitHub] flink pull request: Add support for Subclasses, Interfaces, Abstra...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/236#issuecomment-71436626 @aljoscha Have a look at #316 where I took this PR, rebased it, and fixed some problems with Pojo types. --- If your project is set up for it, you can reply to this emai

[jira] [Commented] (FLINK-1234) Make Hadoop2 profile default

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291628#comment-14291628 ] ASF GitHub Bot commented on FLINK-1234: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-1234] Update documentation configuratio...

2015-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-1419) DistributedCache doesn't preserver files for subsequent operations

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291639#comment-14291639 ] ASF GitHub Bot commented on FLINK-1419: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request: [FLINK-1419] [runtime] DC properly synchronize...

2015-01-26 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/339 [FLINK-1419] [runtime] DC properly synchronized Addresses the issue of files not being preserved in subsequent operations. You can merge this pull request into a Git repository by running: $ git

[GitHub] flink pull request: [FLINK-1425] [streaming] Add scheduling of all...

2015-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (FLINK-1425) Turn lazy operator execution off for streaming programs

2015-01-26 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi resolved FLINK-1425. Resolution: Fixed Fixed in ad31f61. > Turn lazy operator execution off for streaming programs > ---

[jira] [Commented] (FLINK-1425) Turn lazy operator execution off for streaming programs

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291641#comment-14291641 ] ASF GitHub Bot commented on FLINK-1425: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71439040 You are right, I should have made the requirements clear in the beginning. I actually had a discussion with the user which approach is the best. I took the view that a

[jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291644#comment-14291644 ] ASF GitHub Bot commented on FLINK-1389: --- Github user rmetzger commented on the pull

[jira] [Updated] (FLINK-1392) Serializing Protobuf - issue 1

2015-01-26 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1392: -- Issue Type: Sub-task (was: Bug) Parent: FLINK-1417 > Serializing Protobuf - issue 1 > -

[jira] [Updated] (FLINK-1395) Add Jodatime support to Kryo

2015-01-26 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1395: -- Issue Type: Sub-task (was: Bug) Parent: FLINK-1417 > Add Jodatime support to Kryo > ---

[jira] [Updated] (FLINK-1391) Kryo fails to properly serialize avro collection types

2015-01-26 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1391: -- Issue Type: Sub-task (was: Improvement) Parent: FLINK-1417 > Kryo fails to properly ser

[jira] [Assigned] (FLINK-1395) Add Jodatime support to Kryo

2015-01-26 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-1395: - Assignee: Robert Metzger (was: Aljoscha Krettek) > Add Jodatime support to Kryo > --

[jira] [Commented] (FLINK-1395) Add Jodatime support to Kryo

2015-01-26 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291653#comment-14291653 ] Robert Metzger commented on FLINK-1395: --- [~aljoscha] I'm going to assign the issue t

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/301#issuecomment-71440329 No worries ;-) I understand that discussing such a "trivial" feature feels like a waste of time. Unfortunately these are the features that are easy to comment on for "ever

[jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291656#comment-14291656 ] ASF GitHub Bot commented on FLINK-1389: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...

2015-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291657#comment-14291657 ] ASF GitHub Bot commented on FLINK-1389: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat

2015-01-26 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-1389. --- Resolution: Fixed Fix Version/s: 0.8.1 0.9 Merged to master in http:

[jira] [Commented] (FLINK-1303) HadoopInputFormat does not work with Scala API

2015-01-26 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291683#comment-14291683 ] Aljoscha Krettek commented on FLINK-1303: - I think we can easily rework this to re

[jira] [Created] (FLINK-1452) Add "flink-contrib" maven module and README.md with the rules

2015-01-26 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-1452: - Summary: Add "flink-contrib" maven module and README.md with the rules Key: FLINK-1452 URL: https://issues.apache.org/jira/browse/FLINK-1452 Project: Flink

[jira] [Updated] (FLINK-1452) Add "flink-contrib" maven module and README.md with the rules

2015-01-26 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1452: -- Component/s: flink-contrib > Add "flink-contrib" maven module and README.md with the rules > ---

[jira] [Created] (FLINK-1453) Integration tests for YARN failing on OS X

2015-01-26 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-1453: - Summary: Integration tests for YARN failing on OS X Key: FLINK-1453 URL: https://issues.apache.org/jira/browse/FLINK-1453 Project: Flink Issue Type: Bug

[GitHub] flink pull request: [FLINK-1369] [types] Add support for Subclasse...

2015-01-26 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/316#issuecomment-71445361 It's almost the same, except for the change to handle Interfaces and Abstract Classes with GenericTypeInfo, correct? The part that changes the KryoSerializer must

[jira] [Commented] (FLINK-1369) The Pojo Serializers/Comparators fail when using Subclasses or Interfaces

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291700#comment-14291700 ] ASF GitHub Bot commented on FLINK-1369: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [Flink-1436] refactor CLiFrontend to provide m...

2015-01-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/331#issuecomment-71446044 @rmetzger @StephanEwen I squashed the commits, merged the recent changes in the CliFrontend on the master, and addressed [FLINK-1424](https://issues.apache.org/jira/browse/FLI

[jira] [Commented] (FLINK-1424) bin/flink run does not recognize -c parameter anymore

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291702#comment-14291702 ] ASF GitHub Bot commented on FLINK-1424: --- Github user mxm commented on the pull reque

[jira] [Commented] (FLINK-1352) Buggy registration from TaskManager to JobManager

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291703#comment-14291703 ] ASF GitHub Bot commented on FLINK-1352: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-1352] [runtime] Fix buggy registration ...

2015-01-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/328#discussion_r23523589 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -175,62 +175,79 @@ import scala.collection.JavaConve

[GitHub] flink pull request: [FLINK-1352] [runtime] Fix buggy registration ...

2015-01-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/328#discussion_r23523674 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -175,62 +175,79 @@ import scala.collection.JavaConve

[jira] [Commented] (FLINK-1352) Buggy registration from TaskManager to JobManager

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291708#comment-14291708 ] ASF GitHub Bot commented on FLINK-1352: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request: [FLINK-1369] [types] Add support for Subclasse...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/316#issuecomment-71447121 Yes, Pojo types with no internal fields would screw up the flat field addressing of the optimizer. --- If your project is set up for it, you can reply to this email and h

[jira] [Commented] (FLINK-1369) The Pojo Serializers/Comparators fail when using Subclasses or Interfaces

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291711#comment-14291711 ] ASF GitHub Bot commented on FLINK-1369: --- Github user fhueske commented on the pull r

[jira] [Commented] (FLINK-1450) Add Fold operator to the Streaming api

2015-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291714#comment-14291714 ] Fabian Hueske commented on FLINK-1450: -- I believe this is equivalent (or very similar

[GitHub] flink pull request: [FLINK-1428] Update dataset_transformations.md

2015-01-26 Thread FelixNeutatz
GitHub user FelixNeutatz opened a pull request: https://github.com/apache/flink/pull/340 [FLINK-1428] Update dataset_transformations.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/FelixNeutatz/incubator-flink FelixNeutatz-pa

[jira] [Assigned] (FLINK-1428) Typos in Java code example for RichGroupReduceFunction

2015-01-26 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Neutatz reassigned FLINK-1428: Assignee: Felix Neutatz > Typos in Java code example for RichGroupReduceFunction >

[jira] [Commented] (FLINK-1428) Typos in Java code example for RichGroupReduceFunction

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291743#comment-14291743 ] ASF GitHub Bot commented on FLINK-1428: --- GitHub user FelixNeutatz opened a pull requ

[jira] [Commented] (FLINK-377) Create a general purpose framework for language bindings

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291766#comment-14291766 ] ASF GitHub Bot commented on FLINK-377: -- Github user zentol commented on the pull reque

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-01-26 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-71453267 I've rebased and update this PR. Notable new stuff: * hybrid mode removed * documentation update and integrated into website * **chaining** on the python

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526787 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotAvailabilityListener.java --- @@ -21,7 +21,7 @@ import org.apach

[jira] [Commented] (FLINK-1415) Akka cleanups

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291769#comment-14291769 ] ASF GitHub Bot commented on FLINK-1415: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526836 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotSharingGroupAssignment.java --- @@ -42,86 +44,82 @@ public class

[jira] [Commented] (FLINK-1415) Akka cleanups

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291770#comment-14291770 ] ASF GitHub Bot commented on FLINK-1415: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request: [FLINK-1428] Update dataset_transformations.md

2015-01-26 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/340#issuecomment-71453921 +1 Will merge this later to `master` and `release-0.8`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[jira] [Commented] (FLINK-1428) Typos in Java code example for RichGroupReduceFunction

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291771#comment-14291771 ] ASF GitHub Bot commented on FLINK-1428: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/319#discussion_r23526978 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java --- @@ -329,6 +330,15 @@ public void unregisterMemoryManager(MemoryManage

[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-26 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71454018 Very nice. +1 Will merge this later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[jira] [Commented] (FLINK-1415) Akka cleanups

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291773#comment-14291773 ] ASF GitHub Bot commented on FLINK-1415: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-1330) Restructure directory layout

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291774#comment-14291774 ] ASF GitHub Bot commented on FLINK-1330: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-1428] Update dataset_transformations.md

2015-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/340 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (FLINK-1428) Typos in Java code example for RichGroupReduceFunction

2015-01-26 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi resolved FLINK-1428. Resolution: Fixed Fixed in 06b2acf. > Typos in Java code example for RichGroupReduceFunction >

[jira] [Commented] (FLINK-1428) Typos in Java code example for RichGroupReduceFunction

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291779#comment-14291779 ] ASF GitHub Bot commented on FLINK-1428: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-26 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/333#discussion_r23527422 --- Diff: flink-dist/pom.xml --- @@ -436,6 +436,37 @@ under the License.

[jira] [Commented] (FLINK-1330) Restructure directory layout

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291781#comment-14291781 ] ASF GitHub Bot commented on FLINK-1330: --- Github user aljoscha commented on a diff in

[GitHub] flink pull request: [FLINK-1168] Adds multi-char field delimiter s...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/264#issuecomment-71455623 Updated the PR and will merge once Travis completed the build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[jira] [Commented] (FLINK-1168) Support multi-character field delimiters in CSVInputFormats

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291783#comment-14291783 ] ASF GitHub Bot commented on FLINK-1168: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/319#issuecomment-71455790 This is a huge change. I took a look over the code, but I don't have enough experience with the scheduler to understand these changes. I would suggest to merge th

[jira] [Commented] (FLINK-1415) Akka cleanups

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291785#comment-14291785 ] ASF GitHub Bot commented on FLINK-1415: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-1344] [streaming] Added static StreamEx...

2015-01-26 Thread senorcarbone
GitHub user senorcarbone opened a pull request: https://github.com/apache/flink/pull/341 [FLINK-1344] [streaming] Added static StreamExecutionEnvironment initialisation and Implicits for scala sources This PR addresses the ticket [1] for further scala constructs interoperability. I

[jira] [Commented] (FLINK-1344) Add implicit conversion from scala streams to DataStreams

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291787#comment-14291787 ] ASF GitHub Bot commented on FLINK-1344: --- GitHub user senorcarbone opened a pull requ

[jira] [Updated] (FLINK-1320) Add an off-heap variant of the managed memory

2015-01-26 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1320: -- Assignee: Max Michels > Add an off-heap variant of the managed memory >

[jira] [Updated] (FLINK-1424) bin/flink run does not recognize -c parameter anymore

2015-01-26 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1424: -- Assignee: Max Michels > bin/flink run does not recognize -c parameter anymore >

[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-26 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/333#discussion_r23528552 --- Diff: flink-dist/pom.xml --- @@ -436,6 +436,37 @@ under the License.

[jira] [Commented] (FLINK-1330) Restructure directory layout

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291796#comment-14291796 ] ASF GitHub Bot commented on FLINK-1330: --- Github user uce commented on a diff in the

[jira] [Commented] (FLINK-1415) Akka cleanups

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291800#comment-14291800 ] ASF GitHub Bot commented on FLINK-1415: --- Github user uce commented on the pull reque

[GitHub] flink pull request: [FLINK-1415] Akka cleanups

2015-01-26 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/319#issuecomment-71458216 I think @StephanEwen is reviewing the critical part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] flink pull request: [FLINK-377] [FLINK-671] Generic Interface / PA...

2015-01-26 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/202#issuecomment-71458700 Wow, great news! :-) In general, I think we really have to do something about getting the changes in. The PR is growing faster than its getting feedback. Has anybody

[jira] [Commented] (FLINK-377) Create a general purpose framework for language bindings

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291803#comment-14291803 ] ASF GitHub Bot commented on FLINK-377: -- Github user uce commented on the pull request:

[jira] [Assigned] (FLINK-1443) Add replicated data source

2015-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-1443: Assignee: Fabian Hueske > Add replicated data source > -- > >

[jira] [Assigned] (FLINK-1105) Add support for locally sorted output

2015-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-1105: Assignee: Fabian Hueske > Add support for locally sorted output > -

[GitHub] flink pull request: Mk amulti char delim

2015-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-1168) Support multi-character field delimiters in CSVInputFormats

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291830#comment-14291830 ] ASF GitHub Bot commented on FLINK-1168: --- Github user asfgit closed the pull request

[GitHub] flink pull request: [FLINK-1168] Adds multi-char field delimiter s...

2015-01-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (FLINK-1168) Support multi-character field delimiters in CSVInputFormats

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291831#comment-14291831 ] ASF GitHub Bot commented on FLINK-1168: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-1168) Support multi-character field delimiters in CSVInputFormats

2015-01-26 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske resolved FLINK-1168. -- Resolution: Fixed Fixed with 0548a93dfc555a5403590f147d4850c730facaf6 > Support multi-character

[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71464164 -1 I think we need to add the `build-target` "directory" into the list of ignored directories for apache rat. Rat will fail subsequent builds ``` 1 Unknown Lic

[jira] [Commented] (FLINK-1330) Restructure directory layout

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291839#comment-14291839 ] ASF GitHub Bot commented on FLINK-1330: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-1201] Add flink-gelly to flink-addons (...

2015-01-26 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/335#issuecomment-71465448 Haven't had a closer look yet, but one thing that I noticed is the naming of the test files. In the current codebase all tests are named XyzTest (or XyzITCase) instead

[jira] [Commented] (FLINK-1450) Add Fold operator to the Streaming api

2015-01-26 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291852#comment-14291852 ] Gyula Fora commented on FLINK-1450: --- It is actually something quite different. With red

[jira] [Commented] (FLINK-1201) Graph API for Flink

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291851#comment-14291851 ] ASF GitHub Bot commented on FLINK-1201: --- Github user fhueske commented on the pull r

[jira] [Created] (FLINK-1454) CliFrontend blocks for 100 seconds when submitting to a non-existent JobManager

2015-01-26 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-1454: - Summary: CliFrontend blocks for 100 seconds when submitting to a non-existent JobManager Key: FLINK-1454 URL: https://issues.apache.org/jira/browse/FLINK-1454 Proje

[GitHub] flink pull request: [Flink-1436] refactor CLiFrontend to provide m...

2015-01-26 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/331#issuecomment-71467375 I think it would be better not to print the help if the user specified something incorrectly. Maybe just the error message and a note that -h prints the help? I'

[jira] [Created] (FLINK-1455) ExternalSortLargeRecordsITCase.testSortWithShortMediumAndLargeRecords: Potential Memory leak

2015-01-26 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-1455: - Summary: ExternalSortLargeRecordsITCase.testSortWithShortMediumAndLargeRecords: Potential Memory leak Key: FLINK-1455 URL: https://issues.apache.org/jira/browse/FLINK-1455

[GitHub] flink pull request: [FLINK-1330] [build] Build creates a link in t...

2015-01-26 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/333#issuecomment-71468579 Very good catch. I would address @aljoscha's comment and add the exclude. After that, I think it's fine to merge. I've tested it locally and it works fine.

[jira] [Commented] (FLINK-1330) Restructure directory layout

2015-01-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291880#comment-14291880 ] ASF GitHub Bot commented on FLINK-1330: --- Github user uce commented on the pull reque

  1   2   3   >