[ 
https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291644#comment-14291644
 ] 

ASF GitHub Bot commented on FLINK-1389:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/301#issuecomment-71439040
  
    You are right, I should have made the requirements clear in the beginning. 
I actually had a discussion with the user which approach is the best.
    I took the view that a string based method is easier for now and 
implemented it.
    Then, we had the whole discussion here and I thought, now, that everybody 
is unhappy with my approach, I better do exactly what the user wants, instead 
of going with a strong opinion.
    
    And now I'm confused and upset. But to be realistic: We only had one user 
so who wanted to change the filenames at all. If there is ever going to be a 
second or third user, they either have to do another contribution or overwrite 
their input format. 
    
    http://bikeshed.com/ (see also: 
http://en.wikipedia.org/wiki/Parkinson%27s_law_of_triviality)


> Allow setting custom file extensions for files created by the FileOutputFormat
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-1389
>                 URL: https://issues.apache.org/jira/browse/FLINK-1389
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>            Priority: Minor
>
> A user requested the ability to name avro files with the "avro" extension.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to