Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-10 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033079768 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -196,72 +213,87 @@ synchronized

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-10 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2032837282 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,62 +102,81 @@ private FSDa

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
Zakelly merged PR #26415: URL: https://github.com/apache/flink/pull/26415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
Zakelly opened a new pull request, #26421: URL: https://github.com/apache/flink/pull/26421 Backport for #26415 ## What is the purpose of the change There is a concurrency issue for reference counting in ForSt file cache, which could lead to a read error in some special scenario

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
flinkbot commented on PR #26421: URL: https://github.com/apache/flink/pull/26421#issuecomment-2788157800 ## CI report: * 0809aedcc5a7bda03c8b76d5f37695e94c7892ce UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033323400 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -196,72 +213,87 @@ synchronized

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
Zakelly commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033182493 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -125,39 +127,53 @@ private FSData

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
Zakelly commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033179560 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -196,72 +213,87 @@ synchronized v

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
Zakelly commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033177251 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -196,72 +213,87 @@ synchronized v

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
Zakelly commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033176278 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -169,12 +185,13 @@ private void t

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
Zakelly commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033172810 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,15 +102,17 @@ private FSData

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033084718 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,15 +102,17 @@ private FSDa

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033092597 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -169,12 +185,13 @@ private void

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033078702 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -169,12 +185,13 @@ private void

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033075357 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,15 +102,17 @@ private FSDa

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033088651 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -125,39 +127,53 @@ private FSDa

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033089874 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -125,39 +127,53 @@ private FSDa

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033081370 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -196,72 +213,87 @@ synchronized

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033078702 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -169,12 +185,13 @@ private void

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2033074588 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,15 +102,17 @@ private FSDa

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
Zakelly commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2032971049 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,62 +102,81 @@ private FSData

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
fredia commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2032449420 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,62 +102,81 @@ private FSDataI

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2032841145 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,62 +102,81 @@ private FSDa

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-08 Thread via GitHub
davidradl commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2032833951 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,62 +102,81 @@ private FSDa

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-07 Thread via GitHub
flinkbot commented on PR #26415: URL: https://github.com/apache/flink/pull/26415#issuecomment-2785105538 ## CI report: * 7b963ba791e89acf37bb95e08dcfdc724dee6624 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-07 Thread via GitHub
fredia commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2032341068 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,62 +102,81 @@ private FSDataI

Re: [PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-07 Thread via GitHub
Zakelly commented on code in PR #26415: URL: https://github.com/apache/flink/pull/26415#discussion_r2032354803 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java: ## @@ -102,62 +102,81 @@ private FSData

[PR] [FLINK-37628] Fix reference counting in ForSt file cache [flink]

2025-04-07 Thread via GitHub
Zakelly opened a new pull request, #26415: URL: https://github.com/apache/flink/pull/26415 ## What is the purpose of the change There is a concurrency issue for reference counting in ForSt file cache, which could lead to a read error in some special scenarios (e.g. extremely frequent