davidradl commented on code in PR #26415:
URL: https://github.com/apache/flink/pull/26415#discussion_r2033078702


##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/cache/CachedDataInputStream.java:
##########
@@ -169,12 +185,13 @@ private void tryReopen() {
                             StreamStatus.CACHED_OPEN);
                     fsdis.seek(originalStream.getPos());
                     streamStatus = StreamStatus.CACHED_OPEN;
-                    cacheEntry.release();
+                    return fsdis;
                 }
             } catch (IOException e) {
                 LOG.warn("Reopen stream error.", e);

Review Comment:
   nit: 
   stream -> cache stream
   should we change streamStatus here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to