Re: [PR] [FLINK-37269][table] Add new DESCRIPTOR type [flink]

2025-02-12 Thread via GitHub
snuyanzin commented on code in PR #26144: URL: https://github.com/apache/flink/pull/26144#discussion_r1952261112 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/extraction/DataTypeExtractor.java: ## @@ -335,7 +335,7 @@ private DataType extractDataTyp

Re: [PR] [FLINK-37269][table] Add new DESCRIPTOR type [flink]

2025-02-12 Thread via GitHub
snuyanzin commented on code in PR #26144: URL: https://github.com/apache/flink/pull/26144#discussion_r1952245175 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -252,6 +253,12 @@ * Added in FLINK-34312: Lines 5804 ~ 5

Re: [PR] [FLINK-37269][table] Add new DESCRIPTOR type [flink]

2025-02-11 Thread via GitHub
twalthr commented on code in PR #26144: URL: https://github.com/apache/flink/pull/26144#discussion_r1951134371 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/SqlTypeAssignmentRule.java: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] [FLINK-37269][table] Add new DESCRIPTOR type [flink]

2025-02-11 Thread via GitHub
flinkbot commented on PR #26144: URL: https://github.com/apache/flink/pull/26144#issuecomment-2651251992 ## CI report: * 39007934cf9352c558b10454492dadfa3c29da06 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-37269][table] Add new DESCRIPTOR type [flink]

2025-02-11 Thread via GitHub
twalthr opened a new pull request, #26144: URL: https://github.com/apache/flink/pull/26144 ## What is the purpose of the change Adds the DESCRIPTOR type to the Flink type system. The DESCRIPTOR type is defined by the SQL standard and necessary for passing a list of column names into