twalthr commented on code in PR #26144: URL: https://github.com/apache/flink/pull/26144#discussion_r1951134371
########## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/SqlTypeAssignmentRule.java: ########## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.calcite.sql.type; + +import com.google.common.collect.ImmutableMap; +import com.google.common.collect.ImmutableSet; + +import java.util.EnumSet; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; + +/** + * Rules that determine whether a type is assignable from another type. + * + * <p>Added until Calcite supports {@link SqlTypeName#COLUMN_LIST}. + */ +public class SqlTypeAssignmentRule implements SqlTypeMappingRule { + // ~ Static fields/initializers --------------------------------------------- + + private static final SqlTypeAssignmentRule INSTANCE; + + // ~ Instance fields -------------------------------------------------------- + + private final Map<SqlTypeName, ImmutableSet<SqlTypeName>> map; + + // ~ Constructors ----------------------------------------------------------- + + /** + * Creates a {@code SqlTypeAssignmentRules} with specified type mappings {@code map}. + * + * <p>Make this constructor private intentionally, use {@link #instance()}. + * + * @param map The type mapping, for each map entry, the values types can be assigned to the key + * type + */ + private SqlTypeAssignmentRule(Map<SqlTypeName, ImmutableSet<SqlTypeName>> map) { + this.map = ImmutableMap.copyOf(map); + } + + static { + final SqlTypeMappingRules.Builder rules = SqlTypeMappingRules.builder(); + + final Set<SqlTypeName> rule = new HashSet<>(); + + // IntervalYearMonth is assignable from... + for (SqlTypeName interval : SqlTypeName.YEAR_INTERVAL_TYPES) { + rules.add(interval, SqlTypeName.YEAR_INTERVAL_TYPES); + } + for (SqlTypeName interval : SqlTypeName.DAY_INTERVAL_TYPES) { + rules.add(interval, SqlTypeName.DAY_INTERVAL_TYPES); + } + + // MULTISET is assignable from... + rules.add(SqlTypeName.MULTISET, EnumSet.of(SqlTypeName.MULTISET)); + + // TINYINT is assignable from... + rules.add(SqlTypeName.TINYINT, EnumSet.of(SqlTypeName.TINYINT)); + + // SMALLINT is assignable from... + rule.clear(); + rule.add(SqlTypeName.TINYINT); + rule.add(SqlTypeName.SMALLINT); + rules.add(SqlTypeName.SMALLINT, rule); + + // INTEGER is assignable from... + rule.clear(); + rule.add(SqlTypeName.TINYINT); + rule.add(SqlTypeName.SMALLINT); + rule.add(SqlTypeName.INTEGER); + rules.add(SqlTypeName.INTEGER, rule); + + // BIGINT is assignable from... + rule.clear(); + rule.add(SqlTypeName.TINYINT); + rule.add(SqlTypeName.SMALLINT); + rule.add(SqlTypeName.INTEGER); + rule.add(SqlTypeName.BIGINT); + rules.add(SqlTypeName.BIGINT, rule); + + // FLOAT (up to 64 bit floating point) is assignable from... + rule.clear(); + rule.add(SqlTypeName.TINYINT); + rule.add(SqlTypeName.SMALLINT); + rule.add(SqlTypeName.INTEGER); + rule.add(SqlTypeName.BIGINT); + rule.add(SqlTypeName.DECIMAL); + rule.add(SqlTypeName.FLOAT); + rules.add(SqlTypeName.FLOAT, rule); + + // REAL (32 bit floating point) is assignable from... + rule.clear(); + rule.add(SqlTypeName.TINYINT); + rule.add(SqlTypeName.SMALLINT); + rule.add(SqlTypeName.INTEGER); + rule.add(SqlTypeName.BIGINT); + rule.add(SqlTypeName.DECIMAL); + rule.add(SqlTypeName.FLOAT); + rule.add(SqlTypeName.REAL); + rules.add(SqlTypeName.REAL, rule); + + // DOUBLE is assignable from... + rule.clear(); + rule.add(SqlTypeName.TINYINT); + rule.add(SqlTypeName.SMALLINT); + rule.add(SqlTypeName.INTEGER); + rule.add(SqlTypeName.BIGINT); + rule.add(SqlTypeName.DECIMAL); + rule.add(SqlTypeName.FLOAT); + rule.add(SqlTypeName.REAL); + rule.add(SqlTypeName.DOUBLE); + rules.add(SqlTypeName.DOUBLE, rule); + + // DECIMAL is assignable from... + rule.clear(); + rule.add(SqlTypeName.TINYINT); + rule.add(SqlTypeName.SMALLINT); + rule.add(SqlTypeName.INTEGER); + rule.add(SqlTypeName.BIGINT); + rule.add(SqlTypeName.REAL); + rule.add(SqlTypeName.DOUBLE); + rule.add(SqlTypeName.DECIMAL); + rules.add(SqlTypeName.DECIMAL, rule); + + // VARBINARY is assignable from... + rule.clear(); + rule.add(SqlTypeName.VARBINARY); + rule.add(SqlTypeName.BINARY); + rules.add(SqlTypeName.VARBINARY, rule); + + // CHAR is assignable from... + rules.add(SqlTypeName.CHAR, EnumSet.of(SqlTypeName.CHAR)); + + // VARCHAR is assignable from... + rule.clear(); + rule.add(SqlTypeName.CHAR); + rule.add(SqlTypeName.VARCHAR); + rules.add(SqlTypeName.VARCHAR, rule); + + // BOOLEAN is assignable from... + rules.add(SqlTypeName.BOOLEAN, EnumSet.of(SqlTypeName.BOOLEAN)); + + // BINARY is assignable from... + rule.clear(); + rule.add(SqlTypeName.BINARY); + rule.add(SqlTypeName.VARBINARY); + rules.add(SqlTypeName.BINARY, rule); + + // DATE is assignable from... + rule.clear(); + rule.add(SqlTypeName.DATE); + rules.add(SqlTypeName.DATE, rule); + + // TIME is assignable from... + rule.clear(); + rule.add(SqlTypeName.TIME); + rules.add(SqlTypeName.TIME, rule); + + // TIME WITH LOCAL TIME ZONE is assignable from... + rules.add( + SqlTypeName.TIME_WITH_LOCAL_TIME_ZONE, + EnumSet.of(SqlTypeName.TIME_WITH_LOCAL_TIME_ZONE)); + + // TIMESTAMP is assignable from ... + rules.add(SqlTypeName.TIMESTAMP, EnumSet.of(SqlTypeName.TIMESTAMP)); + + // TIMESTAMP WITH LOCAL TIME ZONE is assignable from... + rules.add( + SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE, + EnumSet.of(SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE)); + + // GEOMETRY is assignable from ... + rule.clear(); + rule.add(SqlTypeName.GEOMETRY); + rule.add(SqlTypeName.CHAR); + rule.add(SqlTypeName.VARCHAR); + rules.add(SqlTypeName.GEOMETRY, rule); + + // ARRAY is assignable from ... + rules.add(SqlTypeName.ARRAY, EnumSet.of(SqlTypeName.ARRAY)); + + // MAP is assignable from ... + rules.add(SqlTypeName.MAP, EnumSet.of(SqlTypeName.MAP)); + + // SYMBOL is assignable from ... + rules.add(SqlTypeName.SYMBOL, EnumSet.of(SqlTypeName.SYMBOL)); + + // ----- FLINK MODIFICATION BEGIN ----- + // COLUMN_LIST is assignable from ... + rules.add(SqlTypeName.COLUMN_LIST, EnumSet.of(SqlTypeName.COLUMN_LIST)); Review Comment: @snuyanzin could you contribute this line to Calcite? Should be an easy PR if not just a hotfix commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
