leonardBang merged PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink
lvyanquan commented on PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#issuecomment-2589457539
Hi, @leonardBang, could you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Jzjsnow commented on code in PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1908197660
##
flink-cdc-cli/src/test/java/org/apache/flink/cdc/cli/CliFrontendTest.java:
##
@@ -145,6 +147,70 @@ void testPipelineExecuting() throws Exception {
assert
Jzjsnow commented on code in PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1908197660
##
flink-cdc-cli/src/test/java/org/apache/flink/cdc/cli/CliFrontendTest.java:
##
@@ -145,6 +147,70 @@ void testPipelineExecuting() throws Exception {
assert
yuxiqian commented on PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#issuecomment-2576581962
`org.apache.flink.cdc.cli.CliFrontendTest#testGeneratingHelpMessage` and
`org.apache.flink.cdc.cli.CliFrontendTest#testNoArgument` is still failing,
presumably because `-D ` is so long
hiliuxg commented on code in PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1905171238
##
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/CliFrontend.java:
##
@@ -114,6 +122,22 @@ static CliExecutor createExecutor(CommandLine commandLine)
throws E
yuxiqian commented on PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#issuecomment-2574765066
@hiliuxg Seems there are some test cases in
`org.apache.flink.cdc.cli.CliFrontendTest` that needs to be updated.
--
This is an automated message from the Apache Git Service.
To respo
yuxiqian commented on code in PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1905026628
##
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/CliFrontend.java:
##
@@ -114,6 +122,22 @@ static CliExecutor createExecutor(CommandLine commandLine)
throws
yuxiqian commented on code in PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1905026628
##
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/CliFrontend.java:
##
@@ -114,6 +122,22 @@ static CliExecutor createExecutor(CommandLine commandLine)
throws
hiliuxg commented on PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#issuecomment-2574572010
hi @yuxiqian , thank you for your guidance. I have made another version of
the code. Please review it again when you have time.
--
This is an automated message from the Apache Git Se
yuxiqian commented on code in PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1904935262
##
flink-cdc-cli/src/test/java/org/apache/flink/cdc/cli/CliFrontendTest.java:
##
@@ -145,6 +147,86 @@ void testPipelineExecuting() throws Exception {
asser
hiliuxg commented on PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#issuecomment-2574347733
Hi @yuxiqian, thanks for the review. I have accepted your suggestions and
made the necessary modifications. Please review again when you have time.
thanks .
--
This is an automated m
yuxiqian commented on code in PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1903736412
##
flink-cdc-cli/src/test/java/org/apache/flink/cdc/cli/CliFrontendTest.java:
##
@@ -145,6 +146,31 @@ void testPipelineExecuting() throws Exception {
asser
13 matches
Mail list logo
