Jzjsnow commented on code in PR #3823:
URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1908197660


##########
flink-cdc-cli/src/test/java/org/apache/flink/cdc/cli/CliFrontendTest.java:
##########
@@ -145,6 +147,70 @@ void testPipelineExecuting() throws Exception {
         
assertThat(executionInfo.getDescription()).isEqualTo("fake-description");
     }
 
+    @Test
+    void testPipelineExecutingWithFlinkConfig() throws Exception {

Review Comment:
   I'm wondering if we need to add some more use cases that test for the 
concatenation of ā€œ-Dā€ and key=value pairs instead of space-separated pairs, 
such as "-Dexecution.target= yarn-session". I'm concerned that there are cases 
that might not be recognized, such as "-D=execution.target".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to