Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-07 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1985014677 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/split/KuduSourceSplit.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-06 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1983875707 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/split/KuduSourceSplit.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1981408324 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumeratorStateSerializerTest.java: ## @@ -0,0 +1,101 @@

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1980100133 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumeratorStateSerializerTest.java: ## @@ -0,0 +1,101 @@

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1981409990 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumeratorStateSerializerTest.java: ## @@ -0,0 +1,101 @@

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1981405621 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumeratorStateSerializerTest.java: ## @@ -0,0 +1,101 @@

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1981397597 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceITCase.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1980080222 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceITCase.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979988711 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979991125 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979991560 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/utils/KuduSplitGenerator.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979989809 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979887307 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979790813 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979799806 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977735111 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/testutils/KuduSourceITBase.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache S

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977732794 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/reader/KuduSourceReader.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apac

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977734299 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSource.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977733939 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/reader/KuduSourceReader.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apac

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977733401 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/reader/KuduSourceReader.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apac

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977726108 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,256 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977724995 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,256 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977724631 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,256 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977721833 ## flink-connector-kudu/pom.xml: ## @@ -64,11 +69,22 @@ under the License. flink-table-runtime +

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-03 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1977722483 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/config/ContinuousBoundingSettings.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed t

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-28 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1975608209 ## flink-connector-kudu/pom.xml: ## @@ -64,11 +69,22 @@ under the License. flink-table-runtime +

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-28 Thread via GitHub
martongreber commented on PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#issuecomment-2691092502 Thank you for the catch about supporting the unbounded option. tweaked the enumerator such that it works now in continuouos unbounded or bounded modes. added some tests. In K

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-28 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1975012638 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSource.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-28 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1975011086 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/connector/converter/RowResultRowConverter.java: ## @@ -31,6 +32,9 @@ public Row conve

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-27 Thread via GitHub
zchovan commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1973476179 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/split/KuduSourceSplitSerializer.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-27 Thread via GitHub
zchovan commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1973475760 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/connector/converter/RowResultRowConverter.java: ## @@ -31,6 +32,9 @@ public Row convert(Ro

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-27 Thread via GitHub
zchovan commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1973475387 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-27 Thread via GitHub
zchovan commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1973475090 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/KuduSourceBuilder.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-27 Thread via GitHub
zchovan commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1973474719 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-27 Thread via GitHub
zchovan commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1973473991 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-27 Thread via GitHub
zchovan commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1973472913 ## flink-connector-kudu/pom.xml: ## @@ -39,6 +39,16 @@ under the License. flink-clients + +

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-27 Thread via GitHub
zchovan commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1973473641 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumeratorState.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-02-26 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1971718961 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to