ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1983875707
########## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/split/KuduSourceSplit.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.kudu.source.split; + +import org.apache.flink.api.connector.source.SourceSplit; + +import java.io.Serializable; +import java.util.Arrays; +import java.util.Base64; + +/** The Kudu source split that wraps a Kudu scan token. */ +public class KuduSourceSplit implements SourceSplit, Serializable { + + /** + * Serialized byte[] is already compact and Flink-optimized, whereas the full KuduScanToken + * object might include unnecessary metadata or complex internal structures. + */ + private final byte[] serializedScanToken; + + public KuduSourceSplit(byte[] serializedScanToken) { + this.serializedScanToken = serializedScanToken; + } + + public byte[] getSerializedScanToken() { + return serializedScanToken; + } + + @Override + public String splitId() { + return Base64.getEncoder().encodeToString(serializedScanToken); Review Comment: Lets create an `SHA-1` digest instead of writing out the whole token. After some testing, the whole token is pretty long and makes the log a lot less readable. The `commons-codec` project has `DigestUtils` which can do the easily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
