Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2025-01-12 Thread via GitHub
luoyuxia commented on code in PR #25258: URL: https://github.com/apache/flink/pull/25258#discussion_r1912604617 ## docs/content/docs/connectors/table/hive/overview.md: ## @@ -313,6 +313,20 @@ Below are the options supported when creating a `HiveCatalog` instance with YAML

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2025-01-12 Thread via GitHub
luoyuxia commented on code in PR #25258: URL: https://github.com/apache/flink/pull/25258#discussion_r1912604617 ## docs/content/docs/connectors/table/hive/overview.md: ## @@ -313,6 +313,20 @@ Below are the options supported when creating a `HiveCatalog` instance with YAML

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2025-01-12 Thread via GitHub
luoyuxia commented on code in PR #25258: URL: https://github.com/apache/flink/pull/25258#discussion_r1912604472 ## docs/content/docs/connectors/table/hive/overview.md: ## @@ -313,6 +313,20 @@ Below are the options supported when creating a `HiveCatalog` instance with YAML

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2025-01-12 Thread via GitHub
zhuanshenbsj1 commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2586037793 > @zhuanshenbsj1 Thanks...LGTM.. But could you please rebase master? Thanks for the review. I've rebased the code. -- This is an automated message from the Apache Git Servic

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2025-01-10 Thread via GitHub
luoyuxia commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2585115946 FYI, let's wait the response for the question I asked in [FLINK-37097](https://issues.apache.org/jira/browse/FLINK-37097?focusedCommentId=17912172&page=com.atlassian.jira.plugin.system.is

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-12-17 Thread via GitHub
zhuanshenbsj1 commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2550213990 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-12-16 Thread via GitHub
zhuanshenbsj1 commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2544941538 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-12-15 Thread via GitHub
zhuanshenbsj1 commented on code in PR #25258: URL: https://github.com/apache/flink/pull/25258#discussion_r1886265775 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java: ## @@ -226,6 +243,37 @@ public HiveCatalog( }

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-12-15 Thread via GitHub
zhuanshenbsj1 commented on code in PR #25258: URL: https://github.com/apache/flink/pull/25258#discussion_r1886263037 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java: ## @@ -226,6 +243,37 @@ public HiveCatalog( }

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-12-15 Thread via GitHub
zhuanshenbsj1 commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2544739370 @luoyuxia cc~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-12-15 Thread via GitHub
zhuanshenbsj1 commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2544738657 @luoyuxia cc~ > @zhuanshenbsj1 Thanks for contribution. And sorry for late reply. I left some comments; Also, please fill the motivation in JIRA [FLINK-36160](https://issues

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-11-06 Thread via GitHub
zhuanshenbsj1 commented on code in PR #25258: URL: https://github.com/apache/flink/pull/25258#discussion_r1830690168 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java: ## @@ -226,6 +243,37 @@ public HiveCatalog( }

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-11-06 Thread via GitHub
luoyuxia commented on code in PR #25258: URL: https://github.com/apache/flink/pull/25258#discussion_r1830600593 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java: ## @@ -226,6 +243,37 @@ public HiveCatalog( }

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-09-11 Thread via GitHub
zhuanshenbsj1 commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2345139801 @luoyuxia cc~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-08-27 Thread via GitHub
flinkbot commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2312648935 ## CI report: * 65a84f3a32e91294c6227f460c6ce97bc0d73868 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36160] Support hive advanced configuration [flink]

2024-08-27 Thread via GitHub
zhuanshenbsj1 opened a new pull request, #25258: URL: https://github.com/apache/flink/pull/25258 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring t