Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

[via GitHub]

luoyuxia commented on code in PR #25258:
URL: https://github.com/apache/flink/pull/25258#discussion_r1912604472


##########
docs/content/docs/connectors/table/hive/overview.md:
##########
@@ -313,6 +313,20 @@ Below are the options supported when creating a 
`HiveCatalog` instance with YAML
       <td>String</td>
       <td>Path to Hadoop conf dir. Only local file system paths are supported. 
The recommended way to set Hadoop conf is via the <b>HADOOP_CONF_DIR</b> 
environment variable. Use the option only if environment variable doesn't work 
for you, e.g. if you want to configure each HiveCatalog separately.</td>
     </tr>
+    <tr>

Review Comment:
   Remove these two configuration in here since it's not for creating 
HiveCatalog.



##########
docs/content/docs/connectors/table/hive/overview.md:
##########
@@ -313,6 +313,20 @@ Below are the options supported when creating a 
`HiveCatalog` instance with YAML
       <td>String</td>
       <td>Path to Hadoop conf dir. Only local file system paths are supported. 
The recommended way to set Hadoop conf is via the <b>HADOOP_CONF_DIR</b> 
environment variable. Use the option only if environment variable doesn't work 
for you, e.g. if you want to configure each HiveCatalog separately.</td>
     </tr>
+    <tr>
+      <td><h5>flink.hive.&lt;key&gt;</h5></td>
+      <td>No</td>
+      <td style="word-wrap: break-word;">(none)</td>
+      <td>String</td>
+      <td>A general option to probe hive configuration through prefix 
'flink.hive.'. Flink will remove the prefix to get &lt;key&gt; (from 
hive-site.xml) then set the &lt;key&gt; and value to hive configuration. For 
example, flink.hive.hive.metastore.client.socket.timeout=5 in Flink 
configuration and convert to hive.metastore.client.socket.timeout=5 in hive 
configuration.</td>
+    </tr>
+    <tr>
+      <td><h5>flink.hive.hadoop.&lt;key&gt;</h5></td>
+      <td>No</td>
+      <td style="word-wrap: break-word;">(none)</td>
+      <td>String</td>
+      <td>A general option to probe hadoop configuration for hive through 
prefix 'flink.hive.hadoop.'. Flink will remove the prefix to get &lt;key&gt; 
(from hdfs-site.xml and core-site.xml) then set the &lt;key&gt; and value to 
hadoop configuration for hive. For example, 
flink.hive.hadoop.dfs.client.socket-timeout=5000 in Flink configuration and 
convert to dfs.client.socket-timeout=5000 in hadoop configuration for hive.</td>
+    </tr>
     </tbody>
 </table>

Review Comment:
   Add a new line in here 
   ```
   _Note: The options used to configured HiveCatalog are derived from the 
configuration files from `hive-conf-dir` and `hadoop-conf-dir`, if you want to 
   configure HiveCatalog with overwriting some options in these configuration 
files, you can add the options with prefix `flink.hive.` or 
`flink.hive.hadoop.` in your Flink table configuration. 
   For example, `flink.hive.hive.metastore.client.socket.timeout: 5` and 
`flink.hive.hadoop.dfs.client.socket-timeout: 5000` in Flink configuration, it 
will be 
   converted to options `hive.metastore.client.socket.timeout: 5` and 
`hadoop.dfs.client.socket-timeout: 5000`, then passing them to configure 
HiveCatalog.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org