snuyanzin closed pull request #25200: [FLINK-36050][table] Support enhanced
`SHOW VIEW` syntax
URL: https://github.com/apache/flink/pull/25200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
twalthr commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1722860053
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowFunctionsConverter.java:
##
@@ -19,50 +19,49 @@
package or
snuyanzin commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1721961659
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowProceduresOperation.java:
##
@@ -65,7 +65,7 @@ protected Collection
retrieveD
snuyanzin commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1721682664
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowViewsConverter.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed
snuyanzin commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1721681790
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/AbstractSqlShowConverter.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licen
snuyanzin commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1721673717
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowProceduresOperation.java:
##
@@ -20,130 +20,83 @@
import org.apache.flink.a
twalthr commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1721523945
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -19,83 +19,54 @@
package org.apache.flink.table.
jnh5y commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1717551998
##
docs/content.zh/docs/dev/table/sql/show.md:
##
@@ -913,10 +913,17 @@ SHOW PROCEDURES [ ( FROM | IN )
[catalog_name.]database_name ] [ [NOT] (LIKE | I
## SHOW VIEWS
jnh5y commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1717550570
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlOtherOperationConverterTest.java:
##
@@ -222,26 +226,30 @@ void testShowView
snuyanzin commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1717450763
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowViewsOperation.java:
##
@@ -19,23 +19,125 @@
package org.apache.flink.table.o
jnh5y commented on PR #25200:
URL: https://github.com/apache/flink/pull/25200#issuecomment-2289317826
From a read through, just found the one issue and asked the one question.
Overall, this looks good and is consistent with
https://github.com/apache/flink/pull/18361
--
This is an automa
jnh5y commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1717264997
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowViewsOperation.java:
##
@@ -19,23 +19,125 @@
package org.apache.flink.table.opera
snuyanzin commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1717251475
##
docs/content.zh/docs/dev/table/sql/show.md:
##
@@ -913,10 +913,17 @@ SHOW PROCEDURES [ ( FROM | IN )
[catalog_name.]database_name ] [ [NOT] (LIKE | I
## SHOW VIE
jnh5y commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1717244214
##
docs/content.zh/docs/dev/table/sql/show.md:
##
@@ -913,10 +913,17 @@ SHOW PROCEDURES [ ( FROM | IN )
[catalog_name.]database_name ] [ [NOT] (LIKE | I
## SHOW VIEWS
snuyanzin commented on code in PR #25200:
URL: https://github.com/apache/flink/pull/25200#discussion_r1716954372
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowTables.java:
##
@@ -101,10 +101,8 @@ public List getOperandList() {
flinkbot commented on PR #25200:
URL: https://github.com/apache/flink/pull/25200#issuecomment-2288779628
## CI report:
* 2af84b098ee9f3c64f7da181fa8da4e8b5935ef9 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
snuyanzin opened a new pull request, #25200:
URL: https://github.com/apache/flink/pull/25200
## What is the purpose of the change
Support enhanced `SHOW VIEWS` syntax like `SHOW VIEWS FROM catalog1.db1 LIKE
't%'`
in a way similar to existing `SHOW TABLES` syntax
## Brie
17 matches
Mail list logo
