Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-11-04 Thread via GitHub
dawidwys merged PR #25171: URL: https://github.com/apache/flink/pull/25171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-11-04 Thread via GitHub
jnh5y commented on PR #25171: URL: https://github.com/apache/flink/pull/25171#issuecomment-2455044305 > one final comment on an import, otherwise +1 Apologies for that. While fixing that, I updated a few things relative to https://github.com/apache/flink/pull/24699/files. Hope

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-11-04 Thread via GitHub
dawidwys commented on code in PR #25171: URL: https://github.com/apache/flink/pull/25171#discussion_r1827346770 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecMatch.java: ## @@ -77,6 +79,7 @@ import java.util.Lis

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-10-24 Thread via GitHub
dawidwys commented on code in PR #25171: URL: https://github.com/apache/flink/pull/25171#discussion_r1814803784 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecMatch.java: ## @@ -86,7 +89,8 @@ public abstract class

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-10-24 Thread via GitHub
dawidwys commented on code in PR #25171: URL: https://github.com/apache/flink/pull/25171#discussion_r1814809608 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/MatchRecognizeTestPrograms.java: ## @@ -121,6 +122,27 @@ public

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-08-09 Thread via GitHub
jnh5y commented on code in PR #25171: URL: https://github.com/apache/flink/pull/25171#discussion_r1711600842 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/batch/MatchRecognizeBatchRestoreTest.java: ## @@ -0,0 +1,45 @@ +/* + * Lic

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-08-09 Thread via GitHub
jnh5y commented on code in PR #25171: URL: https://github.com/apache/flink/pull/25171#discussion_r1711596673 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/batch/MatchRecognizeBatchRestoreTest.java: ## @@ -0,0 +1,45 @@ +/* + * Lic

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-08-09 Thread via GitHub
jnh5y commented on code in PR #25171: URL: https://github.com/apache/flink/pull/25171#discussion_r1711482347 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/batch/MatchRecognizeBatchRestoreTest.java: ## @@ -0,0 +1,45 @@ +/* + * Lic

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-08-09 Thread via GitHub
twalthr commented on code in PR #25171: URL: https://github.com/apache/flink/pull/25171#discussion_r1710993068 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/batch/MatchRecognizeBatchRestoreTest.java: ## @@ -0,0 +1,45 @@ +/* + * L

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-08-08 Thread via GitHub
jnh5y commented on code in PR #25171: URL: https://github.com/apache/flink/pull/25171#discussion_r1709560780 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/batch/MatchRecognizeBatchRestoreTest.java: ## @@ -0,0 +1,46 @@ +/* + * Lic

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-08-08 Thread via GitHub
snuyanzin commented on code in PR #25171: URL: https://github.com/apache/flink/pull/25171#discussion_r1708923277 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/batch/MatchRecognizeBatchRestoreTest.java: ## @@ -0,0 +1,46 @@ +/* + *

Re: [PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-08-07 Thread via GitHub
flinkbot commented on PR #25171: URL: https://github.com/apache/flink/pull/25171#issuecomment-2274408966 ## CI report: * 5689c2b9d1352c5bd9655f1df817bffc6d4b4876 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36002] Add CompiledPlan annotations to BatchExecMatch [flink]

2024-08-07 Thread via GitHub
jnh5y opened a new pull request, #25171: URL: https://github.com/apache/flink/pull/25171 ## What is the purpose of the change * Adds Compiled Plan annotations to BatchExecMatch. * Tests the new annotations with the existing TestPrograms. ## Verifying this change This c