dawidwys commented on code in PR #25171:
URL: https://github.com/apache/flink/pull/25171#discussion_r1814809608
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/MatchRecognizeTestPrograms.java:
##########
@@ -121,6 +122,27 @@ public class MatchRecognizeTestPrograms {
.build();
static final Row[] BEFORE_DATA = {
+ Row.of("2020-10-10 00:00:01", 9, 1),
+ Row.of("2020-10-10 00:00:01", 8, 2),
+ Row.of("2020-10-10 00:00:01", 10, 3),
+ Row.of("2020-10-10 00:00:04", 7, 4),
+ Row.of("2020-10-10 00:00:06", 5, 6),
+ Row.of("2020-10-10 00:00:07", 8, 5),
+ Row.of("2020-10-10 00:00:12", 3, 7),
+ Row.of("2020-10-10 00:00:16", 4, 9),
+ Row.of("2020-10-10 00:00:32", 7, 10),
+ Row.of("2020-10-10 00:00:33", 9, 12),
+ Row.of("2020-10-10 00:00:34", 5, 11)
+ };
+
+ static final Row[] AFTER_DATA = {
+ Row.of("2020-10-10 00:00:41", 3, 13),
+ Row.of("2020-10-10 00:00:42", 11, 16),
+ Row.of("2020-10-10 00:00:43", 12, 15),
+ Row.of("2020-10-10 00:00:44", 13, 14)
+ };
+
+ static final Row[] BEFORE_DATA_WITH_OUT_OF_ORDER_DATA = {
Review Comment:
why default scope?
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/MatchRecognizeTestPrograms.java:
##########
@@ -181,6 +203,47 @@ public class MatchRecognizeTestPrograms {
.runSql(getEventTimeSql("ORDER BY rowtime, sequence_num"))
.build();
+ static final SourceTestStep SOURCE_WITH_OUT_OF_ORDER_DATA =
Review Comment:
Why is this in the default scope? Can't it be `private` if `public` is not
necessary?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecMatch.java:
##########
@@ -86,7 +89,8 @@ public abstract class CommonExecMatch extends
ExecNodeBase<RowData>
public static final String MATCH_TRANSFORMATION = "match";
- private final MatchSpec matchSpec;
+ @JsonProperty(FIELD_NAME_MATCH_SPEC)
Review Comment:
Could you please also deduplicate the field from `StreamExecMatch` since
you're touching this anyhow. I don't think it's necessary to be a separate
field in `StreamExecMatch`.
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/MatchRecognizeTestPrograms.java:
##########
@@ -121,6 +122,27 @@ public class MatchRecognizeTestPrograms {
.build();
static final Row[] BEFORE_DATA = {
+ Row.of("2020-10-10 00:00:01", 9, 1),
+ Row.of("2020-10-10 00:00:01", 8, 2),
+ Row.of("2020-10-10 00:00:01", 10, 3),
+ Row.of("2020-10-10 00:00:04", 7, 4),
+ Row.of("2020-10-10 00:00:06", 5, 6),
+ Row.of("2020-10-10 00:00:07", 8, 5),
+ Row.of("2020-10-10 00:00:12", 3, 7),
+ Row.of("2020-10-10 00:00:16", 4, 9),
+ Row.of("2020-10-10 00:00:32", 7, 10),
+ Row.of("2020-10-10 00:00:33", 9, 12),
+ Row.of("2020-10-10 00:00:34", 5, 11)
+ };
+
+ static final Row[] AFTER_DATA = {
Review Comment:
why default scope?
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/MatchRecognizeTestPrograms.java:
##########
@@ -136,7 +158,7 @@ public class MatchRecognizeTestPrograms {
Row.of("2020-10-10 00:00:34", 5, 11)
};
- static final Row[] AFTER_DATA = {
+ static final Row[] AFTER_DATA_WITH_OUT_OF_ORDER_DATA = {
Review Comment:
why default scope?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecMatch.java:
##########
@@ -86,7 +89,8 @@ public abstract class CommonExecMatch extends
ExecNodeBase<RowData>
public static final String MATCH_TRANSFORMATION = "match";
- private final MatchSpec matchSpec;
+ @JsonProperty(FIELD_NAME_MATCH_SPEC)
Review Comment:
This introduces circular dependency. You use a constant from a child class
that you use in the parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
