wuchong merged PR #25112:
URL: https://github.com/apache/flink/pull/25112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apach
wuchong commented on PR #25112:
URL: https://github.com/apache/flink/pull/25112#issuecomment-2272476258
Martijn is away on vacation. I will merge this PR first. We can revisit it
if there is any concerns.
--
This is an automated message from the Apache Git Service.
To respond to the mess
wuchong commented on PR #25112:
URL: https://github.com/apache/flink/pull/25112#issuecomment-2265359276
Hi @MartijnVisser , This is mainly for shading protobuf dependency in SQL
format jars (ORC, protobuf) and flink-python. They are all not in the default
distribution. So no changes in Flin
zhuanshenbsj1 commented on PR #25112:
URL: https://github.com/apache/flink/pull/25112#issuecomment-2264822929
> Thanks for the contribution. I left 2 minor comments.
Done~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wuchong commented on code in PR #25112:
URL: https://github.com/apache/flink/pull/25112#discussion_r1700380752
##
flink-formats/flink-sql-orc/pom.xml:
##
@@ -70,6 +70,12 @@ under the License.
com.google.pro
zhuanshenbsj1 commented on PR #25112:
URL: https://github.com/apache/flink/pull/25112#issuecomment-2244784197
> Which part of the Flink runtime/system relies on Protobuf, that would
justify shading Protobuf?
This is mainly to avoid the dependency conflict between the protobuf used in
flinkbot commented on PR #25112:
URL: https://github.com/apache/flink/pull/25112#issuecomment-2244623653
## CI report:
* 8a98ca6989b8a1192f72c4d0fd58529e99f9bfd5 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
zhuanshenbsj1 opened a new pull request, #25112:
URL: https://github.com/apache/flink/pull/25112
## What is the purpose of the change
Shade the classes in protobuf to avoid class conflict.
## Brief change log
*(for example:)*
- *The TaskInfo is stored in
