wuchong commented on code in PR #25112:
URL: https://github.com/apache/flink/pull/25112#discussion_r1700380752
##########
flink-formats/flink-sql-orc/pom.xml:
##########
@@ -70,6 +70,12 @@ under the License.
<include>com.google.protobuf:protobuf-java</include>
</includes>
</artifactSet>
+ <relocations>
+ <relocation>
+
<pattern>com.google.protobuf</pattern>
+
<shadedPattern>org.apache.flink.shaded.com.google.protobuf</shadedPattern>
Review Comment:
relocate to this path to avoid conflict with other modules:
`org.apache.flink.orc.shaded.com.google.protobuf`
##########
flink-formats/flink-sql-protobuf/pom.xml:
##########
@@ -65,6 +65,12 @@ under the License.
<include>com.google.protobuf:protobuf-java</include>
</includes>
</artifactSet>
+ <relocations>
+ <relocation>
+
<pattern>com.google.protobuf</pattern>
+
<shadedPattern>org.apache.flink.shaded.com.google.protobuf</shadedPattern>
Review Comment:
relocate to this path to avoid conflict with other modules:
`org.apache.flink.formats.protobuf.shaded.com.google.protobuf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
