dawidwys closed pull request #25022: [FLINK-35755] Upgrade to flink-shaded 19.0
URL: https://github.com/apache/flink/pull/25022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dawidwys commented on code in PR #25022:
URL: https://github.com/apache/flink/pull/25022#discussion_r1665471695
##
flink-dist/pom.xml:
##
@@ -52,6 +52,40 @@ under the License.
flink-core
${project.version}
$
snuyanzin commented on code in PR #25022:
URL: https://github.com/apache/flink/pull/25022#discussion_r1665468794
##
flink-dist/pom.xml:
##
@@ -52,6 +52,40 @@ under the License.
flink-core
${project.version}
snuyanzin commented on PR #25022:
URL: https://github.com/apache/flink/pull/25022#issuecomment-2208531580
Thanks for driving this
In general it looks ok from my side
Do you think it would make sense to add a checkstyle rule forbidding usage
of `jsonpath` in imports?
Like it is a
flinkbot commented on PR #25022:
URL: https://github.com/apache/flink/pull/25022#issuecomment-2208472352
## CI report:
* 47b66d5748f0144513b02666adbce21aeb7e02f0 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
dawidwys commented on code in PR #25022:
URL: https://github.com/apache/flink/pull/25022#discussion_r1665384093
##
flink-table/flink-table-planner/pom.xml:
##
@@ -353,19 +353,6 @@ under the License.
org.checkerframework
dawidwys commented on code in PR #25022:
URL: https://github.com/apache/flink/pull/25022#discussion_r1665381479
##
flink-dist/pom.xml:
##
@@ -52,6 +52,40 @@ under the License.
flink-core
${project.version}
$
dawidwys opened a new pull request, #25022:
URL: https://github.com/apache/flink/pull/25022
## What is the purpose of the change
Upgrade flink-shaded version
## Brief change log
* Upgraded flink-shaded to 18.0 and then 19.0
* adapted the code to updated guava version
