Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-28 Thread via GitHub
Zakelly merged PR #25253: URL: https://github.com/apache/flink/pull/25253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-28 Thread via GitHub
mayuehappy commented on code in PR #25253: URL: https://github.com/apache/flink/pull/25253#discussion_r1735514453 ## flink-end-to-end-tests/test-scripts/common.sh: ## @@ -296,7 +296,7 @@ function relocate_rocksdb_logs { # After FLINK-24785, RocksDB's log would be created unde

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-28 Thread via GitHub
mayuehappy commented on code in PR #25253: URL: https://github.com/apache/flink/pull/25253#discussion_r1734574904 ## flink-end-to-end-tests/test-scripts/common.sh: ## @@ -296,7 +296,7 @@ function relocate_rocksdb_logs { # After FLINK-24785, RocksDB's log would be created unde

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-28 Thread via GitHub
Zakelly commented on code in PR #25253: URL: https://github.com/apache/flink/pull/25253#discussion_r1734569350 ## flink-end-to-end-tests/test-scripts/common.sh: ## @@ -296,7 +296,7 @@ function relocate_rocksdb_logs { # After FLINK-24785, RocksDB's log would be created under F

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-28 Thread via GitHub
mayuehappy commented on code in PR #25253: URL: https://github.com/apache/flink/pull/25253#discussion_r1734556704 ## flink-end-to-end-tests/test-scripts/common.sh: ## @@ -296,7 +296,7 @@ function relocate_rocksdb_logs { # After FLINK-24785, RocksDB's log would be created unde

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-28 Thread via GitHub
Zakelly commented on code in PR #25253: URL: https://github.com/apache/flink/pull/25253#discussion_r1734490350 ## flink-end-to-end-tests/test-scripts/common.sh: ## @@ -296,7 +296,7 @@ function relocate_rocksdb_logs { # After FLINK-24785, RocksDB's log would be created under F

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-28 Thread via GitHub
mayuehappy commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2314642891 @Zakelly the CI can pass now , I've two minor changes , please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-27 Thread via GitHub
mayuehappy commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2314121275 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-27 Thread via GitHub
mayuehappy commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2312392245 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-27 Thread via GitHub
mayuehappy commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2311939990 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-27 Thread via GitHub
mayuehappy commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2311939034 > Caused by: org.rocksdb.RocksDBException: `/dev/null' exists but is not a directory This is because when run e2e test, the directory of rocksdb log will be specified as` /d

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-26 Thread via GitHub
mayuehappy commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2310121356 `RocksDBResourceContainerTest.testGetColumnFamilyOptionsWithPartitionedIndex` failed because RocksDB-V8.10.0 Overrided the `equals()` of `org.rocksdb.BloomFilter` .In RocksDBResourceC

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-26 Thread via GitHub
mayuehappy commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2310071852 > Is the CI failure related with compilation or release of the frocksdb? @Zakelly The compilation looks fine There are two main reasons why CI has failed The error message f

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-26 Thread via GitHub
Zakelly commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2309808133 Is the CI failure related with compilation or release of the frocksdb? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-25 Thread via GitHub
mayuehappy commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2309420675 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-25 Thread via GitHub
flinkbot commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2309236263 ## CI report: * df3cd8e4998d6289622c426e94c52023e15b75a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-25 Thread via GitHub
mayuehappy opened a new pull request, #25253: URL: https://github.com/apache/flink/pull/25253 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them