mayuehappy commented on code in PR #25253:
URL: https://github.com/apache/flink/pull/25253#discussion_r1734574904


##########
flink-end-to-end-tests/test-scripts/common.sh:
##########
@@ -296,7 +296,7 @@ function relocate_rocksdb_logs {
   # After FLINK-24785, RocksDB's log would be created under Flink's log 
directory by default,
   # this would make e2e tests' artifacts containing too many log files.
   # As RocksDB's log would not help much in e2e tests, move the location back 
to its own folder.
-  set_config_key "state.backend.rocksdb.log.dir" "/dev/null"
+  set_config_key "state.backend.rocksdb.log.dir" "/tmp"

Review Comment:
   > But it still creates the log file, right? So `/tmp` will still accumulate 
trash log files. How about setting log level to `header` and keeping them in 
Flink's log directory?
   
   yeah, that's what I mean ! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to