reswqa merged PR #24544:
URL: https://github.com/apache/flink/pull/24544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
kumar-mallikarjuna commented on PR #24544:
URL: https://github.com/apache/flink/pull/24544#issuecomment-2154197332
Thanks @reswqa !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
reswqa commented on PR #24544:
URL: https://github.com/apache/flink/pull/24544#issuecomment-2153744857
Sorry for the delay, I shall merge this after CI green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
kumar-mallikarjuna commented on PR #24544:
URL: https://github.com/apache/flink/pull/24544#issuecomment-2139268835
Done, @reswqa .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
reswqa commented on PR #24544:
URL: https://github.com/apache/flink/pull/24544#issuecomment-2138670012
@kumar-mallikarjuna Thanks for the rebase, could you squash these to some
meaningful commits? I will merge this PR then.
--
This is an automated message from the Apache Git Service.
To r
kumar-mallikarjuna commented on PR #24544:
URL: https://github.com/apache/flink/pull/24544#issuecomment-2132834467
Hi @reswqa , I've rebased the branch. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
X-czh commented on PR #24544:
URL: https://github.com/apache/flink/pull/24544#issuecomment-2044854644
Pinging @FangYongs and @reswqa. Could you help take a look when you have
time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
kumar-mallikarjuna commented on PR #24544:
URL: https://github.com/apache/flink/pull/24544#issuecomment-2028078573
@X-czh , thanks for reviewing. I've updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kumar-mallikarjuna commented on code in PR #24544:
URL: https://github.com/apache/flink/pull/24544#discussion_r1545380588
##
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfigImpl.java:
##
@@ -574,4 +575,31 @@ private void registerTypeWithTypeInf
kumar-mallikarjuna commented on code in PR #24544:
URL: https://github.com/apache/flink/pull/24544#discussion_r1545380588
##
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfigImpl.java:
##
@@ -574,4 +575,31 @@ private void registerTypeWithTypeInf
X-czh commented on PR #24544:
URL: https://github.com/apache/flink/pull/24544#issuecomment-2025118034
@kumar-mallikarjuna Thanks for the contribution. LGTM except for two minor
comments, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
X-czh commented on code in PR #24544:
URL: https://github.com/apache/flink/pull/24544#discussion_r1542914373
##
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfigImpl.java:
##
@@ -574,4 +575,31 @@ private void registerTypeWithTypeInfoFactory(
X-czh commented on code in PR #24544:
URL: https://github.com/apache/flink/pull/24544#discussion_r1542824003
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DataTypeFactoryImpl.java:
##
@@ -132,49 +131,12 @@ public LogicalType createLogicalType(U
flinkbot commented on PR #24544:
URL: https://github.com/apache/flink/pull/24544#issuecomment-2009531400
## CI report:
* 3d3ca469055b60fe00261751c3cb86c988c7c7bf UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
kumar-mallikarjuna opened a new pull request, #24544:
URL: https://github.com/apache/flink/pull/24544
## What is the purpose of the change
`org.apache.flink.table.catalog.DataTypeFactoryImpl#createSerializerConfig`
is currently manually making a copy of a `SerializerConfig` ob
15 matches
Mail list logo
