Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-11 Thread via GitHub
dawidwys merged PR #24020: URL: https://github.com/apache/flink/pull/24020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-10 Thread via GitHub
bvarghese1 commented on code in PR #24020: URL: https://github.com/apache/flink/pull/24020#discussion_r1447722550 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TableSourceScanTestPrograms.java: ## @@ -0,0 +1,259 @@ +/* + *

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-10 Thread via GitHub
bvarghese1 commented on code in PR #24020: URL: https://github.com/apache/flink/pull/24020#discussion_r1447721761 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableTestProgram.java: ## @@ -198,6 +198,18 @@ public SqlTestStep getRunSqlTest

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-10 Thread via GitHub
dawidwys commented on code in PR #24020: URL: https://github.com/apache/flink/pull/24020#discussion_r1447295113 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableTestProgram.java: ## @@ -198,6 +198,18 @@ public SqlTestStep getRunSqlTestSt

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-09 Thread via GitHub
bvarghese1 commented on PR #24020: URL: https://github.com/apache/flink/pull/24020#issuecomment-1883622718 > From very quick skimming... I looked at `SourceAbilitySpec`, and it looks like this test ought to help cover the `JsonSubTypes` there. > > I think I see the following readily:

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-04 Thread via GitHub
bvarghese1 commented on code in PR #24020: URL: https://github.com/apache/flink/pull/24020#discussion_r1442091512 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableTestProgram.java: ## @@ -198,6 +198,18 @@ public SqlTestStep getRunSqlTest

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-04 Thread via GitHub
jnh5y commented on PR #24020: URL: https://github.com/apache/flink/pull/24020#issuecomment-1877525393 From very quick skimming... I looked at `SourceAbilitySpec`, and it looks like this test ought to help cover the `JsonSubTypes` there. I think I see the following readily: ```

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-04 Thread via GitHub
jnh5y commented on code in PR #24020: URL: https://github.com/apache/flink/pull/24020#discussion_r1442077875 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableTestProgram.java: ## @@ -198,6 +198,18 @@ public SqlTestStep getRunSqlTestStep(

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-02 Thread via GitHub
flinkbot commented on PR #24020: URL: https://github.com/apache/flink/pull/24020#issuecomment-1874824806 ## CI report: * 32e25c7d0a6c58dc23ae28437f7159bf449bdce1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-02 Thread via GitHub
bvarghese1 opened a new pull request, #24020: URL: https://github.com/apache/flink/pull/24020 ## What is the purpose of the change *Add restore tests for TableSourceScan node* ## Verifying this change This change added tests and can be verified as follows: