jnh5y commented on PR #24020:
URL: https://github.com/apache/flink/pull/24020#issuecomment-1877525393

   From very quick skimming... I looked at `SourceAbilitySpec`, and it looks 
like this test ought to help cover the `JsonSubTypes` there.  
   
   I think I see the following readily:
   ```
   ProjectPushDownSpec
   FilterPushDownSpec
   LimitPushDownSpec
   PartitionPushDownSpec
   ReadingMetadataSpec
   WatermarkPushDownSpec
   ```
   
   Is there coverage for the other two?
   ```
   SourceWatermarkSpec
   AggregatePushDownSpec
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to