Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-13 Thread via GitHub
hlteoh37 merged PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-13 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2348323175 @hlteoh37 all non-test classes are now annotated with either `@PublicEvolving` or `@Internal`. All .java, .xml, and .properties file have the Apache 2.0 license header.

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757533937 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteRetryStrategy.java: ## @@ -0,0 +1,129 @@ +/* + *

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757533031 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteResponseClassifier.java: ## @@ -0,0 +1,38 @@ +/* +

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757531627 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkException.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757532715 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/RequestEntrySizeUtils.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757532179 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Lice

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757531446 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkConfiguration.java: ## @@ -0,0 +1,165 @@ +package or

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757530475 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkConfiguration.java: ## @@ -0,0 +1,165 @@ +package or

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757530223 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkBuilder.java: ## @@ -0,0 +1,241 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757529466 ## flink-connector-prometheus-request-signer-amp/src/test/java/org/apache/flink/connector/prometheus/sink/aws/RequestHeaderTestUtil.java: ## @@ -0,0 +1,2

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757529253 ## flink-connector-prometheus-request-signer-amp/src/test/java/org/apache/flink/connector/prometheus/sink/aws/DummAwsSessionCredentialProvider.java: ## @

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757528729 ## flink-connector-prometheus-request-signer-amp/src/test/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerForAMPTest.java: ## @@ -0,0 +1,73

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757527855 ## flink-connector-prometheus-request-signer-amp/src/test/java/org/apache/flink/connector/prometheus/sink/aws/RequestHeaderTestUtil.java: ## @@ -0,0 +1,2

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757526897 ## flink-connector-prometheus/README.md: ## @@ -0,0 +1,259 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector fo

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757525987 ## flink-connector-prometheus-request-signer-amp/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSigner.java: ###

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757525787 ## flink-connector-prometheus-request-signer-amp/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerForAMP.java: ## @@ -0,0 +1,347 @@

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757525575 ## flink-connector-prometheus-request-signer-amp/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerForAMP.java: ## @@ -0,0 +1,347 @@

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757525231 ## flink-connector-prometheus-request-signer-amp/src/test/java/org/apache/flink/connector/prometheus/sink/aws/DummAwsSessionCredentialProvider.java: ## @

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2346741773 @hlteoh37 I should have addressed all comments. The configuration classes have been moved into a top-level `PrometheusSinkConfiguration` class -- This is an automated m

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1756601045 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeriesLabelsAndMetricNameKeySelector.java: ## @@ -0,0

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-12 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1756591395 ## flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkBuilder.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed t

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1755375741 ## flink-connector-prometheus/README.md: ## @@ -0,0 +1,260 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector for

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-11 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2344434793 @hlteoh37 I addressed all remaining comments above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1755176342 ## flink-connector-prometheus/README.md: ## @@ -0,0 +1,260 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector for

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-11 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1754639229 ## flink-connector-prometheus/README.md: ## @@ -0,0 +1,260 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector fo

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-09-10 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1751692587 ## flink-connector-prometheus-request-signer-amp/README.md: ## @@ -0,0 +1,30 @@ +## Request Signer for Amazon Managed Prometheus (AMP) + +Request signer

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-10 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2159216321 I moved the example application under tests and removed the separate module completely. I added links to the example application in the README. -- This is an automated m

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-10 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1633781977 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at [https://

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-10 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632777604 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at [https:

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-09 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2156438875 Addressed the latest comments and ported AMP signer to AWS SDKv2 (!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-09 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632187848 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at [https://

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-09 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632194796 ## amp-request-signer/README.md: ## @@ -0,0 +1,31 @@ +## Request Signer for Amazon Managed Prometheus (AMP) + +Request signer implementation for Amazon Man

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-09 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632194645 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at [https://

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-09 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632188645 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at [https://

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-08 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632187848 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at [https://

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-15 Thread via GitHub
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1600156895 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at [https:

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2106039721 I addressed all comments, except those I explained why I didn't. Also, now upgraded to Flink 1.18 and newer AsyncSinkBase API. I cannot split AMP signer and connector

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597510944 ## amp-request-signer/pom.xml: ## @@ -0,0 +1,58 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597510275 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteRetryStrategy.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597508286 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597505926 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597488570 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597488524 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597488453 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597486440 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusRemoteWriteHttpRequestBuilder.java: ## @@ -0,0 +1,76 @@ +/* + *

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597482298 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeries.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597479531 ## prometheus-connector/src/test/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializerTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597479280 ## msf-amp-example/README.md: ## @@ -0,0 +1,68 @@ +## Sample application: Amazon Managed Service for Apache Flink and Amazon Managed Prometheus Review Co

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597478707 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/prometheus/Remote.java: ## @@ -0,0 +1,6661 @@ +/* Review Comment: I th

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597475338 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerForAuthorizationHeader.java: ## @@ -0,0 +1,124 @@ +/* + * Lic

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597473538 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSink.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597458387 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/HttpResponseCallback.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597456357 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/HttpResponseCallback.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597414330 ## prometheus-connector/README.md: ## @@ -0,0 +1,189 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector for DataSt

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597412742 ## prometheus-connector/README.md: ## @@ -0,0 +1,189 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector for DataSt

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597412465 ## prometheus-connector/README.md: ## @@ -0,0 +1,189 @@ +## Flink Prometheus connector (sink) + +Implementation of the Prometheus sink connector for DataSt

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597412205 ## pom.xml: ## @@ -0,0 +1,120 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:sc

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-05-11 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1597410882 ## pom.xml: ## @@ -0,0 +1,120 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:sc

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501906772 ## amp-request-signer/pom.xml: ## @@ -0,0 +1,58 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501905941 ## amp-request-signer/pom.xml: ## @@ -0,0 +1,58 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501905509 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501904332 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteRetryStrategy.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501904332 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteRetryStrategy.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501903943 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/RemoteWriteRetryStrategy.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501903310 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501903046 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501903046 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501902624 ## prometheus-connector/src/test/java/org/apache/flink/connector/prometheus/sink/HttpResponseHandlingBehaviourIT.java: ## @@ -0,0 +1,304 @@ +/* + * License

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501901973 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/PrometheusAsyncHttpClientBuilder.java: ## @@ -0,0 +1,92 @@ +/* + * Li

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501901955 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/http/PrometheusAsyncHttpClientBuilder.java: ## @@ -0,0 +1,92 @@ +/* + * Li

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501900684 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/SinkMetrics.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501900305 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/RequestEntrySizeUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501898533 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897750 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to t

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897657 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to t

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897616 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializer.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to t

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897480 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java: ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501897234 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkBuilder.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501896859 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusRemoteWriteHttpRequestBuilder.java: ## @@ -0,0 +1,76 @@ +/* + *

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501896202 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkBuilder.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-25 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1501895815 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusRemoteWriteHttpRequestBuilder.java: ## @@ -0,0 +1,76 @@ +/* + *

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-15 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1489284689 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-1944280510 @hlteoh37 @z3d1k please have a look, I pushes the changes (in a single squashed commit). I implemented all the requested changes except those I explicitly commented not to

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1489791182 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSigner.java: ## @@ -0,0 +1,98 @@ +/*

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1489284689 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1489268899 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSigner.java: ## @@ -0,0 +1,98 @@ +/*

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1489187810 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSigner.java: ## @@ -0,0 +1,98 @@ +/*

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-14 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1489092917 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AWS4SignerBase.java: ## @@ -0,0 +1,290 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488432583 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeries.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488419176 ## prometheus-connector/src/test/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializerTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488419176 ## prometheus-connector/src/test/java/org/apache/flink/connector/prometheus/sink/PrometheusStateSerializerTest.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488409080 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/RequestEntrySizeUtils.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488374236 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeries.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1488349352 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusTimeSeries.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1487904426 ## example-datastream-job/src/main/java/org/apache/flink/connector/prometheus/examples/DataStreamJob.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-13 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1487883477 ## example-datastream-job/src/main/java/org/apache/flink/connector/prometheus/examples/DataStreamJob.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-12 Thread via GitHub
z3d1k commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1486713717 ## amp-request-signer/src/main/java/org/apache/flink/connector/prometheus/sink/aws/AmazonManagedPrometheusWriteRequestSigner.java: ## @@ -0,0 +1,98 @@ +/* +

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-12 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1486607342 ## example-datastream-job/README.md: ## @@ -0,0 +1,22 @@ +## Example job using Prometheus Sink connector with DataStream API + +Sample application demonst

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-12 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1486605618 ## example-datastream-job/pom.xml: ## @@ -0,0 +1,156 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-inst

  1   2   >