hlteoh37 commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1757531446
##########
flink-connector-prometheus/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkConfiguration.java:
##########
@@ -0,0 +1,165 @@
+package org.apache.flink.connector.prometheus.sink;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.io.Serializable;
+import java.util.Optional;
+
+import static
org.apache.flink.connector.prometheus.sink.PrometheusSinkConfiguration.OnErrorBehavior.FAIL;
+
+/** This class contains configuration classes for different components of the
Prometheus sink. */
+@PublicEvolving
+public class PrometheusSinkConfiguration {
+
+ /**
+ * Defines the behaviour when an error is encountered: discard the
offending request and
+ * continue, or fail, throwing an exception.
+ */
+ public enum OnErrorBehavior {
+ DISCARD_AND_CONTINUE,
+ FAIL
+ }
+
+ /**
+ * Configure the error-handling behavior of the writer, for different
types of error. Also
+ * defines default behaviors.
+ */
+ public static class SinkWriterErrorHandlingBehaviorConfiguration
implements Serializable {
Review Comment:
We'll have to annotate every class in this file with `@PublicEvolving`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
