Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-13 Thread via GitHub
masteryhx closed pull request #24418: [FLINK-32076][checkpoint] Introduce file pool to reuse files URL: https://github.com/apache/flink/pull/24418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
masteryhx commented on PR #24418: URL: https://github.com/apache/flink/pull/24418#issuecomment-1993656300 The failed case caused by [FLINK-34660](https://issues.apache.org/jira/browse/FLINK-34660) which is not related to this PR. I also submitted a pr to resolved this. -- This is an a

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
masteryhx commented on PR #24418: URL: https://github.com/apache/flink/pull/24418#issuecomment-1993258271 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
masteryhx commented on PR #24418: URL: https://github.com/apache/flink/pull/24418#issuecomment-1993089967 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
masteryhx commented on PR #24418: URL: https://github.com/apache/flink/pull/24418#issuecomment-1991306532 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
masteryhx commented on code in PR #24418: URL: https://github.com/apache/flink/pull/24418#discussion_r1521151391 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/BlockingPhysicalFilePool.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
fredia commented on code in PR #24418: URL: https://github.com/apache/flink/pull/24418#discussion_r1521110459 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/BlockingPhysicalFilePool.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
fredia commented on PR #24418: URL: https://github.com/apache/flink/pull/24418#issuecomment-1991138575 @masteryhx Thanks for the PR, I took a quick look and had some questions, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
fredia commented on code in PR #24418: URL: https://github.com/apache/flink/pull/24418#discussion_r1521110459 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/BlockingPhysicalFilePool.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-10 Thread via GitHub
masteryhx commented on PR #24418: URL: https://github.com/apache/flink/pull/24418#issuecomment-1987489513 The failed case is not related to this pr: [FLINK-29114](https://issues.apache.org/jira/browse/FLINK-29114) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-06 Thread via GitHub
masteryhx commented on code in PR #24418: URL: https://github.com/apache/flink/pull/24418#discussion_r1515376096 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/WithinCheckpointFileMergingSnapshotManager.java: ## @@ -41,12 +41,13 @@ public class Wi

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-04 Thread via GitHub
Zakelly commented on code in PR #24418: URL: https://github.com/apache/flink/pull/24418#discussion_r1510799597 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/WithinCheckpointFileMergingSnapshotManager.java: ## @@ -41,12 +41,13 @@ public class With

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-02-29 Thread via GitHub
flinkbot commented on PR #24418: URL: https://github.com/apache/flink/pull/24418#issuecomment-1972349443 ## CI report: * 61e97462d4566a1ae8f17ceb32e42f68f92631a6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-02-29 Thread via GitHub
masteryhx opened a new pull request, #24418: URL: https://github.com/apache/flink/pull/24418 ## What is the purpose of the change Add file pool for concurrent file reusing ## Brief change log - Introduce PhysicalFilePool and use it in FileMergingSnapshotMana