dawidwys merged PR #23612:
URL: https://github.com/apache/flink/pull/23612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1450130950
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licen
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1450129925
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowDatabases.java:
##
@@ -29,14 +33,64 @@
import java.util.Collections;
import java
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1449994298
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ *
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1448743070
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licen
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1448743070
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licen
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1448743070
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licen
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1447763299
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ *
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1447245781
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licen
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1446697164
##
docs/content.zh/docs/dev/table/sql/show.md:
##
@@ -507,10 +507,21 @@ SHOW CURRENT CATALOG
## SHOW DATABASES
```sql
-SHOW DATABASES
+SHOW DATABASES [ ( FROM
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1446691730
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -20,26 +20,108 @@
import org.apache.flin
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1446686365
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ *
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1445802917
##
docs/content.zh/docs/dev/table/sql/show.md:
##
@@ -507,10 +507,21 @@ SHOW CURRENT CATALOG
## SHOW DATABASES
```sql
-SHOW DATABASES
+SHOW DATABASES [ ( FROM | IN
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1445801186
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licen
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1445800246
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -20,26 +20,108 @@
import org.apache.flink.ann
jeyhunkarimov commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1882424567
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jeyhunkarimov commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1881965798
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1445041283
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ *
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1445041559
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -20,26 +20,108 @@
import org.apache.flin
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1445041283
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ *
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1444878651
##
docs/content.zh/docs/dev/table/sql/show.md:
##
@@ -507,10 +507,21 @@ SHOW CURRENT CATALOG
## SHOW DATABASES
```sql
-SHOW DATABASES
+SHOW DATABASES [ ( FROM
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r189301
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -20,26 +20,108 @@
import org.apache.flink.ann
dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r179091
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowDatabases.java:
##
@@ -29,14 +33,64 @@
import java.util.Collections;
import java
jnh5y commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1860558626
> Hi @jnh5y could you please check if your comments are addressed? Thanks!
Hi @jeyhunkarimov, sorry to be slow to look again. Things are looking good.
@dawidwys would you be willing
jnh5y commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1430168768
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed
jnh5y commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1430167319
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -20,26 +20,108 @@
import org.apache.flink.annota
jnh5y commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1430159052
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowDatabases.java:
##
@@ -29,14 +33,64 @@
import java.util.Collections;
import java.ut
jeyhunkarimov commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1859901892
Hi @jnh5y could you please check if your comments are addressed? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
jeyhunkarimov commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1831677479
Thanks for the comment @chucheng92 and thank you for the review @jnh5y .
I addressed your comments. Could you please check if you have any other
comments?
P.s I have ji
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1408807116
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,58 @@
+/*
+ *
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1408795264
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowDatabases.java:
##
@@ -29,14 +31,55 @@
import java.util.Collections;
import
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1408794421
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -20,26 +20,108 @@
import org.apache.flin
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1408794805
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -20,26 +20,108 @@
import org.apache.flin
chucheng92 commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1828958938
> This is looking pretty good. Since implementing FLIP-297 is assigned to
@chucheng92, we should get his input as well!
>
> @jeyhunkarimov have you signed up for the Flink JIRA?
jnh5y commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1828465094
This is looking pretty good. Since implementing FLIP-297 is assigned to
@chucheng92, we should get his input as well!
@jeyhunkarimov have you signed up for the Flink JIRA? You may n
jnh5y commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1406632513
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowDatabases.java:
##
@@ -29,14 +31,55 @@
import java.util.Collections;
import java.ut
jnh5y commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1406631017
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed
jnh5y commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1406630035
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -20,26 +20,108 @@
import org.apache.flink.annota
jnh5y commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1406627733
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##
@@ -20,26 +20,108 @@
import org.apache.flink.annota
jeyhunkarimov commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1819092658
Hi @jnh5y @dawidwys , could you guys check this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jeyhunkarimov commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1794335092
Hi @MartijnVisser could you please check this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
jeyhunkarimov commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1784015344
Hi @luoyuxia @chucheng92 could you please review the PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot commented on PR #23612:
URL: https://github.com/apache/flink/pull/23612#issuecomment-1783926004
## CI report:
* 20780e6cdb3a857980151ed51bcb8deafdfa06b1 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
jeyhunkarimov opened a new pull request, #23612:
URL: https://github.com/apache/flink/pull/23612
## What is the purpose of the change
Support enhanced show functions syntax described in
[FLIP-297](https://cwiki.apache.org/confluence/display/FLINK/FLIP-297%3A+Improve+Auxiliary+Sql+Stat
44 matches
Mail list logo
