dawidwys commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1445800246
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowDatabasesOperation.java:
##########
@@ -20,26 +20,108 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.table.api.internal.TableResultInternal;
+import org.apache.flink.table.functions.SqlLikeUtils;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static java.util.Objects.requireNonNull;
import static
org.apache.flink.table.api.internal.TableResultUtils.buildStringArrayResult;
/** Operation to describe a SHOW DATABASES statement. */
@Internal
public class ShowDatabasesOperation implements ShowOperation {
+ private final String preposition;
Review Comment:
I don't get the argumentation. Could you please elaborate? `asSummaryString`
prints a summary of the operation, I don't see why we need the exact same
preposition that was used. I could even see the summary as
`("ShowDatabases(catalog='abc', like='...', ....)`.
Even more I don't see a problem with unparsing to a different preposition as
long as the effect is the same. In the end it makes no difference at all which
one was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
