AHeise merged PR #25292:
URL: https://github.com/apache/flink/pull/25292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
AHeise commented on PR #25292:
URL: https://github.com/apache/flink/pull/25292#issuecomment-2356464478
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1763233550
##
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/stream/AbstractStreamingWriter.java:
##
@@ -149,15 +190,20 @@ public void p
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1763232011
##
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/stream/AbstractStreamingWriter.java:
##
@@ -123,6 +142,27 @@ public void bu
fapaul commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1763062367
##
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/stream/AbstractStreamingWriter.java:
##
@@ -123,6 +142,27 @@ public void bu
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1759079752
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##
@@ -208,8 +209,8 @@ public void
processElement(StreamRecord>
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1759078561
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##
@@ -156,23 +156,16 @@ public void endInput() throws Exception
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758998259
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##
@@ -156,23 +156,16 @@ public void endInput() throws Exception
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758906870
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java:
##
@@ -195,12 +231,15 @@ public void processWatermark(Watermark
AHeise commented on PR #25292:
URL: https://github.com/apache/flink/pull/25292#issuecomment-2349011518
I added the fixup commits inline. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758859753
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java:
##
@@ -178,7 +214,7 @@ public void processElement(StreamRecord
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758859370
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java:
##
@@ -160,13 +171,38 @@ public void initializeState(StateIniti
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758857878
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CheckpointCommittableManagerImpl.java:
##
@@ -147,15 +146,16 @@ Collection>
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758856122
##
flink-runtime/src/main/java/org/apache/flink/streaming/api/connector/sink2/CommittableMessageSerializer.java:
##
@@ -91,13 +90,13 @@ public CommittableMessage deseria
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758844552
##
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/compactor/operator/CompactorOperator.java:
##
@@ -138,15 +136,15 @@ public v
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758839320
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java:
##
@@ -195,12 +231,15 @@ public void processWatermark(Watermark
rkhachatryan commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758790201
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java:
##
@@ -195,12 +231,15 @@ public void processWatermark(Wat
fapaul commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1758462817
##
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/compactor/operator/CompactorOperator.java:
##
@@ -138,15 +136,15 @@ public v
AHeise commented on PR #25292:
URL: https://github.com/apache/flink/pull/25292#issuecomment-234577
I addressed your comments and took a different approach to state management
(it looks similar but is conceptually rather different).
I restructured the PR and added 2 more commits to
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1756488654
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java:
##
@@ -195,12 +216,18 @@ public void processWatermark(Watermark
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1756485743
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java:
##
@@ -195,12 +216,18 @@ public void processWatermark(Watermark
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1756482710
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java:
##
@@ -160,7 +169,19 @@ public void initializeState(StateInitia
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1756479346
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CheckpointCommittableManagerImpl.java:
##
@@ -72,18 +73,24 @@ Collection>
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1756475601
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##
@@ -156,23 +156,16 @@ public void endInput() throws Exception
AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1756452491
##
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##
@@ -208,8 +209,8 @@ public void
processElement(StreamRecord>
flinkbot commented on PR #25292:
URL: https://github.com/apache/flink/pull/25292#issuecomment-2331889938
## CI report:
* 0587c702d816f061854210ba6ba3c1aacd062b77 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
AHeise opened a new pull request, #25292:
URL: https://github.com/apache/flink/pull/25292
## What is the purpose of the change
[FLINK-25920]
In case of a failure after final checkpoint, EOI is called twice. SinkWriter
should ignore the second call to avoid emitting dupl
27 matches
Mail list logo
