AHeise commented on code in PR #25292: URL: https://github.com/apache/flink/pull/25292#discussion_r1758906870
########## flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/SinkWriterOperator.java: ########## @@ -195,12 +231,15 @@ public void processWatermark(Watermark mark) throws Exception { @Override public void endInput() throws Exception { - endOfInput = true; - sinkWriter.flush(true); - emitCommittables(Long.MAX_VALUE); + if (!endOfInput) { + endOfInput = true; Review Comment: I added the assertion. It can't hurt because we may have upstream operators that misbehave (custom operators). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org