Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/579#issuecomment-94698596
Great work Faye. Will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/579#issuecomment-94012543
Three minor comments. Otherwise it looks really good :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28605175
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,177 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28605215
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,177 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28605205
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,177 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/579#issuecomment-93954174
Hi Faye, the code looks much better now. I had only some minor comments.
What would be really awesome is to create some documentation for the
website. You can
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28580480
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/StandardScalerITSuite.scala
---
@@ -0,0 +1,154 @@
+/*
+ * Licen
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28580329
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28580943
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28580779
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28580607
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocessing/StandardScalerITSuite.scala
---
@@ -0,0 +1,154 @@
+/*
+ * Licen
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28412522
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28412479
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28412920
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28412288
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28412374
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28412749
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r28412028
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocessing/StandardScaler.scala
---
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/579#issuecomment-91286399
Maybe we could name the package ```org.apache.flink.ml.preprocessing```
instead of ```org.apache.flink.ml.preprocess```. What do you think?
If you include in
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/579#issuecomment-90936379
Hi Faye, I made some annotations. Ping me when you've addressed them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27975475
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocess/Standardizer.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the A
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27975352
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocess/Standardizer.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the A
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27974957
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocess/Standardizer.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the A
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27974938
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocess/Standardizer.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the A
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27974882
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocess/Standardizer.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the A
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27974561
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/preprocess/Standardizer.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the A
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973978
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27974019
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973958
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973935
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973910
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973879
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973815
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973786
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973695
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973680
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973639
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973555
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/579#discussion_r27973465
--- Diff:
flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/preprocess/StandardizerSuite.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to
GitHub user fobeligi opened a pull request:
https://github.com/apache/flink/pull/579
Ml branch
Implementation of StandardScaler and respective tests for FLINK-1809 JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fobeligi/in
41 matches
Mail list logo
