Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/579#issuecomment-93954174
Hi Faye, the code looks much better now. I had only some minor comments.
What would be really awesome is to create some documentation for the
website. You can look at flink/docs/ml/ to see how the other components are
documented. It's basically the scala doc of the class.
Another thing to think about is the way we use Breeze operators. At the
moment you have specified all operators with a preceding colon. This is
perfectly fine but I personally use it only where it's necessary. For example,
if you multiply a vector with a double you can also write ```vector *
double```. Of course this operation is also an element wise operation but IMHO
I think it's easier to parse a formula if you use the colon syntax only if both
operands are vectors. That way, another person can directly spot that this
operation is a element-wise vector vector multiplication. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
