[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2016-05-27 Thread fpompermaier
Github user fpompermaier commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-222177257 Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-15 Thread jamescao
Github user jamescao commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-140359144 @chiwanpark pr is now updated, I pull out code related to HCatInputFormat and incorporated Flink-2555 and Flink-2617. I also change the test environment to from `C

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-10 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-139178373 @jamescao good observation! The fix of # should be added to the HCatOutputFormatBase as well. There was another fix for HadoopIOFormats (FLINK-2555, PR #1038) th

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-139129112 @jamescao Yes, I think the part (including tests) related with `HCatInputFormat` should be removed. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread jamescao
Github user jamescao commented on the pull request: https://github.com/apache/flink/pull/1064#issuecomment-139085352 @twalthr : sorry I missed your message, this pr is reopened in https://github.com/apache/flink/pull/1079 I didn't check this closed page. I should have continued

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread jamescao
Github user jamescao commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-139079494 @chiwanpark Thanks for all you comments! I will fix them in subsequent commits. There is also a bug fix for HcatInputformat in this pr, do you think that part shoul

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-138890354 Hi @jamescao, I just reviewed your PR. There are some issues to merge. * `HcatInputOutputFormatITest.java` must use tab characters for indentation. * There

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39034189 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,216 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39034170 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,216 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39034081 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39034096 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39034063 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39034039 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033997 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033950 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033845 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033820 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033766 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,449 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033252 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,449 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033258 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,449 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033094 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,216 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033023 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,216 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39033011 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,216 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032912 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032886 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032786 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032807 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032801 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032770 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032738 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032747 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032671 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032608 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032562 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032533 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39032520 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,449 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39031945 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,449 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39031960 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,449 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39031981 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,449 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39031803 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,449 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39031065 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030949 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030988 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030971 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030957 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030975 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030982 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/java/HCatOutputFormat.java --- @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030888 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030898 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030797 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030785 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,301 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030716 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,216 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030649 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,216 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030601 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,216 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1079#discussion_r39030573 --- Diff: flink-staging/flink-hcatalog/src/test/java/org/apache/flink/hcatalog/java/test/HcatInputOutputFormatITest.java --- @@ -0,0 +1,383 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-09 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-138869203 Oh, sorry for late. I'm reviewing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-08 Thread jamescao
Github user jamescao commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-138640278 Any updates from the review process? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-09-02 Thread twalthr
Github user twalthr commented on the pull request: https://github.com/apache/flink/pull/1064#issuecomment-137080649 @jamescao: It seems that you also wrote tests for the HCatInputFormat, right? is it possible to split the PR into a OutputFormat part and open a separate PR for the HCat

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-31 Thread jamescao
Github user jamescao commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-136359875 @chiwanpark Yes, it's sure that the apache version of HCatalog is compiled against hadoop1. Using this jar in an hadoop2 environment will lead to binary incompatib

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-31 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1079#issuecomment-136284408 From [this JIRA](https://issues.apache.org/jira/browse/HIVE-4460), It seems that HCatalog are deployed with Hadoop 2. Is it sure that the vanila version of HCatalog i

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-30 Thread jamescao
GitHub user jamescao opened a pull request: https://github.com/apache/flink/pull/1079 [FLINK1919] add HCatOutputFormat [FLINK1919] Add `HCatOutputFormat` for Tuple data types for java and scala api also fix a bug for the scala api's `HCatInputFormat` for hive complex types.

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-28 Thread jamescao
Github user jamescao commented on the pull request: https://github.com/apache/flink/pull/1064#issuecomment-135925495 I need to work offline to debug the travis builds So close the pr for now. Thanks for all your time and comments! I will reopen once all the tests are fixed. --- If

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-28 Thread jamescao
Github user jamescao closed the pull request at: https://github.com/apache/flink/pull/1064 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread jamescao
Github user jamescao commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38163609 --- Diff: flink-staging/flink-hcatalog/pom.xml --- @@ -34,17 +34,64 @@ under the License. jar + + +

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread jamescao
Github user jamescao commented on the pull request: https://github.com/apache/flink/pull/1064#issuecomment-135400320 @chiwanpark @rmetzger Thanks for all your comment, I will work to improve it. The reason I have to use a cloudera pom is that the hcatalog jar in maven central is c

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/1064#issuecomment-135369221 Hi @jamescao, Thanks for your pull request! I reviewed roughly and will review more detail in few days. About the version of hcatalog release, it would be

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078885 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,215 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078601 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,215 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078553 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,215 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078508 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,215 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078523 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,215 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078475 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,215 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078462 --- Diff: flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala --- @@ -0,0 +1,215 @@ +/*

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078384 --- Diff: flink-staging/flink-hcatalog/pom.xml --- @@ -34,17 +34,64 @@ under the License. jar + + +

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078423 --- Diff: flink-staging/flink-hcatalog/pom.xml --- @@ -34,17 +34,64 @@ under the License. jar + + +

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078293 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,433 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078282 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,433 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078289 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,433 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078266 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,433 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078278 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,433 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38078242 --- Diff: flink-staging/flink-hcatalog/src/main/scala/org/apache/flink/hcatalog/scala/HCatOutputFormat.scala --- @@ -0,0 +1,433 @@ +/* + * License

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38077909 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38077826 --- Diff: flink-staging/flink-hcatalog/src/main/java/org/apache/flink/hcatalog/HCatOutputFormatBase.java --- @@ -0,0 +1,295 @@ +/* + * Licensed to

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38077697 --- Diff: flink-staging/flink-hcatalog/pom.xml --- @@ -34,17 +34,64 @@ under the License. jar + + +

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-27 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1064#discussion_r38077650 --- Diff: flink-staging/flink-hcatalog/pom.xml --- @@ -34,17 +34,64 @@ under the License. jar + + +

[GitHub] flink pull request: [FLINK1919] add HCatOutputFormat

2015-08-26 Thread jamescao
GitHub user jamescao opened a pull request: https://github.com/apache/flink/pull/1064 [FLINK1919] add HCatOutputFormat [FLINK1919] Add `HCatOutputFormat` for Tuple data types for java and scala api also fix a bug for the scala api's `HCatInputFormat` for hive complex types.