Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1079#issuecomment-138890354
Hi @jamescao, I just reviewed your PR. There are some issues to merge.
* `HcatInputOutputFormatITest.java` must use tab characters for indentation.
* There are some formatting issues which I commented.
* Some Scala codes doesn't seems Scala style.
As @twalthr said, I think also that we should split the current test cases
to test cases for `HCatInputFormat` and `HCatOutputFormat`. This issues and PR
should cover HCatalog output format. We can post another issue to JIRA and send
PR for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
