Github user qmlmoon closed the pull request at:
https://github.com/apache/flink/pull/248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-121208526
Something like "Using address XYZ. Configure via ABC." at startup and a
similar error messasge if connecting fails. You could also try to connect from
the remote host before
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-121203637
How would you give a good error message? It would manifest itself as the
fact that the TaskManagers cannot connect to the JobManager.
I would actually agree t
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-121195803
I've tested this with default EC2 and GCE instances, which by default
return the cloud internal hostname. I would say that this is a reasonable
configuration. If it is not co
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-121192404
Not sure right now.
All setups through YARN are not affected anyways. For standalone mode, do
we need it?
How reliable is this? What happens if you start
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-121183870
Yeah, I was also thinking about this.
This will result in a total of 4 combinations:
HA mode | JM address configured | JM address behaviour
-
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-121180165
Are we sure this helps, or will it add yet another way of configuring and
starting the cluster. Are we getting to the point that it becomes hard to
understand what ha
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-121178791
I waited to merge this, because of the recent ZooKeeper integration (to see
whether this would be affected by it or not). Turns out this change is
orthogonal, so I think we c
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-114042530
OK going to merge and adding the warning. Makes it more comfortable to run
a stand-alone cluster in the cloud. :) Thanks for the PR.
---
If your project is set up for it, yo
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-95990793
This will work for most use cases where the JobManager is started within
the same cluster as the TaskManagers. It will certainly fail if the JobManager
resides in a different
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-95981935
I've just checked EC2. The default AMIs all return the cloud internal
hostname, which is accessible (given the correct security setup). I count this
as an indicator that just
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-95586174
I've rebased this on the current master, added log messages when falling
back to the default address (which I've renamed as Till suggested), and tested
it.
There is o
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/248#discussion_r23611202
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -519,6 +519,12 @@ object JobManager {
c
Github user qmlmoon commented on a diff in the pull request:
https://github.com/apache/flink/pull/248#discussion_r23610509
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -519,6 +519,12 @@ object JobManager {
config
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/248#discussion_r23609808
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -519,6 +519,12 @@ object JobManager {
c
Github user qmlmoon commented on a diff in the pull request:
https://github.com/apache/flink/pull/248#discussion_r23607815
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -519,6 +519,12 @@ object JobManager {
config
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/248#discussion_r23607703
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -596,6 +596,10 @@ object TaskManager {
op
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/248#discussion_r23607635
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -611,6 +615,13 @@ object TaskManager {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/248#discussion_r23607471
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -519,6 +519,12 @@ object JobManager {
c
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-71647940
Great, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user qmlmoon commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-71645508
ok. I rebased the PR and modified it with scala implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/248#issuecomment-71493259
Mingliang could you rebase the PR on the latest master? In the meantime,
the codebase changed quite a bit.
---
If your project is set up for it, you can reply to thi
22 matches
Mail list logo
