Github user qmlmoon commented on a diff in the pull request:

    https://github.com/apache/flink/pull/248#discussion_r23610509
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
 ---
    @@ -519,6 +519,12 @@ object JobManager {
               configuration.setString(ConfigConstants.FLINK_BASE_DIR_PATH_KEY, 
config.configDir + "/..")
             }
     
    +        if 
(GlobalConfiguration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
    +          null) == null) {
    +          
configuration.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
    +            InetAddress.getLocalHost.getHostName)
    +        }
    +
             val hostname = 
configuration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY, null)
    --- End diff --
    
    In local mode, jobmanager will start an internal taskmanager and  call the 
`TaskManager.parseConfiguration`. For TaskManager, we can replace the null 
default value with the `config.defaultJobManagerAdd` but not the 
`InetAddress.getLocalHost.getHostName`. I think the question is whether we add 
an additional parameter to the `parseConfiguration` for the default jobmanager 
address or put this in the configuration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to