Github user aozturk commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-55574
That was my concern actually, Let's wait for it then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-55208
Okay, I've filed https://issues.apache.org/jira/browse/FLINK-3983. However,
before you jump onto it: While I wrote the JIRA, I was actually wondering
whether it makes s
Github user aozturk commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-55079
Repeated lines were terrible, it looks neater now. But it seems the if
checks for max count configurations in FlinkKinesisProducer.java are redundant
now.
Adding al
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-52000
I have to admit that these changes were not necessary:
https://github.com/apache/flink/commit/23d1cba72859339bd3ee8f877b031353380c87fb#diff-d34eb8418ccff3e2d59a3e660fed6
Github user aozturk commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-50998
Thanks for the merge! Your latest enhancements look great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-222136775
Thanks a lot for addressing the comments.
I'll push the changes to travis, once its green I'll merge them.
---
If your project is set up for it, you can reply to th
Github user aozturk commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-222111542
Pushed updates according to your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64767022
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -1
Github user aozturk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64757778
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -16
Github user aozturk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64756634
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -16
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-221885858
Sure, no problem at all. Its just for my own time allocation. Thanks for
the quick response.
---
If your project is set up for it, you can reply to this email and have
Github user aozturk commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-221885430
Sorry I have had an extra duty for this week, but I have already started
working on it and hope to wrap this evening.
---
If your project is set up for it, you can repl
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-221882616
Just for my planning, when do you think you'll find time to address the
remaining issues?
---
If your project is set up for it, you can reply to this email and have yo
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64257599
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -1
Github user aozturk commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64235578
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -16
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-220997800
The change looks good overall. I think we can soon merge it.
Please let me know once you've addressed my comments.
---
If your project is set up for it, you ca
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64231495
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -1
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64230633
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -3
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2016#discussion_r64227104
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
@@ -3
Github user aozturk commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-220988206
Sure. Thanks for the review @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-220986366
I noticed that you didn't update the documentation of the Kinesis Producer.
Can you update the page to reflect the changed usage.
The file is located here: docs/a
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2016#issuecomment-220782124
Thanks a lot for your contribution. I quickly scrolled over the changes and
I like them at first sight.
I assigned the JIRA issue to you. I hope I can review th
GitHub user aozturk opened a pull request:
https://github.com/apache/flink/pull/2016
[FLINK-3923] [connector-kinesis] Unify configuration conventions of tâ¦
This pull request includes the changes as clearly described in the issue.
[FLINK-3923] Unify configuration convention
24 matches
Mail list logo
