Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-171054949
Merging this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-170712317
@gallenvara, Then let's keep it like this. Thanks for the update. PR is
good to merge
---
If your project is set up for it, you can reply to this email and have your
re
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-170467184
@fhueske , i"m favor of showing the whole plan. First, `Table` API converts
`DataSet` to a `Table` and provides several operations on the `DataSource`.
It's a data-pr
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-169987537
I added two small comments in-line.
But there is another thing that came to my mind. A `Table` can be
constructed from any type of `DataSet` not just a `DataSource`.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r49183864
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/explain/PlanJsonParser.java
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r49183832
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/explain/PlanJsonParser.java
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to t
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-169967055
@ChengXiangLi @fhueske @rmetzger , thanks a lot for your suggestions. The
codes have been modified.
---
If your project is set up for it, you can reply to this emai
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r49161542
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/explain/PlanJsonParser.java
---
@@ -0,0 +1,142 @@
+/*
+ * Licensed
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r49161453
--- Diff: pom.xml ---
@@ -796,6 +796,7 @@ under the License.
flink-tests/src/test/resources/testdata/tera
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r49161417
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -94,6 +94,12 @@ under the License.
test
+
Github user ChengXiangLi commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r49161249
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/Table.scala
---
@@ -267,5 +271,24 @@ case class Table(private[flink] val o
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-169882956
@fhueske , @rmetzger , thanks for review work. I have modified related code
as you adviced and submitted a new commit.
---
If your project is set up for it, you can
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r49097137
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/parser/PlanJsonParser.java
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to th
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-169532718
@fhueske , codes has been finished. I have drop previous method of
plan-generator and rewrite a new parser named `PlanJsonParser` to parse the
existing JSON plan. Cou
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-169270202
Thanks @gallenvara.
Flink uses Jackson to handle JSON data. You can use it to parse the JSON
String.
Looking forward to your update :-)
---
If your projec
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-169261591
@fhueske ,thanks a lot for the review work! I'll modify the code and update
the PR according to your advice.
---
If your project is set up for it, you can reply to t
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1477#issuecomment-168736055
Hi @gallenvara, thanks for this PR!
Explain is a very nice feature for the Table API (and later on for the SQL
interface).
IMO, it would be better to reuse t
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r48752174
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/PlanExecutor.java ---
@@ -129,6 +129,8 @@ public boolean isPrintingStatusDuringExecution() {
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r48752078
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -828,6 +828,18 @@ public JobExecutionResult execute() throws Exc
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r48751756
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/RemoteEnvironment.java ---
@@ -1,271 +1,287 @@
-/*
- * Licensed to the Apache Software Fo
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r48751597
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/Table.scala
---
@@ -1,271 +1,291 @@
-/*
- * Licensed to the Apache Soft
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1477#discussion_r48751391
--- Diff: flink-staging/flink-scala-shell/pom.xml ---
@@ -76,6 +76,12 @@ under the License.
${scala.version}
GitHub user gallenvara opened a pull request:
https://github.com/apache/flink/pull/1477
[FLINK-3192] Add explain support to print ast and sql physical execution.
Table API doesn't support sql-explanation now. Add the explain support to
print ast (abstract syntax tree) and the physic
24 matches
Mail list logo
