Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-163264394
Manually merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-163221930
`preallocate` can be seen as one word, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-163192234
+1 from my side, after the switch to "preallocate"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-163194389
is `pre-allocate` also ok? btw, we have a wild mixture of option styles,
there is camelCase, under_score, and with-hyphens.
---
If your project is set up for it, you c
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-163177539
Any objections against me merging this now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-163187358
PR looks good. +1 for `taskmanager.memory.preallocate`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-163184597
Can do, yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-163184249
Looks good!
One thing that just came to my mind is whether we should call the config
flag "taskmanager.memory.preallocate" (default false).
I think
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-162846459
I also discovered some other stuff, for example, the off-heap memory usage
is not printed by the `MemoryLogger` (max is fixing this) and some stats in the
web fronted a
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-162846304
Any more comments?
The log messages now look like this:
```
11:28:58,212 INFO org.apache.flink.runtime.taskmanager.TaskManager
- Limiting
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-162469441
Did the changes to boolean option and merging of log messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-162464044
@StephanEwen So you want to merge the two messages @rmetzger posted? I'm on
it.
I'll also change the option to a boolean `lazy_alloc`, no need for the
String o
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-162334879
As followup to this, I would suggest two changes:
1. Adjust the log message, to reflect that not 0.7 are either used
immediately (eager allocation) or that t
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1433#issuecomment-162334401
Tested the change on a cluster with a job reading some 100GBs of data ...
looks good ..
```
19:07:19,537 INFO org.apache.flink.runtime.taskmanager.TaskM
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1433#discussion_r46563274
--- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
@@ -63,7 +57,7 @@ if [[ $STARTSTOP == "start" ]]; then
#
TM_MAX_OFFHEAP_SI
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1433#discussion_r46557510
--- Diff: docs/setup/cluster_setup.md ---
@@ -236,34 +236,18 @@ bin/start-cluster.sh
To stop Flink, there is also a `stop-cluster.sh` script.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1433#discussion_r46560453
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1617,7 +1598,16 @@ object TaskManager {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1433#discussion_r46558419
--- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
@@ -63,7 +57,7 @@ if [[ $STARTSTOP == "start" ]]; then
#
TM_MAX_OFFHEAP_SI
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1433#discussion_r46558585
--- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
@@ -63,7 +57,7 @@ if [[ $STARTSTOP == "start" ]]; then
#
TM_MAX_OFFHE
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1433#discussion_r46559041
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1617,7 +1598,16 @@ object TaskManager {
}
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1433#discussion_r46558633
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1617,7 +1598,16 @@ object TaskManager {
}
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1433#discussion_r46557639
--- Diff: docs/setup/cluster_setup.md ---
@@ -236,34 +236,18 @@ bin/start-cluster.sh
To stop Flink, there is also a `stop-cluster.sh` script.
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1433
[FLINK-3073] Replace Streaming Mode by Memory Allocation Mode
Before, streaming mode (either batch or streaming) would specify how
memory is allocated on task managers.
This introduces
24 matches
Mail list logo
