Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1433#discussion_r46563274
--- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
@@ -63,7 +57,7 @@ if [[ $STARTSTOP == "start" ]]; then
#
TM_MAX_OFFHEAP_SIZE="8388607T"
- if [[ "${STREAMINGMODE}" == "batch" ]] && useOffHeapMemory; then
+ if [[ "${FLINK_TM_MEM_ALLOC}" == "eager" ]] && useOffHeapMemory;
then
--- End diff --
You might want to allocate lazily in batch jobs with off-heap memory. In
the current state of the pull request, we could run into out of memory errors
then. On the other hand, I see that we don't want to subtract heap memory in
streaming with lazy memory allocation (because we don't allocate managed memory
for streaming jobs for now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
