Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156965181
Thanks for testing this so thoroughly. +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user nielsbasjes commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156952942
FYI: I let my test run over the weekend (i.e. for 65 hours) with the 5 & 10
minutes ticket times and it is still running fine.
---
If your project is set up for it,
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156423600
Amazing, thank you.
I'm going to merge you change as soon as Travis gives me green light ;)
I've squashed and rebased your commit and will push it probably as
ht
Github user nielsbasjes commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156423436
I redid my test to make sure it still all works as desired;
I had our IT guys drop the ticket expire time for my user account down to 5
minutes and the max r
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156388624
Thank you for addressing my concerns so quickly
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1342#discussion_r44767927
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -249,7 +249,15 @@ if [ -n "$HADOOP_HOME" ]; then
fi
fi
-INTERNAL_HADOOP_
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156387638
+1 thanks for improving it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user nielsbasjes commented on a diff in the pull request:
https://github.com/apache/flink/pull/1342#discussion_r44766715
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
@@ -135,7 +138,54 @@ public static void setTokensFor(ContainerLaunchContext
amCont
Github user nielsbasjes commented on a diff in the pull request:
https://github.com/apache/flink/pull/1342#discussion_r44765814
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -249,7 +249,15 @@ if [ -n "$HADOOP_HOME" ]; then
fi
fi
-INTERNAL_HADO
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156379250
I had some minor remarks to the PR, but overall, I'd like to merge it like
this!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1342#discussion_r44764893
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -249,7 +249,15 @@ if [ -n "$HADOOP_HOME" ]; then
fi
fi
-INTERNAL_HADOOP_
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1342#discussion_r44764797
--- Diff: pom.xml ---
@@ -82,6 +82,7 @@ under the License.
error
1.2.1
2.3.0
+ 1.1.2
--- En
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1342#discussion_r44764775
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
@@ -135,7 +138,54 @@ public static void setTokensFor(ContainerLaunchContext
amContain
Github user nielsbasjes commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156122982
Found it and fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nielsbasjes commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156117069
I made a mistake that the dependency was still in there 'hard'.
When I switch it to 'provided' or leave it out it fails with a
ClassNotFound ...
---
If your pr
Github user nielsbasjes commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156116370
I fixed the authentication to use reflection.
To make this work I had to switch back to an older (deprecated) version of
the token retrieval API because otherwise
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-156061452
Dynamic class loading should work then. Would be great if you could
integrate it @nielsbasjes. We understand you're not an average user since
you're an open source software
Github user nielsbasjes commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-155891180
@StephanEwen: I agree. I'll get on it.
@mxm : The current code uses the 1.1.2 API and was tested against a 0.98
HBase cluster. I'm confident this part of the code
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-155770210
I was thinking about something like a reflection-based mechanism. Not sure
though if this will work across different versions. Probably the API didn't
change much in this re
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-155769960
Robert has a good point. Right now, if some one uses HBase, the HBase
dependency is part of the user program JAR. It would be nice to keep HBase out
of the core JAR
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-155768292
Thanks a lot for working on this issue! It doesn't happen everyday that
users identify issues, fix them and verify the fix so properly :)
I would really like to
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1342#discussion_r44527912
--- Diff: flink-yarn/pom.xml ---
@@ -63,6 +63,11 @@ under the License.
test
+
+
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-155764769
The tests on travis are failing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-155719584
Thank you for the testing and the patch. I would like to merge this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user nielsbasjes commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-155708227
I created a test topology that puts the current time in an HBase cell
several times per second.
In the cluster I did this on HBase is configured to use Kerberos a
Github user nielsbasjes commented on a diff in the pull request:
https://github.com/apache/flink/pull/1342#discussion_r44391146
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
@@ -135,7 +142,40 @@ public static void setTokensFor(ContainerLaunchContext
amCont
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-155380888
Thanks for the pull request. Looks good to me except for one comment. I
would like to postpone merging until you have verified the changes.
---
If your project is set up fo
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1342#discussion_r44390519
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java ---
@@ -135,7 +142,40 @@ public static void setTokensFor(ContainerLaunchContext
amContainer, P
Github user nielsbasjes commented on the pull request:
https://github.com/apache/flink/pull/1342#issuecomment-155376887
I ran this version over night but the VPN from my system to the cluster
stopped before the Kerberos ticket could expire.
I am quite confident that this patch is r
GitHub user nielsbasjes opened a pull request:
https://github.com/apache/flink/pull/1342
[FLINK-2977] Added support for accessing a Kerberos secured HBase
installation.
See https://issues.apache.org/jira/browse/FLINK-2977
You can merge this pull request into a Git repository by run
31 matches
Mail list logo
